From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFF3C433DB for ; Mon, 29 Mar 2021 16:24:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 300EC61960 for ; Mon, 29 Mar 2021 16:24:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 300EC61960 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.103163.196890 (Exim 4.92) (envelope-from ) id 1lQugR-0000O7-Ql; Mon, 29 Mar 2021 16:24:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 103163.196890; Mon, 29 Mar 2021 16:24:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQugR-0000O0-Ms; Mon, 29 Mar 2021 16:24:07 +0000 Received: by outflank-mailman (input) for mailman id 103163; Mon, 29 Mar 2021 16:24:06 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lQugQ-0000Nr-Cn for xen-devel@lists.xenproject.org; Mon, 29 Mar 2021 16:24:06 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id de8aa2ce-0cb8-412b-adfd-f36fbae6f849; Mon, 29 Mar 2021 16:24:05 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DF7ECAF4E; Mon, 29 Mar 2021 16:24:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de8aa2ce-0cb8-412b-adfd-f36fbae6f849 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617035045; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nXa7aZhL7k4mbwPdIZACHQpcq75Boe+S6lB0fvSUzm8=; b=JQMgBA/G2J6zgBl6moTvsL6NJXB6lHfwcrCq15HBaTcnBLdumQU980dvkgUSQlP9YfnsLN lLaQUHfAX+Q47cKBamPWHtqHNQbKxqJ8VipGmRSu6M1gCJ21tDcwI8cTZNXWt+cP26hIOi /27BzBych2xqk/kHRkiJObMgODbfhY4= Subject: Re: [PATCH 5/6] CHANGELOG.md: Add entries for emulation To: George Dunlap Cc: Andrew Cooper , "xen-devel@lists.xenproject.org" References: <20210324164407.302062-1-george.dunlap@citrix.com> <20210324164407.302062-5-george.dunlap@citrix.com> <33f78891-c894-b41a-a1a3-82aac1f57b8d@suse.com> <0A187740-DB6E-486C-8B10-5207CE6A5D72@citrix.com> <7407cac8-c55d-0372-123b-39c9949e6ca5@citrix.com> From: Jan Beulich Message-ID: <5b0258db-e362-0085-43e4-78a9b9a88da6@suse.com> Date: Mon, 29 Mar 2021 18:24:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 29.03.2021 18:06, George Dunlap wrote: > > >> On Mar 25, 2021, at 1:58 PM, Jan Beulich wrote: >> >> On 25.03.2021 10:37, Andrew Cooper wrote: >>> On 25/03/2021 09:04, George Dunlap wrote: >>>>> On Mar 25, 2021, at 7:57 AM, Jan Beulich wrote: >>>>> On 24.03.2021 17:44, George Dunlap wrote: >>>>>> --- a/CHANGELOG.md >>>>>> +++ b/CHANGELOG.md >>>>>> @@ -14,6 +14,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) >>>>>> - Named PCI devices for xl/libxl >>>>>> - Support for zstd-compressed dom0 kernels >>>>>> - Library improvements from NetBSD ports upstreamed >>>>>> + - x86_emulate: Support AVX-VNNI instructions >>>>>> + - x86_emulate: Expanded testing for several instruction classes >>>>> TBH both seem too minor to me to be mentioned here. If I was to pick >>>>> just one, I'd keep the former and drop the latter. >>>> It’s always quite difficult in these releases to help express to people exactly what’s happened. We’ve got over 1000 changesets — what have we been doing? If my star chart is correct, the latter represents nearly 1700 extra lines of codes in tools/tests/x86_emulator/predicates.c. It’s actually a reasonable chunk of code churn, which I think is worth highlighting. >>> >>> I agree with Jan. New concrete instruction groups are useful for an end >>> user to read. "We refactored some internal of a test harness" isn't, >>> especially when it would most likely be repeated every release. >>> >>> I'd drop the latter line and just keep the former. >> >> And then perhaps also not focus on the emulator, but merely on the >> fact that guests now can use that ISA extension (for which the >> emulator change is a [the only] prereq)? > > Would you mind giving a concrete suggestion? x86: Allow domains to use AVX-VNNI instructions Jan