From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB1E8C6FD1F for ; Wed, 20 Mar 2024 17:44:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E540110F53E; Wed, 20 Mar 2024 17:44:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="mlFFUer6"; dkim-atps=neutral Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5762910F53E for ; Wed, 20 Mar 2024 17:44:42 +0000 (UTC) Message-ID: <5b360f83-35e7-43e8-bf7e-41ef507aaa77@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710956680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jCZ7epmpA9hJEsGaovdbgtrgipNdUPnMgQxu9pnEkaw=; b=mlFFUer6dYT5baxdMY9XayfBolzlfUzKnk7ErKvEaMS/KS3Do1RC0MQ7Rv0y5qaEmpEtem 24nYx6iJ/RwLUC8bFekG+KRtCqiPx+E4HKNiLNtHUeiBp5q7XBBEdpRYIY5GgdKzaVFnIF 5KdEZ0nMFn8LF2Iy8zwBSoJ9wmG6tiY= Date: Thu, 21 Mar 2024 01:44:34 +0800 MIME-Version: 1.0 Subject: Re: [v5,11/13] drm/ast: Use drm_connector_helper_get_modes() Content-Language: en-US To: Thomas Zimmermann , airlied@redhat.com, jfalempe@redhat.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, jani.nikula@linux.intel.com, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org References: <20240320093738.6341-12-tzimmermann@suse.de> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20240320093738.6341-12-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 2024/3/20 17:34, Thomas Zimmermann wrote: > The .get_modes() code for VGA and SIL164 connectors does not depend > on either type of connector. Replace the driver code with the common > helper drm_connector_helper_get_modes(). It reads EDID data via > DDC and updates the connector's EDID property. > > Signed-off-by: Thomas Zimmermann Reviewed-by: Sui Jingfeng -- Best regards, Sui