From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Date: Wed, 27 Oct 2010 21:30:08 +0000 Subject: Re: [patch] i915: fix impossible BUG_ON() test Message-Id: <5b55a1$ig5qui@fmsmga002.fm.intel.com> List-Id: References: <20101027212534.GM6062@bicker> In-Reply-To: <20101027212534.GM6062@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org On Wed, 27 Oct 2010 23:25:34 +0200, Dan Carpenter wrote: > obj_priv->pin_count is unsigned so the BUG_ON(obj_priv->pin_count < 0) > will never trigger. I have the same change pending, but not queued for -fixes since it is impossible. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [patch] i915: fix impossible BUG_ON() test Date: Wed, 27 Oct 2010 22:30:08 +0100 Message-ID: <5b55a1$ig5qui@fmsmga002.fm.intel.com> References: <20101027212534.GM6062@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E52F79E75F for ; Wed, 27 Oct 2010 14:30:12 -0700 (PDT) In-Reply-To: <20101027212534.GM6062@bicker> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dan Carpenter Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, 27 Oct 2010 23:25:34 +0200, Dan Carpenter wrote: > obj_priv->pin_count is unsigned so the BUG_ON(obj_priv->pin_count < 0) > will never trigger. I have the same change pending, but not queued for -fixes since it is impossible. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre