From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manu Gautam Subject: Re: [PATCH v3 14/16] phy: Add notify_speed callback Date: Wed, 20 Dec 2017 14:11:27 +0530 Message-ID: <5b67c348-4ec9-58ca-05ed-8b93bed77efb@codeaurora.org> References: <1511256206-1587-1-git-send-email-mgautam@codeaurora.org> <1511256206-1587-15-git-send-email-mgautam@codeaurora.org> <082d2ca8-21dc-878f-c668-a76872a7ea92@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:57448 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932070AbdLTIlc (ORCPT ); Wed, 20 Dec 2017 03:41:32 -0500 In-Reply-To: Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, "open list:GENERIC PHY FRAMEWORK" Hi On 12/20/2017 12:47 PM, Kishon Vijay Abraham I wrote: > Hi, > [snip] >>> Why not use a notification mechanism instead of adding new APIs in phy-core. >>> This will only bloat phy-core with APIs for a particular platform. >> Do you mean notifier_chains ? >> When we have multiple instances of USB PHYs then notifier chains are not >> of much help. For any platform glue or PHY driver it will be very difficult to >> figure out if notification received for speed was for same phy/bus or a >> different one. >> Using PHY callbacks looked more elegant to me. Additionally PHY drivers >> can also use this info decide power management policy e.g. if speed is >> INVALID then it means PHY is not in a session and it can enter deepest >> low power state. >> Additionally if you prefer set_speed name over notify_speed then I am >> ok with that as well so that it sounds more generic. > I'd prefer adding modes in enum phy_mode according to speed and using phy_set_mode. yeah, that also seems good idea. How about something like this: --- a/include/linux/phy/phy.h +++ b/include/linux/phy/phy.h @@ -23,12 +23,16 @@ struct phy; enum phy_mode { - PHY_MODE_INVALID, - PHY_MODE_USB_HOST, - PHY_MODE_USB_DEVICE, - PHY_MODE_USB_OTG, - PHY_MODE_SGMII, - PHY_MODE_10GKR, + PHY_MODE_INVALID = 0, + PHY_MODE_USB_HOST = BIT(0), + PHY_MODE_USB_DEVICE = BIT(1), + PHY_MODE_USB_OTG, = BIT(2), + PHY_MODE_SGMII = BIT(3), + PHY_MODE_10GKR = BIT(4), + PHY_MODE_USB_LS = BIT(5), + PHY_MODE_USB_FS = BIT(6), + PHY_MODE_USB_HS = BIT(7), + PHY_MODE_USB_SS = BIT(8), }; This way I don't need to duplicate USB speed enums for host/device or otg modes. > Thanks > Kishon -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,14/16] phy: Add notify_speed callback From: Manu Gautam Message-Id: <5b67c348-4ec9-58ca-05ed-8b93bed77efb@codeaurora.org> Date: Wed, 20 Dec 2017 14:11:27 +0530 To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, "open list:GENERIC PHY FRAMEWORK" List-ID: SGkKCgpPbiAxMi8yMC8yMDE3IDEyOjQ3IFBNLCBLaXNob24gVmlqYXkgQWJyYWhhbSBJIHdyb3Rl Ogo+IEhpLAo+CltzbmlwXQo+Pj4gV2h5IG5vdCB1c2UgYSBub3RpZmljYXRpb24gbWVjaGFuaXNt IGluc3RlYWQgb2YgYWRkaW5nIG5ldyBBUElzIGluIHBoeS1jb3JlLgo+Pj4gVGhpcyB3aWxsIG9u bHkgYmxvYXQgcGh5LWNvcmUgd2l0aCBBUElzIGZvciBhIHBhcnRpY3VsYXIgcGxhdGZvcm0uCj4+ IERvIHlvdSBtZWFuIG5vdGlmaWVyX2NoYWlucyA/Cj4+IFdoZW4gd2UgaGF2ZSBtdWx0aXBsZSBp bnN0YW5jZXMgb2YgVVNCIFBIWXMgdGhlbiBub3RpZmllciBjaGFpbnMgYXJlIG5vdAo+PiBvZiBt dWNoIGhlbHAuIEZvciBhbnkgcGxhdGZvcm0gZ2x1ZSBvciBQSFkgZHJpdmVyIGl0IHdpbGwgYmUg dmVyeSBkaWZmaWN1bHQgdG8KPj4gZmlndXJlIG91dCBpZiBub3RpZmljYXRpb24gcmVjZWl2ZWQg Zm9yIHNwZWVkIHdhcyBmb3Igc2FtZSBwaHkvYnVzIG9yIGEKPj4gZGlmZmVyZW50IG9uZS4KPj4g VXNpbmcgUEhZIGNhbGxiYWNrcyBsb29rZWQgbW9yZSBlbGVnYW50IHRvIG1lLiBBZGRpdGlvbmFs bHkgUEhZIGRyaXZlcnMKPj4gY2FuIGFsc28gdXNlIHRoaXMgaW5mbyBkZWNpZGUgcG93ZXIgbWFu YWdlbWVudCBwb2xpY3kgZS5nLiBpZiBzcGVlZCBpcwo+PiBJTlZBTElEIHRoZW4gaXQgbWVhbnMg UEhZIGlzIG5vdCBpbiBhIHNlc3Npb24gYW5kIGl0IGNhbiBlbnRlciBkZWVwZXN0Cj4+IGxvdyBw b3dlciBzdGF0ZS4KPj4gQWRkaXRpb25hbGx5IGlmIHlvdSBwcmVmZXIgc2V0X3NwZWVkIG5hbWUg b3ZlciBub3RpZnlfc3BlZWQgdGhlbiBJIGFtCj4+IG9rIHdpdGggdGhhdCBhcyB3ZWxsIHNvIHRo YXQgaXQgc291bmRzIG1vcmUgZ2VuZXJpYy4KPiBJJ2QgcHJlZmVyIGFkZGluZyBtb2RlcyBpbiBl bnVtIHBoeV9tb2RlIGFjY29yZGluZyB0byBzcGVlZCBhbmQgdXNpbmcgcGh5X3NldF9tb2RlLgoK eWVhaCwgdGhhdCBhbHNvIHNlZW1zIGdvb2QgaWRlYS4gSG93IGFib3V0IHNvbWV0aGluZyBsaWtl IHRoaXM6CgpUaGlzIHdheSBJIGRvbid0IG5lZWQgdG8gZHVwbGljYXRlIFVTQiBzcGVlZCBlbnVt cyBmb3IgaG9zdC9kZXZpY2Ugb3Igb3RnIG1vZGVzLgoKPiBUaGFua3MKPiBLaXNob24KCi0tLSBh L2luY2x1ZGUvbGludXgvcGh5L3BoeS5oCisrKyBiL2luY2x1ZGUvbGludXgvcGh5L3BoeS5oCkBA IC0yMywxMiArMjMsMTYgQEAKIHN0cnVjdCBwaHk7CiAKIGVudW0gcGh5X21vZGUgewotCVBIWV9N T0RFX0lOVkFMSUQsCi0JUEhZX01PREVfVVNCX0hPU1QsCi0JUEhZX01PREVfVVNCX0RFVklDRSwK LQlQSFlfTU9ERV9VU0JfT1RHLAotCVBIWV9NT0RFX1NHTUlJLAotCVBIWV9NT0RFXzEwR0tSLAor CVBIWV9NT0RFX0lOVkFMSUQJPSAwLAorCVBIWV9NT0RFX1VTQl9IT1NUCT0gQklUKDApLAorCVBI WV9NT0RFX1VTQl9ERVZJQ0UJPSBCSVQoMSksCisJUEhZX01PREVfVVNCX09URywJPSBCSVQoMiks CisJUEhZX01PREVfU0dNSUkJCT0gQklUKDMpLAorCVBIWV9NT0RFXzEwR0tSCQk9IEJJVCg0KSwK KwlQSFlfTU9ERV9VU0JfTFMJCT0gQklUKDUpLAorCVBIWV9NT0RFX1VTQl9GUwkJPSBCSVQoNiks CisJUEhZX01PREVfVVNCX0hTCQk9IEJJVCg3KSwKKwlQSFlfTU9ERV9VU0JfU1MJCT0gQklUKDgp LAogfTsKCgo=