From: Rob Herring <robh@kernel.org>
To: "SZ Lin (林上智)" <sz.lin@moxa.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, "Mark Rutland" <mark.rutland@arm.com>,
"Tony Lindgren" <tony@atomide.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Wes Huang" <wes.huang@moxa.com>,
"Fero JD Zhou" <FeroJD.Zhou@moxa.com>
Subject: Re: [PATCH 3/3] ARM: dts: am335x: add support for Moxa UC-2102 open platform
Date: Mon, 3 Sep 2018 20:06:53 -0500 [thread overview]
Message-ID: <5b8e8a68.1c69fb81.6eb62.cefe@mx.google.com> (raw)
In-Reply-To: <20180830040929.23357-4-sz.lin@moxa.com>
On Thu, Aug 30, 2018 at 12:09:29PM +0800, SZ Lin (林上智) wrote:
> Add support for Moxa UC-2102 open platform
>
> The UC-2102 computing platform is designed for industrial embedded
> data acquisition and processing applications.
>
> The features of UC-2102 are:
> * eMMC
> * SPI flash
> * 2x LAN
> * EEPROM
> * TPM 2.0
> * Watchdog
> * RTC
> * User gpio-keys
> * User LEDs
> * User button
>
> Signed-off-by: Wes Huang (黃淵河) <wes.huang@moxa.com>
> Signed-off-by: Fero JD Zhou (周俊達) <FeroJD.Zhou@moxa.com>
> Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
> ---
> .../devicetree/bindings/arm/omap/omap.txt | 2 +-
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/am335x-moxa-uc-2102.dts | 200 ++++++++++++++++++
> 3 files changed, 202 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm/boot/dts/am335x-moxa-uc-2102.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/omap/omap.txt b/Documentation/devicetree/bindings/arm/omap/omap.txt
> index c5ca3d6a8099..6876eb8263ed 100644
> --- a/Documentation/devicetree/bindings/arm/omap/omap.txt
> +++ b/Documentation/devicetree/bindings/arm/omap/omap.txt
> @@ -158,7 +158,7 @@ Boards:
> compatible = "phytec,am335x-pcm-953", "phytec,am335x-phycore-som", "ti,am33xx"
>
> - AM335X UC-2100: Wireless-enabled palm-sized industrial computing platform
> - compatible = "moxa,uc-2101", "ti,am33xx"
> + compatible = "moxa,uc-2101", "moxa,uc-2102", "ti,am33xx"
The 2102 is a superset of the 2101? If so, the 2102 should come first.
If not, this should probably be 2 separate entries.
>
> - AM335X UC-8100-ME-T: Communication-centric industrial computing platform
> compatible = "moxa,uc-8100-me-t", "ti,am33xx";
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 6167c068601c..15d52cabb1a0 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -707,6 +707,7 @@ dtb-$(CONFIG_SOC_AM33XX) += \
> am335x-icev2.dtb \
> am335x-lxm.dtb \
> am335x-moxa-uc-2101.dtb \
> + am335x-moxa-uc-2102.dtb \
> am335x-moxa-uc-8100-me-t.dtb \
> am335x-nano.dtb \
> am335x-pdu001.dtb \
> diff --git a/arch/arm/boot/dts/am335x-moxa-uc-2102.dts b/arch/arm/boot/dts/am335x-moxa-uc-2102.dts
> new file mode 100644
> index 000000000000..94a7ecc9eb9a
> --- /dev/null
> +++ b/arch/arm/boot/dts/am335x-moxa-uc-2102.dts
> @@ -0,0 +1,200 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2018 MOXA Inc. - https://www.moxa.com/
> + *
> + * Authors: SZ Lin (林上智) <sz.lin@moxa.com>
> + * Wes Huang (黃淵河) <wes.huang@moxa.com>
> + * Fero JD Zhou (周俊達) <FeroJD.Zhou@moxa.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "am335x-moxa-uc-2100-common.dtsi"
> +
> +/ {
> + model = "Moxa UC-2102";
> + compatible = "moxa,uc-2102", "ti,am33xx";
> +
> + leds {
> + compatible = "gpio-leds";
> + led1 {
> + label = "UC2100:GREEN:USER1";
> + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + led2 {
> + label = "UC2100:GREEN:USER2";
> + gpios = <&gpio3 17 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + };
> +};
> +
> +&am33xx_pinmux {
> + pinctrl-names = "default";
> +
> + cpsw_default: cpsw_default {
> + pinctrl-single,pins = <
> + /* Slave 1 */
> + AM33XX_IOPAD(0x90c, PIN_INPUT_PULLDOWN | MUX_MODE1) /* mii1_crs.rmii1_crs_dv */
> + AM33XX_IOPAD(0x910, PIN_INPUT_PULLUP | MUX_MODE1) /* mii1_rxerr.rmii1_rxerr */
> + AM33XX_IOPAD(0x914, PIN_OUTPUT_PULLDOWN | MUX_MODE1) /* mii1_txen.rmii1_txen */
> + AM33XX_IOPAD(0x924, PIN_OUTPUT_PULLDOWN | MUX_MODE1) /* mii1_txd1.rmii1_txd1 */
> + AM33XX_IOPAD(0x928, PIN_OUTPUT_PULLDOWN | MUX_MODE1) /* mii1_txd0.rmii1_txd0 */
> + AM33XX_IOPAD(0x93c, PIN_INPUT_PULLUP | MUX_MODE1) /* mii1_rxd1.rmii1_rxd1 */
> + AM33XX_IOPAD(0x940, PIN_INPUT_PULLUP | MUX_MODE1) /* mii1_rxd0.rmii1_rxd0 */
> + AM33XX_IOPAD(0x944, PIN_INPUT_PULLDOWN | MUX_MODE0) /* mii1_refclk.rmii1_refclk */
> +
> + /* Slave 2 */
> + AM33XX_IOPAD(0x870, PIN_INPUT_PULLDOWN | MUX_MODE3) /* gpmc_wait0.rmii2_crs_dv */
> + AM33XX_IOPAD(0x874, PIN_INPUT_PULLDOWN | MUX_MODE3) /* gpmc_wpn.rmii2_rxer */
> + AM33XX_IOPAD(0x840, PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* gpmc_a0.rmii2_txen */
> + AM33XX_IOPAD(0x854, PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* gpmc_a5.rmii2_td0 */
> + AM33XX_IOPAD(0x850, PIN_OUTPUT_PULLDOWN | MUX_MODE3) /* gpmc_a4.rmii2_td1 */
> + AM33XX_IOPAD(0x86c, PIN_INPUT_PULLDOWN | MUX_MODE3) /* gpmc_a11.rmii2_rd0 */
> + AM33XX_IOPAD(0x868, PIN_INPUT_PULLDOWN | MUX_MODE3) /* gpmc_a10.rmii2_rd1 */
> + AM33XX_IOPAD(0x908, PIN_INPUT_PULLDOWN | MUX_MODE1) /* gmii1_col.rmii2_refclk */
> + >;
> + };
> +
> + mmc0_pins_default: pinmux_mmc0_pins {
> + pinctrl-single,pins = <
> + AM33XX_IOPAD(0x8f0, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc0_dat3.mmc0_dat3 */
> + AM33XX_IOPAD(0x8f4, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc0_dat2.mmc0_dat2 */
> + AM33XX_IOPAD(0x8f8, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc0_dat1.mmc0_dat1 */
> + AM33XX_IOPAD(0x8fc, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc0_dat0.mmc0_dat0 */
> + AM33XX_IOPAD(0x900, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc0_clk.mmc0_clk */
> + AM33XX_IOPAD(0x904, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc0_cmd.mmc0_cmd */
> + AM33XX_IOPAD(0x990, PIN_INPUT_PULLUP | MUX_MODE7) /* mcasp0_aclkx.mmc0_sdcd */
> + >;
> + };
> +
> + spi1_pins: pinmux_spi1 {
> + pinctrl-single,pins = <
> + AM33XX_IOPAD(0x964, PIN_INPUT_PULLUP | MUX_MODE4) /* ecap0_in_pwm0_out.spi1_sclk */
> + AM33XX_IOPAD(0x978, PIN_INPUT_PULLUP | MUX_MODE4) /* uart1_ctsn.spi1_cs0 */
> + AM33XX_IOPAD(0x968, PIN_INPUT_PULLUP | MUX_MODE4) /* uart0_ctsn.spi1_d0 */
> + AM33XX_IOPAD(0x96c, PIN_INPUT_PULLUP | MUX_MODE4) /* uart0_rtsn.spi1_d1 */
> + >;
> + };
> +};
> +
> +&i2c0 {
> + tps: tps@2d {
> + compatible = "ti,tps65910";
> + reg = <0x2d>;
> + };
> +};
> +
> +#include "tps65910.dtsi"
> +
> +&tps {
> + vcc1-supply = <&vbat>;
> + vcc2-supply = <&vbat>;
> + vcc3-supply = <&vbat>;
> + vcc4-supply = <&vbat>;
> + vcc5-supply = <&vbat>;
> + vcc6-supply = <&vbat>;
> + vcc7-supply = <&vbat>;
> + vccio-supply = <&vbat>;
> +
> + regulators {
> + vrtc_reg: regulator@0 {
Without a reg property, you shouldn't have unit addresses.
> + regulator-always-on;
> + };
> +
> + vio_reg: regulator@1 {
> + regulator-always-on;
> + };
> +
> + vdd1_reg: regulator@2 {
> + /* VDD_MPU voltage limits 0.95V - 1.26V with +/-4% tolerance */
> + regulator-name = "vdd_mpu";
> + regulator-min-microvolt = <912500>;
> + regulator-max-microvolt = <1378000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + vdd2_reg: regulator@3 {
> + /* VDD_CORE voltage limits 0.95V - 1.1V with +/-4% tolerance */
> + regulator-name = "vdd_core";
> + regulator-min-microvolt = <912500>;
> + regulator-max-microvolt = <1150000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> +
> + vdd3_reg: regulator@4 {
> + regulator-always-on;
> + };
> +
> + vdig1_reg: regulator@5 {
> + regulator-always-on;
> + };
> +
> + vdig2_reg: regulator@6 {
> + regulator-always-on;
> + };
> +
> + vpll_reg: regulator@7 {
> + regulator-always-on;
> + };
> +
> + vdac_reg: regulator@8 {
> + regulator-always-on;
> + };
> +
> + vaux1_reg: regulator@9 {
> + regulator-always-on;
> + };
> +
> + vaux2_reg: regulator@10 {
> + regulator-always-on;
> + };
> +
> + vaux33_reg: regulator@11 {
> + regulator-always-on;
> + };
> +
> + vmmc_reg: regulator@12 {
> + compatible = "regulator-fixed";
> + regulator-name = "vmmc_reg";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> + };
> +};
> +
> +&mac {
> + pinctrl-names = "default";
> + pinctrl-0 = <&cpsw_default>;
> + dual_emac = <1>;
> + status = "okay";
> +};
> +
> +&cpsw_emac0 {
> + status = "okay";
> + phy_id = <&davinci_mdio>, <0x4>;
> + phy-mode = "rmii";
> + dual_emac_res_vlan = <1>;
> +};
> +
> +&cpsw_emac1 {
> + status = "okay";
> + phy_id = <&davinci_mdio>, <0x5>;
> + phy-mode = "rmii";
> + dual_emac_res_vlan = <2>;
> +};
> +
> +&mmc1 {
> + pinctrl-names = "default";
> + vmmc-supply = <&vmmcsd_fixed>;
> + bus-width = <4>;
> + pinctrl-0 = <&mmc0_pins_default>;
> + cd-gpios = <&gpio3 14 GPIO_ACTIVE_HIGH>;
> + wp-gpios = <&gpio3 18 GPIO_ACTIVE_HIGH>;
> + status = "okay";
> +};
> --
> 2.19.0.rc1
>
next prev parent reply other threads:[~2018-09-04 1:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 4:09 [PATCH 0/3] ARM: dts: am335x: add support for Moxa UC-2100 series SZ Lin (林上智)
2018-08-30 4:09 ` [PATCH 1/3] ARM: dts: am335x: add common file for " SZ Lin (林上智)
2018-08-30 4:09 ` [PATCH 2/3] ARM: dts: am335x: add support for Moxa UC-2101 open platform SZ Lin (林上智)
2018-08-30 23:46 ` Grygorii Strashko
2018-09-17 6:53 ` SZ Lin (林上智)
2018-09-18 12:50 ` Grygorii Strashko
2018-09-04 1:03 ` Rob Herring
2018-08-30 4:09 ` [PATCH 3/3] ARM: dts: am335x: add support for Moxa UC-2102 " SZ Lin (林上智)
2018-09-04 1:06 ` Rob Herring [this message]
2018-09-17 7:38 ` SZ Lin (林上智)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b8e8a68.1c69fb81.6eb62.cefe@mx.google.com \
--to=robh@kernel.org \
--cc=FeroJD.Zhou@moxa.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sz.lin@moxa.com \
--cc=tony@atomide.com \
--cc=wes.huang@moxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.