From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMZWU-00021D-T8 for ath10k@lists.infradead.org; Thu, 09 Apr 2020 15:55:26 +0000 MIME-Version: 1.0 Date: Thu, 09 Apr 2020 23:55:07 +0800 From: Wen Gong Subject: Re: [PATCH v9 3/4] ath10k: add htt TX bundle for sdio In-Reply-To: <87lfn4u0lq.fsf@kamboji.qca.qualcomm.com> References: <20200212080415.31265-1-wgong@codeaurora.org> <20200212080415.31265-4-wgong@codeaurora.org> <87pncgu2ba.fsf@kamboji.qca.qualcomm.com> <36ee3bed6f7cd200df0755209ec6bbc2@codeaurora.org> <87lfn4u0lq.fsf@kamboji.qca.qualcomm.com> Message-ID: <5b90a59dad4f40333e185397b295219d@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kalle Valo Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org On 2020-04-09 23:42, Kalle Valo wrote: > Wen Gong writes: > >> On 2020-04-09 23:05, Kalle Valo wrote: >> >>>> + ep->tx_credits -= credits; >>>> + ath10k_dbg(ar, ATH10K_DBG_HTC, >>>> + "htc ep %d consumed %d credits (total %d)\n", >>> >>> "htc ep %d consumed %d credits total %d\n" >>> >>> [...] >>> >>>> + ath10k_dbg(ar, ATH10K_DBG_HTC, "bundle skb: len:%d\n", >>>> bundle_skb->len); >>> >>> "htc bundle skb len %d\n" >>> >>> In other words, start with "htc" and don't use colons or parenthesis. >>> This applies to most of debug messages in this patch. >> >> I will change the log and other log and sent v10. >> but "ath10k: disable TX complete indication of htt for sdio" and >> "ath10k: change ATH10K_SDIO_BUS_REQUEST_MAX_NUM from 64 to 1024" has >> appied to ath-next, >> so I only need to send the left 2 patches: >> "ath10k: add htt TX bundle for sdio" and "ath10k: enable alt data of >> TX path for sdio", right? > > Correct, I already applied patches 1 and 2. But before you resend > patches 3-4 did you see my question about creating a new thread, is it > really necessary? already replied. _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89C55C2BA2B for ; Thu, 9 Apr 2020 15:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5715720771 for ; Thu, 9 Apr 2020 15:55:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="fE6c9BhN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728343AbgDIPzd (ORCPT ); Thu, 9 Apr 2020 11:55:33 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:50937 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728287AbgDIPzc (ORCPT ); Thu, 9 Apr 2020 11:55:32 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586447733; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=vKQQD+LpyQn8hyW482cb70w6C2mZNVsZk6XSSGWg0b8=; b=fE6c9BhNhgm2Igj7rg2GYhixlG3hAkfjL12VNpoYEo/fWFdyGAiRzdI0wUNDT8bbWuUc/nh8 UlzGpHAZHgdrVWXT0AActyPrtS16nSzA9D9BynROLvbRiZnASGoy1WK9LRvmVVE284iBP9on DC0ZU1vRk1/120J4j0xd2bgbWsk= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8f455f.7f887a4e4ce0-smtp-out-n01; Thu, 09 Apr 2020 15:55:11 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 964ADC433BA; Thu, 9 Apr 2020 15:55:07 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: wgong) by smtp.codeaurora.org (Postfix) with ESMTPSA id 50047C433CB; Thu, 9 Apr 2020 15:55:07 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 09 Apr 2020 23:55:07 +0800 From: Wen Gong To: Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v9 3/4] ath10k: add htt TX bundle for sdio In-Reply-To: <87lfn4u0lq.fsf@kamboji.qca.qualcomm.com> References: <20200212080415.31265-1-wgong@codeaurora.org> <20200212080415.31265-4-wgong@codeaurora.org> <87pncgu2ba.fsf@kamboji.qca.qualcomm.com> <36ee3bed6f7cd200df0755209ec6bbc2@codeaurora.org> <87lfn4u0lq.fsf@kamboji.qca.qualcomm.com> Message-ID: <5b90a59dad4f40333e185397b295219d@codeaurora.org> X-Sender: wgong@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-04-09 23:42, Kalle Valo wrote: > Wen Gong writes: > >> On 2020-04-09 23:05, Kalle Valo wrote: >> >>>> + ep->tx_credits -= credits; >>>> + ath10k_dbg(ar, ATH10K_DBG_HTC, >>>> + "htc ep %d consumed %d credits (total %d)\n", >>> >>> "htc ep %d consumed %d credits total %d\n" >>> >>> [...] >>> >>>> + ath10k_dbg(ar, ATH10K_DBG_HTC, "bundle skb: len:%d\n", >>>> bundle_skb->len); >>> >>> "htc bundle skb len %d\n" >>> >>> In other words, start with "htc" and don't use colons or parenthesis. >>> This applies to most of debug messages in this patch. >> >> I will change the log and other log and sent v10. >> but "ath10k: disable TX complete indication of htt for sdio" and >> "ath10k: change ATH10K_SDIO_BUS_REQUEST_MAX_NUM from 64 to 1024" has >> appied to ath-next, >> so I only need to send the left 2 patches: >> "ath10k: add htt TX bundle for sdio" and "ath10k: enable alt data of >> TX path for sdio", right? > > Correct, I already applied patches 1 and 2. But before you resend > patches 3-4 did you see my question about creating a new thread, is it > really necessary? already replied.