From: Jan Beulich <jbeulich@suse.com>
To: Jason Andryuk <jason.andryuk@amd.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Julien Grall" <julien@xen.org>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 5/5] x86/PVH: Support relocatable dom0 kernels
Date: Tue, 26 Mar 2024 14:30:03 +0100 [thread overview]
Message-ID: <5b9d07ad-159d-4384-924e-e772e6ec4ede@suse.com> (raw)
In-Reply-To: <efc5ea8f-d087-4fe0-a5f3-6d1b0a8b48dc@amd.com>
On 26.03.2024 14:24, Jason Andryuk wrote:
> On 2024-03-26 03:50, Jan Beulich wrote:
>> On 25.03.2024 21:45, Jason Andryuk wrote:
>>> + * - a minimum address for the start of the image (default 0)
>>> + * - a required start alignment (default 0x200000)
>>> + *
>>> + * This note is only valid for x86 binaries.
>>
>> Maybe s/valid/recognized/ (or honored or some such)?
>
> Would a comment at the top of the file saying Notes are only used with
> x86 be better instead of this one-off comment? Roger already said that,
> and elf_xen_note_check() has a successful early exit with "ELF: Not
> bothering with notes on ARM\n"
If truly none of the notes are of interest for Arm, then yes, such a more
general comment would likely make sense.
Jan
next prev parent reply other threads:[~2024-03-26 13:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 20:45 [PATCH v4 0/5] x86/pvh: Support relocating dom0 kernel Jason Andryuk
2024-03-25 20:45 ` [PATCH v4 1/5] Revert "xen/x86: bzImage parse kernel_alignment" Jason Andryuk
2024-03-25 20:45 ` [PATCH v4 2/5] tools/init-xenstore-domain: Replace variable MB() usage Jason Andryuk
2024-04-03 12:27 ` Anthony PERARD
2024-03-25 20:45 ` [PATCH v4 3/5] tools: Move MB/GB() to common-macros.h Jason Andryuk
2024-03-26 7:30 ` Jan Beulich
2024-03-25 20:45 ` [PATCH v4 4/5] libelf: Expand ELF note printing Jason Andryuk
2024-03-26 7:51 ` Jan Beulich
2024-03-25 20:45 ` [PATCH v4 5/5] x86/PVH: Support relocatable dom0 kernels Jason Andryuk
2024-03-26 7:50 ` Jan Beulich
2024-03-26 13:24 ` Jason Andryuk
2024-03-26 13:30 ` Jan Beulich [this message]
2024-03-26 13:40 ` Jan Beulich
2024-03-26 15:41 ` Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b9d07ad-159d-4384-924e-e772e6ec4ede@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jason.andryuk@amd.com \
--cc=julien@xen.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.