All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Anson Huang <Anson.Huang@nxp.com>
Cc: dmitry.torokhov@gmail.com, mark.rutland@arm.com,
	marco.franchi@nxp.com, fabio.estevam@nxp.com,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Linux-imx@nxp.com
Subject: Re: [PATCH 2/2] dt-bindings: egalax-ts: add support for wakeup event action
Date: Sun, 16 Sep 2018 17:54:33 -0500	[thread overview]
Message-ID: <5b9f3f5d.1c69fb81.bca6d.cdee@mx.google.com> (raw)
In-Reply-To: <1536139607-16848-2-git-send-email-Anson.Huang@nxp.com>

On Wed, Sep 05, 2018 at 05:26:47PM +0800, Anson Huang wrote:
> Add support for wakeup event action, this would allow the device
> to configure whether to be a wakeup source of system suspend.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
>  Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
> index 92fb262..296a9cd 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
> @@ -6,6 +6,7 @@ Required properties:
>  - interrupts: touch controller interrupt
>  - wakeup-gpios: the gpio pin to be used for waking up the controller
>    and also used as irq pin

If the wakeup gpio is the same as the irq, then this should be removed 
since wakeup-source replaces it.

> +- wakeup-source: boolean, touch screen can wake-up the system
>  
>  Example:
>  
> @@ -15,4 +16,5 @@ Example:
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <9 2>;
>  		wakeup-gpios = <&gpio1 9 0>;
> +		wakeup-source;
>  	};
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-09-16 22:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  9:26 [PATCH 1/2] input: egalax_ts: add system wakeup support Anson Huang
2018-09-05  9:26 ` [PATCH 2/2] dt-bindings: egalax-ts: add support for wakeup event action Anson Huang
2018-09-16 22:54   ` Rob Herring [this message]
2018-09-17 18:07     ` Dmitry Torokhov
2018-09-19  1:01       ` Rob Herring
2018-09-05 10:34 ` [PATCH 1/2] input: egalax_ts: add system wakeup support Andi Shyti
2018-09-05 17:27 ` Dmitry Torokhov
2018-09-06  3:30   ` Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b9f3f5d.1c69fb81.bca6d.cdee@mx.google.com \
    --to=robh@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=Linux-imx@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fabio.estevam@nxp.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.franchi@nxp.com \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.