From: Jiri Slaby <jirislaby@kernel.org>
To: Rengarajan S <rengarajan.s@microchip.com>,
kumaravel.thiagarajan@microchip.com,
tharunkumar.pasumarthi@microchip.com, gregkh@linuxfoundation.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
unglinuxdriver@microchip.com
Subject: Re: [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs
Date: Fri, 23 Feb 2024 07:08:43 +0100 [thread overview]
Message-ID: <5bf4ba6d-d8e3-4ba6-a889-cfae8c3ddabe@kernel.org> (raw)
In-Reply-To: <20240222134944.1131952-1-rengarajan.s@microchip.com>
On 22. 02. 24, 14:49, Rengarajan S wrote:
> Updated the TX Burst implementation by changing the circular buffer
> processing with the pre-existing APIs in kernel. Also updated conditional
> statements and alignment issues for better readability.
Hi,
so why are you keeping the nested double loop?
--
js
suse labs
next prev parent reply other threads:[~2024-02-23 6:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 13:49 [PATCH v1 tty] 8250: microchip: pci1xxxx: Refactor TX Burst code to use pre-existing APIs Rengarajan S
2024-02-22 16:01 ` Ilpo Järvinen
2024-02-23 9:22 ` Rengarajan.S
2024-02-23 6:08 ` Jiri Slaby [this message]
2024-02-23 9:21 ` Rengarajan.S
2024-02-23 9:26 ` Jiri Slaby
2024-02-23 9:36 ` Rengarajan.S
2024-03-04 4:37 ` Rengarajan.S
2024-03-04 6:19 ` Jiri Slaby
2024-03-05 4:15 ` Rengarajan.S
2024-03-05 7:19 ` Jiri Slaby
2024-03-06 6:55 ` Rengarajan.S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bf4ba6d-d8e3-4ba6-a889-cfae8c3ddabe@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rengarajan.s@microchip.com \
--cc=tharunkumar.pasumarthi@microchip.com \
--cc=unglinuxdriver@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.