From: Florian Fainelli <f.fainelli@gmail.com>
To: Doug Berger <opendmb@gmail.com>, "David S. Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] net: bcmgenet: add support for ethtool flow control
Date: Mon, 11 May 2020 20:24:24 -0700 [thread overview]
Message-ID: <5c0bc3b6-e2f3-e08d-d84a-86d00d2dcd4a@gmail.com> (raw)
In-Reply-To: <1589243050-18217-5-git-send-email-opendmb@gmail.com>
On 5/11/2020 5:24 PM, Doug Berger wrote:
> This commit extends the supported ethtool operations to allow MAC
> level flow control to be configured for the bcmgenet driver. It
> provides an example of how the new phy_set_pause function and the
> phy_validate_pause function can be used to configure the desired
> PHY advertising as well as how the phy_get_pause function can be
> used for resolving negotiated pause modes which may be overridden
> by the MAC.
>
> The ethtool utility can be used to change the configuration to enable
> auto-negotiated symmetric and asymmetric modes as well as manually
> enabling support for RX and TX Pause frames individually.
>
> Signed-off-by: Doug Berger <opendmb@gmail.com>
[snip]
Only if you need to respin this patch series, I would rename
_flow_control_autoneg() to bcmgenet_flow_control_autoneg() or something
shorter that still contains bcmgenet_ as a prefix for consistency.
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-05-12 3:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 0:24 [PATCH net-next 0/4] Extend phylib implementation of pause support Doug Berger
2020-05-12 0:24 ` [PATCH net-next 1/4] net: ethernet: validate pause autoneg setting Doug Berger
2020-05-12 0:47 ` Andrew Lunn
2020-05-12 18:31 ` Doug Berger
2020-05-12 18:37 ` Andrew Lunn
2020-05-12 18:55 ` Russell King - ARM Linux admin
2020-05-13 3:48 ` Doug Berger
2020-05-13 5:34 ` Russell King - ARM Linux admin
2020-05-13 9:20 ` Russell King - ARM Linux admin
2020-05-13 13:49 ` Andrew Lunn
2020-05-13 14:59 ` Michal Kubecek
2020-05-13 17:14 ` Russell King - ARM Linux admin
2020-05-13 22:09 ` Doug Berger
2020-05-13 21:31 ` Doug Berger
2020-05-13 21:27 ` Doug Berger
2020-05-12 19:08 ` Michal Kubecek
2020-05-13 2:37 ` Doug Berger
2020-05-12 3:16 ` Florian Fainelli
2020-05-12 0:24 ` [PATCH net-next 2/4] net: add autoneg parameter to linkmode_set_pause Doug Berger
2020-05-12 0:24 ` [PATCH net-next 3/4] net: ethernet: introduce phy_set_pause Doug Berger
2020-05-12 0:51 ` Andrew Lunn
2020-05-12 18:46 ` Doug Berger
2020-05-12 3:22 ` Florian Fainelli
2020-05-13 9:42 ` Russell King - ARM Linux admin
2020-05-13 21:39 ` Doug Berger
2020-05-12 0:24 ` [PATCH net-next 4/4] net: bcmgenet: add support for ethtool flow control Doug Berger
2020-05-12 3:24 ` Florian Fainelli [this message]
2020-05-13 9:52 ` Russell King - ARM Linux admin
2020-05-13 22:00 ` Doug Berger
-- strict thread matches above, loose matches on Subject: below --
2021-09-26 3:21 [PATCH net-next 0/4] net: bcmgenet: support for " Florian Fainelli
2021-09-26 3:21 ` [PATCH net-next 4/4] net: bcmgenet: add support for ethtool " Florian Fainelli
2021-09-26 14:26 ` Andrew Lunn
2021-10-12 19:13 ` Doug Berger
2021-10-25 17:15 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c0bc3b6-e2f3-e08d-d84a-86d00d2dcd4a@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.