From: Derrick Stolee <stolee@gmail.com>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: gitster@pobox.com, Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] ls-files: conditionally leave index sparse
Date: Wed, 27 Aug 2025 15:36:18 -0400 [thread overview]
Message-ID: <5c19f2f4-1d04-424d-9720-6db4342aebdd@gmail.com> (raw)
In-Reply-To: <c1f2e7b1-7583-4e1e-8f20-584a7a768286@gmail.com>
On 8/26/2025 12:40 PM, Derrick Stolee wrote:
> On 8/15/2025 12:12 PM, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <stolee@gmail.com>
> ...
>> Replace this global check to expand the index with a check inside the
>> loop for a matched sparse directory. If we see one, then expand the
>> index and continue from the current location. This is safe since the
>> previous entries in the index did not have any sparse directories and
>> thus would remain stable in this expansion.
> ...> Here's a small sparse index performance update based on a user report.
>
> I know this is small and somewhat niche, but it hasn't had any review
> or been picked up in What's Cooking. Could someone please take a look?
Thanks, Elijah and Junio for reviewing.
By coincidence, a user reported an issue where the sparse index was
expanded during "git mergetool" and it was due to a pathspec-focused
ls-files subcommand. So maybe it's less niche than I had thought.
Thanks,
-Stolee
next prev parent reply other threads:[~2025-08-27 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 16:12 [PATCH] ls-files: conditionally leave index sparse Derrick Stolee via GitGitGadget
2025-08-26 16:40 ` Derrick Stolee
2025-08-27 19:36 ` Derrick Stolee [this message]
2025-08-28 15:02 ` Junio C Hamano
2025-08-26 18:37 ` Elijah Newren
2025-08-26 19:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c19f2f4-1d04-424d-9720-6db4342aebdd@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.