From: Chao Yu via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Nanzhe Zhao <nzzhao.sigma@gmail.com>,
linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Barry Song <baohua@kernel.org>, Juan Yescas <jyescas@google.com>,
Daeho Jeong <daehojeong@google.com>, Dev Jain <Dev.Jain@arm.com>,
David Hildenbrand <David.Hildenbrand@arm.com>,
linux-kernel@vger.kernel.org, Pengfei Li <lipengfei28@xiaomi.com>,
Bo Zhang <zhangbo56@xiaomi.com>,
Kalesh Singh <kaleshsingh@google.com>,
Nanzhe Zhao <nzzhao@126.com>, Nanzhe Zhao <zhaonanzhe@xiaomi.com>,
Ryan Roberts <Ryan.Roberts@arm.com>
Subject: Re: [f2fs-dev] [PATCH v5 09/16] f2fs: optimize small block size large folio read
Date: Mon, 19 Oct 2026 20:15:22 +0800 [thread overview]
Message-ID: <5c409e48-a6ff-4572-83ea-8e63d8e3552a@kernel.org> (raw)
In-Reply-To: <20261014064445.2835813-10-zhaonanzhe@xiaomi.com>
On 10/14/26 14:44, Nanzhe Zhao wrote:
> @@ -3214,17 +3227,19 @@ static int f2fs_read_data_large_folio(struct inode *inode,
> * If the page is under writeback, we need to wait for
> * its completion to see the correct decrypted data.
> */
> - f2fs_wait_on_block_writeback(inode, block_nr);
> + f2fs_wait_on_block_writeback_range(inode, block_nr, len_blks);
Oops, sorry, I didn't notice there is unnecessary f2fs_truncate_meta_caches()
in f2fs_wait_on_block_writeback_range(), so still we'd better just use
f2fs_wait_on_block_writeback here?
void f2fs_wait_on_block_writeback_range(struct inode *inode, block_t blkaddr,
block_t len)
{
struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
block_t i;
if (!f2fs_meta_inode_gc_required(inode))
return;
for (i = 0; i < len; i++)
f2fs_wait_on_block_writeback(inode, blkaddr + i);
f2fs_truncate_meta_caches(sbi, blkaddr, len); <------------
}
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2026-10-19 12:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 6:44 [f2fs-dev] [PATCH v5 00/16] f2fs: support & optimize large folios for writable files Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 01/16] f2fs: extend folio state for large folio write path Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 02/16] f2fs: carry subpage offset and count in write IO Nanzhe Zhao
2026-10-14 16:18 ` Nanzhe Zhao
2026-10-15 2:37 ` Jaegeuk Kim via Linux-f2fs-devel
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 03/16] f2fs: support regular file buffered writes on large folios Nanzhe Zhao
2026-10-14 16:18 ` Nanzhe Zhao
2026-10-15 13:11 ` Chao Yu via Linux-f2fs-devel
2026-10-16 0:04 ` Chao Yu via Linux-f2fs-devel
2026-10-16 5:52 ` Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 04/16] f2fs: support atomic file large folios buffered write Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 05/16] f2fs: support large folio writeback Nanzhe Zhao
2026-10-14 16:19 ` Nanzhe Zhao
2026-10-16 0:39 ` Chao Yu via Linux-f2fs-devel
2026-10-16 3:57 ` Chao Yu via Linux-f2fs-devel
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 06/16] f2fs: account large folio dirty data at block granularity Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 07/16] f2fs: prepare mmap write faults for large folios Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 08/16] f2fs: make GC migration large-folio aware Nanzhe Zhao
2026-10-14 16:20 ` Nanzhe Zhao
2026-10-16 11:25 ` Chao Yu via Linux-f2fs-devel
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 09/16] f2fs: optimize small block size large folio read Nanzhe Zhao
2026-10-19 12:15 ` Chao Yu via Linux-f2fs-devel [this message]
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 10/16] f2fs: support partial uptodate " Nanzhe Zhao
2026-10-14 16:20 ` Nanzhe Zhao
2026-10-15 13:34 ` Chao Yu via Linux-f2fs-devel
2026-10-19 11:52 ` Chao Yu via Linux-f2fs-devel
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 11/16] f2fs: handle partial truncate of large folio dirty subpages Nanzhe Zhao
2026-10-14 16:20 ` Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 12/16] f2fs: wait for folio writeback before ffs_detach_free Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 13/16] f2fs: fix zeroing paths for large folios Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 14/16] f2fs: handle block cloning within the same large folio Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 15/16] f2fs: allow large folio support to writeable files Nanzhe Zhao
2026-10-14 6:44 ` [f2fs-dev] [PATCH v5 16/16] f2fs: make compressed files compatible with large folio Nanzhe Zhao
2026-10-14 23:23 ` [f2fs-dev] [PATCH v5 00/16] f2fs: support & optimize large folios for writable files Jaegeuk Kim via Linux-f2fs-devel
2026-10-15 2:13 ` Jaegeuk Kim via Linux-f2fs-devel
2026-10-15 2:36 ` Chao Yu via Linux-f2fs-devel
2026-10-15 3:33 ` Nanzhe Zhao
2026-10-15 16:19 ` Jaegeuk Kim via Linux-f2fs-devel
2026-10-15 21:27 ` Jaegeuk Kim via Linux-f2fs-devel
2026-10-17 10:00 ` Nanzhe Zhao
2026-10-19 15:21 ` Jaegeuk Kim via Linux-f2fs-devel
2026-10-15 8:40 ` Nanzhe Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c409e48-a6ff-4572-83ea-8e63d8e3552a@kernel.org \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=David.Hildenbrand@arm.com \
--cc=Dev.Jain@arm.com \
--cc=Ryan.Roberts@arm.com \
--cc=baohua@kernel.org \
--cc=chao@kernel.org \
--cc=daehojeong@google.com \
--cc=jaegeuk@kernel.org \
--cc=jyescas@google.com \
--cc=kaleshsingh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lipengfei28@xiaomi.com \
--cc=nzzhao.sigma@gmail.com \
--cc=nzzhao@126.com \
--cc=zhangbo56@xiaomi.com \
--cc=zhaonanzhe@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.