From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB63AC433FE for ; Mon, 17 Oct 2022 06:18:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C9A1484F00; Mon, 17 Oct 2022 08:18:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=prevas.dk header.i=@prevas.dk header.b="iTXzCOz0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 930A284F4C; Mon, 17 Oct 2022 08:18:56 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80091.outbound.protection.outlook.com [40.107.8.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 31C8084F00 for ; Mon, 17 Oct 2022 08:18:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=prevas.dk Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A2CeWoWMlCNolf07wF9dHveLJKjMrXF5zvI5S3sVL4DWmFF9YtTlxgYzu55NdyX/Q/eXxBda3fHzqOpWiTMvNiZrayJq7NL4aNEFrTml8jZR3BVtQo0a1RNVSLzsFJgpSy0WMrmz+yy14pr0s1vycqi1/oMDOWKJpA1XYmxfioN5gHp6icLljc7A6TV3m1gA1/IHvRUWJivBAXGRGc5XCfTkYUa1BB04tFc+Usu4q8u6OZISnqaHZxgDyMZDT9s5iWtoGGiGjdloLKpA2n/F43y2aH0ws5sXDgndrOgUm4l7LZ3Jt8oHmudj3qi6xUOXSAlpyqGJaiB0mtJc0EdbeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NPLt0U0YBzpxn/WfRaoXxfNISdgWY8tXIOhoyXO18nY=; b=m71auPnF27RQW/ZcXlTL+Dp0QciHDtN8dl28ouAeRvyR6dCN2jydlcI9CGnSx62YsuunrVcVj92JqMytmQmQ5gqjhndkMT0+ffZEl6NK3WoiACmB4i2CEk9rlwHwt11N4t8DURqT0XXDzkwbOSMRG5k2vWrOOSyAj97tLowUGz2xYOnbEUrl7SYvj3Pq3hAuBK4D2Bg+Z1gjOIoNl4Xc9KeXQ21+xp62YYdG0Ad0n6lAl3/Nxwg6rQxpb20APrOjOU4BN7eED9RAUqxnaNv0uPx6BEmEXhyXXI+vkUyh3MediRzF+8JYCQLFuXbL3rxz+m55O5VtDEacfNjEzxwTAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NPLt0U0YBzpxn/WfRaoXxfNISdgWY8tXIOhoyXO18nY=; b=iTXzCOz0fThznI6kQ65pP0obSRU/qvWurHtQLt1gFlHasHb/iU/YUn8UbMwYAbHYfmq7bq20V9r0SZI0ngORHJc026wccEnmaN6dncJEdBJfTIMwlmt3DY8STBXdFzWz/yhYVtNtRqfwyvMWn16dRl3Siz3LwHWJaKrfScfRxd4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=prevas.dk; Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) by AM7PR10MB3974.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:13e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.30; Mon, 17 Oct 2022 06:18:52 +0000 Received: from DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::732f:4316:a0be:bdbc]) by DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM ([fe80::732f:4316:a0be:bdbc%3]) with mapi id 15.20.5723.032; Mon, 17 Oct 2022 06:18:52 +0000 Message-ID: <5c79eb7d-0f56-c152-4232-5bb13bb001b5@prevas.dk> Date: Mon, 17 Oct 2022 08:18:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 5/6] net: tftp: use IS_ENABLED(CONFIG_NET_TFTP_VARS) instead of #if Content-Language: en-US To: Ramon Fried Cc: u-boot@lists.denx.de, Fabio Estevam , Nicolas Bidron , Tom Rini , Joe Hershberger References: <20221014174342.3216982-1-rasmus.villemoes@prevas.dk> <20221014174342.3216982-6-rasmus.villemoes@prevas.dk> From: Rasmus Villemoes In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MM0P280CA0102.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:9::23) To DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:34a::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR10MB5266:EE_|AM7PR10MB3974:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e41f9a4-e4bb-4337-e5ef-08dab007760c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eyMkga6wiw9jGkaEQxPlT3oyb0jq4EddR7zOziAjugPntDdlcYhQxeyfgua7qY7Vj1ZGiz4+IejiSzSZ8gIRCx+p+KDwPR4OPGELk1YMHYvUuP8iR6whZIfGqDQtScFqykh/EinwZ5IVnexrZzda/XF5B8W52Nk/P1VpRCvdrwV+27jMok25z8E7Uhazh7oR88d/8qZHZB1WBTa4oPlepPFzSl818g3PRA/NCwjzkh+/52oFGhvyGnA8dIayKdqOK6sgF3Q9GZko2pgDlLvXY1us+LZCEwTS9ybz9GKsrTuR2TykjSPD4ENNeR6auQ2q43RhZPezSjnwo7ukZ4/STpFBCBPtVOryi0wQpFuJ1d1yr7mk9oB0LeYLEKTvoSB6B8dVs53kh1WoecsLyduL+2KM5yvDrcGnkByUJUEonEKUGbZT19RtdSgSrz++NErlwCQEfY55Z0FL2fFPi46eJGxoZD2zgpZgb1O1EnM/QqAeyepNztNbJIu1GhTpDaXba/E6nbH+b+ovmGCCh/r1tdoe6oGjXKoq9HHZN5UdsEpUiK2OinFW4ZnKlNj3cGGST6zcKrp7Z4tyx0M1B7snil//LV8jwuWlBmSWGu/NBlKcrGhovRqL2QY1VJhlGIuUS8O2auYQ2qrCowjFw+ih5Hz1ORJ3hEPSWkOJFC4b8GER6Lx5rJgaW1LxkeHT5GKQFGd15R3ddVB/Q+U/IoLy0wIN1lKg6Yn9JuUF4uYJuvw9r45ipZXj/OWLKSjjLbQaeKNL1ZJF5sax2JCLYDSGsvnxQMbiXVCA6n6AKsRc8++io/5e99jf61KGz4A6LcZw X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(136003)(346002)(39830400003)(396003)(451199015)(31686004)(83380400001)(2906002)(2616005)(186003)(36756003)(26005)(4326008)(8676002)(6506007)(6512007)(52116002)(53546011)(41300700001)(86362001)(31696002)(316002)(54906003)(38100700002)(38350700002)(66476007)(8976002)(8936002)(66556008)(5660300002)(66946007)(6916009)(44832011)(478600001)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGdDNmtmZFZVODR0NjJzK05DZ0Z6dXVtRXFVNm5aeUU5QjhTWlZQbzNzZmFJ?= =?utf-8?B?OTZXdGExWG1EaTJXbDRQK0VvbTVwK3hDOExzVEVKQlN6eThZZzI2a3BJRG1s?= =?utf-8?B?VjVrYnVxcENLSU5WMnlCSjduMXM4SFIwOFkrcmNYenNNMkxnMC8wV2pSNFlC?= =?utf-8?B?Mk1VTDVDaEVjbjFnVTVPdTBteTlJWUJjMGtJTFBHdVVMZmNObjNyczBrZHlX?= =?utf-8?B?M0JxYjROSDQ3QlZCQTRkNDVQbjErbWlUKzFRaXBnY3REY2t3QzdleW5PL1NC?= =?utf-8?B?SFh1MEo3aU0vQ0o5WHU3RCtsOUVGQWFNMldoMUFRc2E2THE2SGlVSnB0K3pm?= =?utf-8?B?bVp0R250WVNXR29NaWsyOEFoOGRmcG8zQ1BQSFF1a09Oa0NoY2Y0ZUI4VXpn?= =?utf-8?B?OXVrZ3R2QVo0QlB1eFRJU3FNckVvaFdDUDFyWjBuR1hHMmVvRzRiMW9TZk1F?= =?utf-8?B?WHd6cHpzOVZjMHpzOU9BYTVoWVVEZS8yYnAvb3BEcWtyUG5HS0NiSiszNCsy?= =?utf-8?B?bll5dWUrc2l1Vld2MFlWbEgyQ1pOR1pCc0xoWHpaNlIwL1VuS3RycWZhRWRE?= =?utf-8?B?QnExSjJHSXpEQW1Td2lPRUtndWRKR3M4TFR6d0M1ckUzUko4cHI1czJVSkNJ?= =?utf-8?B?Mm1hOHptZk1lNHpqbHA5dmpNVXFBZmFCMnR5Tjc3WGRFRlROK2IxYTVZSXg0?= =?utf-8?B?YUxyWUJicUFsY2piWUpsMlh3RDVFRm1CdXFuaFpnRTVCQkZ5N3V2a1VwaGNt?= =?utf-8?B?cEhGTXVJWkR2Q3gxS3lUTnpXTGFYbHZsQ2tJc0kxTktBQTUveUVoWVRoU3lr?= =?utf-8?B?NGJvLytnUU5kYUJOWnVEQUMxQ2hybjUxS2tUT293eFZkNlJ6NHJSeGcwQzFT?= =?utf-8?B?VC93a0FZeGhvanZlVDMxOWI3WXdKdW9FbnRmOGVtNGZJMFhqVS9hQkdPWGNV?= =?utf-8?B?WUczM1Y0Qk5DSC96N2h3WGdtRjNMZjFvRTBXNjRBWTRGZnIwcElYd0RITTNj?= =?utf-8?B?Q1RRbHJrOCtWQzdmeTFRajMwK3NjN3dtd0FrTkhzM2NOY1N0d0NwRGRFWEMx?= =?utf-8?B?R0ZsdUFaUUt1amRveTI0bDZyem5TTVBTclA5ZVh6UDlJWUxNRFJadzRSMXpt?= =?utf-8?B?SThsR3hiRlF2c0NiRDE3WHdISEFVSVE3THFrdktJdHNmcGM3ZUdNZnp1VEtJ?= =?utf-8?B?M0syMWZGbkpnK0g4Rms4ajV2U0lvcXduUkIvclN0MHh4NkpLYTFRYUFJNFBp?= =?utf-8?B?ZnZSRS9pSk1GRjRYZUJEbWhBTkZxcTYzaE96T0xieTc3ODBHTytVY2JsZVMr?= =?utf-8?B?MVRqMEVvcldPMnduV3Q5cGc2a3NvMDRTSklORmlRNHJUTzdMckloSmRERXlN?= =?utf-8?B?dmRWT0NaSFlYaWQ1MjZmN3BDREZFNHdNQ2srNnc1VDNHaXNjMUJtdHR3ZlZh?= =?utf-8?B?WjVDOFY1dy81eG1MTk9ZUmIyM0hkNTh5bHdBeW1zc0Q2b2QrUWwrOEhLSEEw?= =?utf-8?B?MWVSWnNMa3UxMFpJNHovenBKQWxLVHhoSFp5RlQ2bm96a1lkL0VLYlgyTGQy?= =?utf-8?B?dDg1TTRHWUpmWkR3bDlUSmR3SXc4S0p0OWlwakZVZC9FR2xhNFIxWEgyclgw?= =?utf-8?B?YkhMMFg3c2xuY0RLdHZ3ZGJjblVmK3NWTEthd243TWIzYXJIMGlVT1FyTnln?= =?utf-8?B?ZzdHdEFac1Q3NXZBc2RxY0t4TEJQdUJHWU40d3RPY25BM1l4blZUNnp6ZThs?= =?utf-8?B?WWpCM1RWdTV2dkFCZXFPU0xLSmhwOVcybzVnQTQ3RDl4UGk3TXF0aGtYenRr?= =?utf-8?B?aXlvMVIrMjlWTFloUFQ2dFB3dHlabGhuTW1zMnhtRkNEZ1A5R3NZMDlvMUJ3?= =?utf-8?B?WFc2bVpDbTVETDNWMW41LzE0RGJnRlVaN1lXbWxIbURUakNDUjY5TGJSQ2t1?= =?utf-8?B?NFRGK3NSREt2TThKeW5McE9PcTFvT2xIYXdxUmVhMG40cWw4bmIxL1ZhTGQy?= =?utf-8?B?RXRhQVZEdlI5UWxKZ2NOY01peW0rbmZ6bkdHTVpSM0pCUVcvWHRsN2srNUpr?= =?utf-8?B?bDk0SHJ1UCthSUd2TEVqdkZqQTBRZ2Y2SG1nNzF6NmpiTVVIcjQxdXh4dWkx?= =?utf-8?B?YTZwbmlqdytXOHhvVmxZckZIRFFUMnBBQXNTWTdwTnNtTTBkQ2s5aHM0Smsx?= =?utf-8?B?YUE9PQ==?= X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 1e41f9a4-e4bb-4337-e5ef-08dab007760c X-MS-Exchange-CrossTenant-AuthSource: DU0PR10MB5266.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2022 06:18:52.0506 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pko0YFCpvikiIi5LF2pydLYc+8n2XkQIuUHGaLqzxQP9XNAXvq3ncHB/Y7wZV5G3lN87bncBOCQLXCfvPIsmGyCI6SOqAtssmPeA+OMk1gk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3974 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 16/10/2022 20.28, Ramon Fried wrote: > On Fri, Oct 14, 2022 at 8:44 PM Rasmus Villemoes > wrote: >> >> Nothing inside this block depends on NET_TFTP_VARS to be set to parse >> correctly. Switch to C if() in preparation for adding code before >> this (to avoid a declaration-after-statement warning). > What's the motivation here ? The #ifdef is supposed to allow smaller > code size if feature is not used. And as always with these types of conversions, nothing changes in that regard - an "if (0)" is optimized out by the compiler just fine. The motivation is in the commit message: The following patch will need to add a bit of logic at the very beginning of the function, so if I left the #ifdef block as-is, the declaration of the ep variable would lead to a declaration-after-statement warning; lifting the declaration to the top would either require repeating the ugly ifdeffery, or give a "variable not used" warning. It's also in general the preferred method, because it means the contained code gets checked for syntactic correctness regardless of .config - but that very same thing is also why it cannot be applied universally, if the contained code e.g. refers to struct fields that are only defined with certain CONFIG_FOO set [and this also was alluded to in the commit message]. Rasmus