From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEC56CD690B for ; Tue, 10 Oct 2023 08:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229922AbjJJIjy (ORCPT ); Tue, 10 Oct 2023 04:39:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346726AbjJJIjI (ORCPT ); Tue, 10 Oct 2023 04:39:08 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE77BBA for ; Tue, 10 Oct 2023 01:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696927141; x=1728463141; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=RrB1fvKP5gYhnbKJqKzbc4Ly5flwHHMl+loeJRAjNec=; b=lYr1KPMvhwaolejCrPIygjk3BRYi45yaJEntqGHDTNNlRDjTTTKUkQyQ iDhUb6Nm79BGnW3QZt34WGEEKvbCXfUT+hfsot5TDgY03R1O6pSRk5eEL TIIRmOJRse+FqLlytO7PYRe5JGWKLb9DJRA8Wx1KYbZxDKdD7R88TH19F bgVe1aUMBmvx8wJpzPNdm4BMoLDhc4NtpOYIe1YlorihwYNsfD/u9L2cO jIG5WWNI61hkK+KQPuwWsAeYZbxQXxK9fcGiW1cOtfiBjlE3hksc1WQ3D n3uXqEYneZbRqw7iduxdw9r2h9XF0rvfONZ3zD/JRQ6xju3dMHWZfKG7B g==; X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="374686245" X-IronPort-AV: E=Sophos;i="6.03,212,1694761200"; d="scan'208";a="374686245" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2023 01:39:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10858"; a="877145853" X-IronPort-AV: E=Sophos;i="6.03,212,1694761200"; d="scan'208";a="877145853" Received: from ipu5-build.bj.intel.com (HELO [10.238.232.146]) ([10.238.232.146]) by orsmga004.jf.intel.com with ESMTP; 10 Oct 2023 01:38:57 -0700 Subject: Re: [PATCH 00/15] Intel IPU6 and IPU6 input system drivers To: Hans de Goede , Laurent Pinchart Cc: "Cao, Bingbu" , Claus Stovgaard , "linux-media@vger.kernel.org" , "sakari.ailus@linux.intel.com" , "ilpo.jarvinen@linux.intel.com" , "tfiga@chromium.org" , "senozhatsky@chromium.org" , "andriy.shevchenko@linux.intel.com" , "tomi.valkeinen@ideasonboard.com" , "Qiu, Tian Shu" , "Wang, Hongju" References: <769ebe9f8eb88b2c07eae5910fc7d79c1ff888cb.camel@gmail.com> <5fb07c7d-390c-d7ae-c74b-8e03c75f636c@linux.intel.com> <0a381077-c07a-ed40-c53e-5e36177bd5f2@linux.intel.com> <907f992d4e333f090418f39ebd59bf8ac1fb5e3f.camel@gmail.com> <1d03c5f9-1813-40f0-f280-520e2da38e09@hansg.org> <1d46186b-24a6-3ae9-ccc1-0ada0f068313@redhat.com> <253b5ba6-d44d-4ee1-8c18-44159632d023@redhat.com> <20231002173841.GD10113@pendragon.ideasonboard.com> <2cd7e607-88f0-d173-3423-5ef3f760bd19@redhat.com> <0693c525-f260-2885-239f-41d26247c1fa@linux.intel.com> <9868d2d7-880a-990d-8c61-7a87c989a45b@linux.intel.com> <9158d5f9-a70b-2e11-25ee-351699983d02@redhat.com> From: Bingbu Cao Message-ID: <5c88bd7b-4241-9253-f88c-85726564b00c@linux.intel.com> Date: Tue, 10 Oct 2023 16:35:55 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <9158d5f9-a70b-2e11-25ee-351699983d02@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hans, On 10/10/23 4:10 PM, Hans de Goede wrote: > Hi, > > On 10/10/23 04:54, Bingbu Cao wrote: >> Hans, >> >> On 10/9/23 8:53 PM, Hans de Goede wrote: >>> Hi Bingbu, >>> >>> On 10/9/23 14:25, Bingbu Cao wrote: >>>> >>>> Hans and Laurent, >>>> >>>> On 10/3/23 1:41 AM, Hans de Goede wrote: >>>>> Hi, >>>>> >>>>> On 10/2/23 19:38, Laurent Pinchart wrote: >>>>>> On Mon, Oct 02, 2023 at 07:19:13PM +0200, Hans de Goede wrote: >>>>>>> Hi, >>>>>>> >>>>>>> On 9/4/23 05:13, Cao, Bingbu wrote: >>>>>>>> Hans, >>>>>>>> >>>>>>>> Thanks for your test and report. >>>>>>>> >>>>>>>> I have made some changes locally which will support the latest >>>>>>>> v4l2-async APIs, I will also add the fix for this issue and merge >>>>>>>> them in v3. >>>>>>> >>>>>>> I have been trying to make rawbayer capture with the mainline isys code >>>>>>> work in libcamera and I have hit several short comings in the ipu6-isys >>>>>>> code. I have attached 3 patches to fix various issues please integrate >>>>>>> these into the next version of this series. >>>>>> >>>>>> They look good to me. >>>>> >>>>> Actually I just realized I forgot to commit + squash in a bug fix: >>>>> >>>>>>> Talking about the next version of this series, I think it would be >>>>>>> good to post a new version soon ? >>>>>>> >>>>>> >>>>>>> From 14f42fd3071a7aba8b83b98802ca3b413794296d Mon Sep 17 00:00:00 2001 >>>>>>> From: Hans de Goede >>>>>>> Date: Mon, 2 Oct 2023 16:37:11 +0200 >>>>>>> Subject: [PATCH 1/3] media: intel/ipu6: Add mbus code filtering to isys >>>>>>> /dev/video enum_fmt >>>>>>> >>>>>>> Add mbus code filtering to ipu6_isys_vidioc_enum_fmt(). >>>>>>> >>>>>>> Signed-off-by: Hans de Goede >>>>>>> --- >>>>>>> .../media/pci/intel/ipu6/ipu6-isys-video.c | 29 +++++++++++++++---- >>>>>>> 1 file changed, 23 insertions(+), 6 deletions(-) >>>>>>> >>>>>>> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c >>>>>>> index dc1605491352..20fd03f6f204 100644 >>>>>>> --- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c >>>>>>> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c >>>>>>> @@ -130,14 +130,31 @@ int ipu6_isys_vidioc_querycap(struct file *file, void *fh, >>>>>>> int ipu6_isys_vidioc_enum_fmt(struct file *file, void *fh, >>>>>>> struct v4l2_fmtdesc *f) >>>>>>> { >>>>>>> - if (f->index >= ARRAY_SIZE(ipu6_isys_pfmts)) >>>>>>> - return -EINVAL; >>>>>>> + unsigned int i, found = 0; >>>>>>> >>>>>>> - f->flags = 0; >>>>>>> - f->pixelformat = ipu6_isys_pfmts[f->index].pixelformat; >>>>>>> - f->mbus_code = ipu6_isys_pfmts[f->index].code; >>>>>>> + if (!f->mbus_code) { >>>>>>> + if (f->index >= ARRAY_SIZE(ipu6_isys_pfmts)) >>>>>>> + return -EINVAL; >>>>>>> >>>>>>> - return 0; >>>>>>> + f->flags = 0; >>>>>>> + f->pixelformat = ipu6_isys_pfmts[f->index].pixelformat; >>>>>>> + f->mbus_code = ipu6_isys_pfmts[f->index].code; >>>>> >>>>> There is a: >>>>> return 0; >>>>> >>>>> missing here. >>>>> >>>>>>> + } >>>>>>> + >>>>> >>>>> Regards, >>>>> >>>>> Hans >>>>> >>>>> >>>>> >>>>>>> + for (i = 0; i < ARRAY_SIZE(ipu6_isys_pfmts); i++) { >>>>>>> + if (f->mbus_code != ipu6_isys_pfmts[i].code) >>>>>>> + continue; >>>>>>> + >>>>>>> + if (f->index == found) { >>>>>>> + f->flags = 0; >>>>>>> + f->pixelformat = ipu6_isys_pfmts[i].pixelformat; >>>>>>> + return 0; >>>>>>> + } >>>>>>> + >>>>>>> + found++; >>>>>>> + } >>>> >>>> A little confused here - >>>> >>>> If the `mbus_code` argument here is not zero, does the user expect that >>>> the first try (f->index == 0) should be found and return? `found` is >>>> always 0 here? >>> >>> Notice how formats where: >>> >>> if (f->mbus_code != ipu6_isys_pfmts[i].code) >>> >>> Is true are skipped: >>> >>> if (f->mbus_code != ipu6_isys_pfmts[i].code) >>> continue; >>> >>> The idea is that for (f->index == 0) the first format >>> matching the passed in mbus_code is returned and then >>> for (f->index == 1) the second format matching the passed >>> in mbus_code is returned, etc. >> >> Ack. So for 1:1 match case, is (f->index == 0) expected for all formats? > > If there is only 1 format which matches the mbus-code then yes > that fmt will only be returned for (f->index == 0). > > But as mentioned already for raw bayer there are typically > 2 formats matching the same mbus-code: > >>> In practice this means that e.g. for a mbus_code for >>> a 10bit raw bayer format both the padded (one 10 bits >>> pixel in each 16bit integer) and packed formats are >>> returned. >>> >>> >>>> My understanding is - user will try to enum again if return -EINVAL. >>> >>> No, -EINVAL means that the end of the list of >>> formats has been reached, so the user keeps >>> calling this function with higher >>> f->index values until -EINVAL is returned. >> >> So for libcamera, it's trying to enumerate all the pixel formats, >> Is it trying to enumerate from index 0 for each `mbus_code` or continue next >> format enumeration from higher index? > > libcamera sets up the media-controller graph, so it already > knowns the mbus_code between the v4l2subdevs. AFAIK after setting > up the graph it uses mbus_code filtering to only get output formats > for /dev/video# which actually match with the configured mbus-code. Ack, thanks. > > Regards, > > Hans > > > -- Best regards, Bingbu Cao