From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Thu, 19 Jul 2018 11:45:24 +0000 Subject: Re: [PATCH v3 0/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Message-Id: <5c8d334c-ca34-e446-2447-89421ae8f842@redhat.com> List-Id: References: <20180719101601.25076-1-tzimmermann@suse.de> In-Reply-To: <20180719101601.25076-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Zimmermann , rostedt@goodmis.org, pmladek@suse.com, linux-fbdev@vger.kernel.org, sergey.senozhatsky@gmail.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com Hi, On 19-07-18 12:15, Thomas Zimmermann wrote: > Hi, > > this is version 3 of the WARN_CONSOLE_UNLOCKED patch set. The > macro prints a warning if the console's critical sections are > entered without holding the console lock. This patch set allows > to disable the warnings while debugging the console. > > In the original approach, WARN_CONSOLE_UNLOCKED was disabled by > setting ignore_console_lock_warning of type bool. As suggested by > Petr Mladek, the new implementation is based on atomic_t and allows > multiple threads to manipulate the warning state concurrently. > > With version 3, the patch set now includes the patch for introducing > ignore_console_lock_warning. This patch superseds all previous patches > of the same purpose. > > Best regards > Thomas > > v3: > - implement ignore_console_lock_warning with atomic_t > v2: > - restore ignore_console_lock_warning if lock_fb_info() fails > > Thomas Zimmermann (2): > console: Replace #if 0 with atomic var 'ignore_console_lock_warning' > fbdev/core: Disable console-lock warnings when fb.lockless_register_fb > is set I just saw this version after my comment on v2 that the race there was not really a problem. This version is even better though :) : Acked-by: Hans de Goede Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v3 0/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Date: Thu, 19 Jul 2018 13:45:24 +0200 Message-ID: <5c8d334c-ca34-e446-2447-89421ae8f842@redhat.com> References: <20180719101601.25076-1-tzimmermann@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2667D6EDC0 for ; Thu, 19 Jul 2018 11:45:27 +0000 (UTC) Received: by mail-ed1-f67.google.com with SMTP id s24-v6so6857726edr.8 for ; Thu, 19 Jul 2018 04:45:27 -0700 (PDT) In-Reply-To: <20180719101601.25076-1-tzimmermann@suse.de> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Zimmermann , rostedt@goodmis.org, pmladek@suse.com, linux-fbdev@vger.kernel.org, sergey.senozhatsky@gmail.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiAxOS0wNy0xOCAxMjoxNSwgVGhvbWFzIFppbW1lcm1hbm4gd3JvdGU6Cj4gSGksCj4g Cj4gdGhpcyBpcyB2ZXJzaW9uIDMgb2YgdGhlIFdBUk5fQ09OU09MRV9VTkxPQ0tFRCBwYXRjaCBz ZXQuIFRoZQo+IG1hY3JvIHByaW50cyBhIHdhcm5pbmcgaWYgdGhlIGNvbnNvbGUncyBjcml0aWNh bCBzZWN0aW9ucyBhcmUKPiBlbnRlcmVkIHdpdGhvdXQgaG9sZGluZyB0aGUgY29uc29sZSBsb2Nr LiBUaGlzIHBhdGNoIHNldCBhbGxvd3MKPiB0byBkaXNhYmxlIHRoZSB3YXJuaW5ncyB3aGlsZSBk ZWJ1Z2dpbmcgdGhlIGNvbnNvbGUuCj4gCj4gSW4gdGhlIG9yaWdpbmFsIGFwcHJvYWNoLCBXQVJO X0NPTlNPTEVfVU5MT0NLRUQgd2FzIGRpc2FibGVkIGJ5Cj4gc2V0dGluZyBpZ25vcmVfY29uc29s ZV9sb2NrX3dhcm5pbmcgb2YgdHlwZSBib29sLiBBcyBzdWdnZXN0ZWQgYnkKPiBQZXRyIE1sYWRl aywgdGhlIG5ldyBpbXBsZW1lbnRhdGlvbiBpcyBiYXNlZCBvbiBhdG9taWNfdCBhbmQgYWxsb3dz Cj4gbXVsdGlwbGUgdGhyZWFkcyB0byBtYW5pcHVsYXRlIHRoZSB3YXJuaW5nIHN0YXRlIGNvbmN1 cnJlbnRseS4KPiAKPiBXaXRoIHZlcnNpb24gMywgdGhlIHBhdGNoIHNldCBub3cgaW5jbHVkZXMg dGhlIHBhdGNoIGZvciBpbnRyb2R1Y2luZwo+IGlnbm9yZV9jb25zb2xlX2xvY2tfd2FybmluZy4g VGhpcyBwYXRjaCBzdXBlcnNlZHMgYWxsIHByZXZpb3VzIHBhdGNoZXMKPiBvZiB0aGUgc2FtZSBw dXJwb3NlLgo+IAo+IEJlc3QgcmVnYXJkcwo+IFRob21hcwo+IAo+IHYzOgo+IAktIGltcGxlbWVu dCBpZ25vcmVfY29uc29sZV9sb2NrX3dhcm5pbmcgd2l0aCBhdG9taWNfdAo+IHYyOgo+IAktIHJl c3RvcmUgaWdub3JlX2NvbnNvbGVfbG9ja193YXJuaW5nIGlmIGxvY2tfZmJfaW5mbygpIGZhaWxz Cj4gCj4gVGhvbWFzIFppbW1lcm1hbm4gKDIpOgo+ICAgIGNvbnNvbGU6IFJlcGxhY2UgI2lmIDAg d2l0aCBhdG9taWMgdmFyICdpZ25vcmVfY29uc29sZV9sb2NrX3dhcm5pbmcnCj4gICAgZmJkZXYv Y29yZTogRGlzYWJsZSBjb25zb2xlLWxvY2sgd2FybmluZ3Mgd2hlbiBmYi5sb2NrbGVzc19yZWdp c3Rlcl9mYgo+ICAgICAgaXMgc2V0CgpJIGp1c3Qgc2F3IHRoaXMgdmVyc2lvbiBhZnRlciBteSBj b21tZW50IG9uIHYyIHRoYXQgdGhlIHJhY2UgdGhlcmUKd2FzIG5vdCByZWFsbHkgYSBwcm9ibGVt LgoKVGhpcyB2ZXJzaW9uIGlzIGV2ZW4gYmV0dGVyIHRob3VnaCA6KSAgICA6CgpBY2tlZC1ieTog SGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KClJlZ2FyZHMsCgpIYW5zCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=