From: Dan Carpenter <dan.carpenter@linaro.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Harshit Mogalapalli <harshit.m.mogalapalli@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] rtlwifi: rtl8188ee: remove an accidental '-' character
Date: Wed, 5 Nov 2025 17:54:20 +0300 [thread overview]
Message-ID: <5c992936-4e7b-4c0a-abfc-0ec0fb9ef9fd@suswa.mountain> (raw)
In-Reply-To: <8d6962531a9545fd8279fbc7cd04340c@realtek.com>
On Mon, Nov 03, 2025 at 01:17:07AM +0000, Ping-Ke Shih wrote:
> Dan Carpenter <dan.carpenter@linaro.org> wrote:
> > Sent: Friday, October 31, 2025 9:04 PM
> > The "->allstasleep" variable is a 1 bit bitfield. It can only be
> > 0 or 1. This "= -1" assignement was supposed to be "= 1". This
> > doesn't change how the code works, it's just a cleanup.
>
> Yes, this patch doesn't change logic at all. However, it looks like existing
> code is wrong, since other places in the same pattern in this driver set to 0.
> More, I check vendor driver which also sets this value to 0.
>
Ah. Good. Thanks.
Could you send that patch and give me a Reported-by tag?
regards,
dan carpenter
next prev parent reply other threads:[~2025-11-05 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 13:04 [PATCH] rtlwifi: rtl8188ee: remove an accidental '-' character Dan Carpenter
2025-11-03 1:17 ` Ping-Ke Shih
2025-11-05 14:54 ` Dan Carpenter [this message]
2025-11-06 0:47 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c992936-4e7b-4c0a-abfc-0ec0fb9ef9fd@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=harshit.m.mogalapalli@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.