From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:ad09:0:0:0:0:0 with SMTP id t9csp2736908lfc; Sat, 5 Sep 2020 20:59:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTM0jRZm2JJCvWloC/NcmrkThw41JjCAPvUQz38lNG74nonP2l3EDmNr4htMp7/N6BDyAp X-Received: by 2002:a25:ab2f:: with SMTP id u44mr19651260ybi.318.1599364745542; Sat, 05 Sep 2020 20:59:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599364745; cv=none; d=google.com; s=arc-20160816; b=NwAgJPVj5jHqukFnwLC1yE6gaiYB3LX5xtPGTUYGmJSfutPEmz18jIIghkCthhvfzb jyM9NQIwRKUwD6sXq/qCiOkXHMcbRWXAxxhleMoIW7KuqMfq8faeZMxi/DAM63jud3gV OoIi0NE4RJuIswzf+XGFvtHovbRnb3iGspfCBjGFzQIZ8/+Emm/2nSdgQQ9jtnxGGhQc TKaeXjewTkO0ow3RNpyBYJEvx8jSa9wY0FMU2IH3q1tDj+D8YKZa+tA7NeNeW2w9C2f/ rA5tKxZ+L7wgG58P7zWp0Gf94I2Se3RDFFYgCVffB5GM//EXbsSeui703lIbiOih1gYz IIhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=m2bYMEGomk8hFaxqfnpouoTbsg/xQOjjaCJvBHSA7k0=; b=xEW5DUtpb4ml9dFgUNKskLSMpZH/7sM22FJM48hAt4/GJY8ZzD0FeIfGsfIxIchwdh yMCj5vr9wXhun89+MJcUtSvxeODQYBFuQgZloz0TnPUus1nqX+A/QdI/NUJ/dUKQW9h8 k8IBmRbhzamOgNX6vEmOAIRAmM2o0SnjEFjUCGpOSpLOXk16tTbkOMad75lNLrVj3wsl iKOeWEXaZVdn5hVQhUGk2AcCpkyKBOueaDNHSOZ4yUeWhsDxV5qcPVEtvBIor9q2Utbf dBjGVtoL2RAMGXiGRmi8GbDu4G5SDmV2lWSTBchroAYe61F0jGqpboWckIHoQ105Ke42 tIkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Zk3iZdvB; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n81si11794265ybb.351.2020.09.05.20.59.05 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Sep 2020 20:59:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=Zk3iZdvB; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:55568 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kElpY-0006z0-U1 for alex.bennee@linaro.org; Sat, 05 Sep 2020 23:59:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kElpQ-0006w2-CE for qemu-arm@nongnu.org; Sat, 05 Sep 2020 23:58:56 -0400 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]:45653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kElpN-0004wh-OT for qemu-arm@nongnu.org; Sat, 05 Sep 2020 23:58:56 -0400 Received: by mail-pg1-x542.google.com with SMTP id 67so6356274pgd.12 for ; Sat, 05 Sep 2020 20:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=m2bYMEGomk8hFaxqfnpouoTbsg/xQOjjaCJvBHSA7k0=; b=Zk3iZdvBP/jhMTZhyOl8NROR0TjohTsPb7ZUme9041tL1oZbCi9N+9KpL3EjSe61yn z7/ZQZEDySrZjWQ0/MC0GJ16vrAUWJufpJmRbd4SRNNX7/mKi5rbqVuzmTGofz9azexA K0v4Xv6HjA8OVNlB57hvqsYHA1Dikbo4W3vNIiByVPrmvcymPU9jEoF1gzh1HvYWaK3H nnlaOBnFK5zdkx3Hn1SQcfv0j1CdfDFfyLaoqEWmutx+GDl55GR6nH2EiAzv80ZJnSO2 uyQzepBPviTWK/ZPEnnT6QpGhHcyDEcOxbqw+2jwZkeqLuVgWE2YdTeW5EY4r2auNC2s QGcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=m2bYMEGomk8hFaxqfnpouoTbsg/xQOjjaCJvBHSA7k0=; b=VxC4ZLlHhWFK2ur54AhkNpfOTTCv3UlEF32QTfYpOFQrfwM4xpUJKpEtpdEJXIfoI8 M7tgNcIXajur8Legw8iR7INmMNwTmzNChqEAyE/f1MBcpcgGfrv427YU1WZBgik1o9gz TusChZNjPKBd8dH697ePZ4C0dSr2vBNZlc1HS63rG9gSPD17fxZZiTqjLrO+WvgnN8fQ Zhz9HM9JAUUHepMKKTGLtKkQ5sl/xvlnc6fq8jUhFPPeF4rWxKotitxLKoMAU2MoJKou 3TTvkTiEVRr9cPueRsjEHjQqv7YZLUD5bgMI94WrDrilR7YuzW9TDDlEOO4HKjUfponD A16Q== X-Gm-Message-State: AOAM531yIL5vs6yd0AANXQ8mYpIn3/oQbgeQSD9LikoVIbuD1LCoNuu5 nAN9ehGwlpXmBdPomtfES3TPOA== X-Received: by 2002:a63:6d0d:: with SMTP id i13mr12798785pgc.372.1599364732557; Sat, 05 Sep 2020 20:58:52 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id g192sm3490029pfb.168.2020.09.05.20.58.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Sep 2020 20:58:51 -0700 (PDT) Subject: Re: [PATCH 07/13] dma: Let dma_memory_write() propagate MemTxResult To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Paolo Bonzini References: <20200904154439.643272-1-philmd@redhat.com> <20200904154439.643272-8-philmd@redhat.com> From: Richard Henderson Message-ID: <5ccd69c0-79b0-d6ec-9dcb-a0df245fa9d9@linaro.org> Date: Sat, 5 Sep 2020 20:58:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200904154439.643272-8-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::542; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x542.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.107, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , Peter Xu , Gerd Hoffmann , qemu-block@nongnu.org, Joel Stanley , Richard Henderson , Laszlo Ersek , Eduardo Habkost , Alistair Francis , Beniamino Galvani , Eric Auger , qemu-arm@nongnu.org, Jan Kiszka , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , John Snow , David Gibson , Andrew Jeffery , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Andrew Baumann , qemu-ppc@nongnu.org, Peter Chubb Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: wGW2Hb7sT3Wb On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > dma_memory_rw_relaxed() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/dma.h | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886BCC433E2 for ; Sun, 6 Sep 2020 03:59:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2220420708 for ; Sun, 6 Sep 2020 03:59:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zk3iZdvB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2220420708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kElq1-0007xf-8i for qemu-devel@archiver.kernel.org; Sat, 05 Sep 2020 23:59:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kElpP-0006um-8M for qemu-devel@nongnu.org; Sat, 05 Sep 2020 23:58:55 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:42173) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kElpN-0004wi-Ob for qemu-devel@nongnu.org; Sat, 05 Sep 2020 23:58:54 -0400 Received: by mail-pf1-x442.google.com with SMTP id 17so6788608pfw.9 for ; Sat, 05 Sep 2020 20:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=m2bYMEGomk8hFaxqfnpouoTbsg/xQOjjaCJvBHSA7k0=; b=Zk3iZdvBP/jhMTZhyOl8NROR0TjohTsPb7ZUme9041tL1oZbCi9N+9KpL3EjSe61yn z7/ZQZEDySrZjWQ0/MC0GJ16vrAUWJufpJmRbd4SRNNX7/mKi5rbqVuzmTGofz9azexA K0v4Xv6HjA8OVNlB57hvqsYHA1Dikbo4W3vNIiByVPrmvcymPU9jEoF1gzh1HvYWaK3H nnlaOBnFK5zdkx3Hn1SQcfv0j1CdfDFfyLaoqEWmutx+GDl55GR6nH2EiAzv80ZJnSO2 uyQzepBPviTWK/ZPEnnT6QpGhHcyDEcOxbqw+2jwZkeqLuVgWE2YdTeW5EY4r2auNC2s QGcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=m2bYMEGomk8hFaxqfnpouoTbsg/xQOjjaCJvBHSA7k0=; b=GM/T79CMksac8JlYVMqtS/Zjo88h3ikqZ14zEp1zUF5DpBnWc5Dk3HtTD6BF7Oc890 /kZUc46SMcf1ziap5Ll2UrlCpEVHklPqKLYZQsfj/rh4mA5M70RFWEGT5f/0h0dEBMKH BHWKkhX8tsZx6jnC4kulc5C0yL2OGaQVZP/Jn7mVaKTYLVXKzjZFa84JTksYwB/C3pln L4U+9LGK0IiMH5zaJU2+R6LO3iaj2xmg+lhd3RXvtJ0FOMJhMg8Li8vwS5/7MHuKlDL2 zhfeuV3pCaKZCrx0ATpFLqxwRboPRbhjP5KqSiX+ihtMkFSMQ+3XexMK3eykMDELFrVH XzAQ== X-Gm-Message-State: AOAM530mFTbA9j7CZ8CsWeBbfjsAHyfHHOylNq41oDGheNaE6SrcjU3U w9E/z6sX7aiIr38dNFbR509ghg== X-Google-Smtp-Source: ABdhPJw8TsyWgf/eJXu58/vIHNUv4OF87SrEJxupqB9QKv6vScQFeqaato3gTno0BaJlEh3rKbKSZQ== X-Received: by 2002:a63:6d0d:: with SMTP id i13mr12798785pgc.372.1599364732557; Sat, 05 Sep 2020 20:58:52 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id g192sm3490029pfb.168.2020.09.05.20.58.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 05 Sep 2020 20:58:51 -0700 (PDT) Subject: Re: [PATCH 07/13] dma: Let dma_memory_write() propagate MemTxResult To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Paolo Bonzini References: <20200904154439.643272-1-philmd@redhat.com> <20200904154439.643272-8-philmd@redhat.com> From: Richard Henderson Message-ID: <5ccd69c0-79b0-d6ec-9dcb-a0df245fa9d9@linaro.org> Date: Sat, 5 Sep 2020 20:58:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200904154439.643272-8-philmd@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::442; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x442.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.107, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Mark Cave-Ayland , Peter Xu , Gerd Hoffmann , "Edgar E. Iglesias" , qemu-block@nongnu.org, Joel Stanley , Richard Henderson , Laszlo Ersek , Eduardo Habkost , Alistair Francis , Beniamino Galvani , Eric Auger , qemu-arm@nongnu.org, Jan Kiszka , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , John Snow , David Gibson , Andrew Jeffery , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Andrew Baumann , qemu-ppc@nongnu.org, Peter Chubb Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/4/20 8:44 AM, Philippe Mathieu-Daudé wrote: > dma_memory_rw_relaxed() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/sysemu/dma.h | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson r~