From: Stephen Boyd <swboyd@chromium.org>
To: Fabiano Rosas <farosas@linux.ibm.com>, linux-kernel@vger.kernel.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Kieran Bingham <kbingham@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Leonard Crestez <leonard.crestez@nxp.com>,
Jackie Liu <liuyun01@kylinos.cn>
Subject: Re: [PATCH] scripts/gdb: Fix invocation when CONFIG_COMMON_CLK is not set
Date: Thu, 23 May 2019 15:46:03 -0700 [thread overview]
Message-ID: <5ce722ac.1c69fb81.b62d2.16d0@mx.google.com> (raw)
In-Reply-To: <20190523195313.24701-1-farosas@linux.ibm.com>
Quoting Fabiano Rosas (2019-05-23 12:53:11)
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index 1d73083da6cb..2efbec6b6b8d 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -40,7 +40,8 @@
> import gdb
>
> /* linux/clk-provider.h */
> -LX_GDBPARSED(CLK_GET_RATE_NOCACHE)
> +if IS_BUILTIN(CONFIG_COMMON_CLK):
> + LX_GDBPARSED(CLK_GET_RATE_NOCACHE)
>
Why is this LX_GDBPARSED() instead of LX_VALUE()? From what I can tell
it doesn't need to be runtime evaluated, just assigned to something that
is macro expanded by CPP.
We should probably change the clk-provider.h header to export more
things than what it's exporting right now when COMMON_CLK is disabled.
I'm not sure why the whole thing is wrapped in a big ifdef.
Either way
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2019-05-23 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 19:53 [PATCH] scripts/gdb: Fix invocation when CONFIG_COMMON_CLK is not set Fabiano Rosas
2019-05-23 22:46 ` Stephen Boyd [this message]
2019-05-23 23:09 ` Leonard Crestez
2019-05-24 0:11 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ce722ac.1c69fb81.b62d2.16d0@mx.google.com \
--to=swboyd@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=farosas@linux.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=kbingham@kernel.org \
--cc=leonard.crestez@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.