From: quic_zijuhu <quic_zijuhu@quicinc.com>
To: Johan Hovold <johan@kernel.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
Zhengping Jiang <jiangzp@google.com>,
<linux-bluetooth@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] Bluetooth: qca: fix NULL-deref on non-serdev setup
Date: Mon, 22 Apr 2024 23:19:11 +0800 [thread overview]
Message-ID: <5ce83568-e185-4247-aa72-bc86d727446f@quicinc.com> (raw)
In-Reply-To: <ZiZ8GzBXd9Re8EjZ@hovoldconsulting.com>
On 4/22/2024 11:02 PM, Johan Hovold wrote:
> On Mon, Apr 22, 2024 at 09:53:48PM +0800, quic_zijuhu wrote:
>> On 4/22/2024 9:43 PM, Johan Hovold wrote:
>>> On Mon, Apr 22, 2024 at 09:30:28PM +0800, quic_zijuhu wrote:
>>>> On 4/22/2024 9:20 PM, Johan Hovold wrote:
>
>>>> NAK for your [PATCH 1/2] since the null checking is redundant with your
>>>> [PATCH 2/2].
>>>
>>> I explained in the cover letter why it is split up like this. If you
>>> don't bother reading, then we will not bother listening to you.
>>>
>>>> NAK for your [PATCH 2/2], since it is same with my earlier fix
>>>> https://lore.kernel.org/all/1704960978-5437-1-git-send-email-quic_zijuhu@quicinc.com/
>>>> my new patchset for btattach tool still has this change.
>>>
>>> The fix does not depend on your btattach series, which has also been
>>> rejected.
>>>
>> these my v1 and v2 for this issue which are earlier then yours.
>> they are not rejected but not responded.
>>
>> https://lore.kernel.org/all/bf74d533-c0ff-42c6-966f-b4b28c5e0f60@molgen.mpg.de/
>> https://lore.kernel.org/all/1704970181-30092-1-git-send-email-quic_zijuhu@quicinc.com/
>
> Here is your *v3* as part of the rejected btattach series:
>
> https://lore.kernel.org/all/1713409913-13042-2-git-send-email-quic_zijuhu@quicinc.com/
>
no, v3 is a separate patch here and not was rejected.
https://lore.kernel.org/all/1710912504-25416-1-git-send-email-quic_zijuhu@quicinc.com/
and it was sent after your patch.
then i included the fix into a patch serials for tool btattach shown by
below link
https://lore.kernel.org/all/1713358336-29619-2-git-send-email-quic_zijuhu@quicinc.com/
you reviewed my the serials and also did not rejected the fix.
and it also doesn't get any negative comments.
> Apparently you had earlier also sent it separately, I see now in lore.
> It's all a big mess.
>
>>> You clearly have some learning to do on how to interact with the kernel
>>> community and to write proper commit messages and patches. If you start
>>> listening to feedback and try not to piss everyone off perhaps you can
>>> even get your patches merged one day. [1][2]
>
> Johan
next prev parent reply other threads:[~2024-04-22 15:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 15:46 [PATCH 0/2] Bluetooth: qca: fix NULL-deref on non-serdev setup Johan Hovold
2024-03-19 15:46 ` [PATCH 1/2] Bluetooth: qca: fix NULL-deref on non-serdev suspend Johan Hovold
2024-03-19 16:35 ` Bluetooth: qca: fix NULL-deref on non-serdev setup bluez.test.bot
2024-03-19 15:46 ` [PATCH 2/2] " Johan Hovold
2024-04-22 12:51 ` [PATCH 0/2] " Johan Hovold
2024-04-22 13:04 ` quic_zijuhu
2024-04-22 13:20 ` Johan Hovold
2024-04-22 13:30 ` quic_zijuhu
2024-04-22 13:43 ` Johan Hovold
2024-04-22 13:53 ` quic_zijuhu
2024-04-22 14:15 ` Luiz Augusto von Dentz
2024-04-22 14:22 ` quic_zijuhu
2024-04-22 15:02 ` Johan Hovold
2024-04-22 15:19 ` quic_zijuhu [this message]
2024-04-22 13:44 ` Luiz Augusto von Dentz
2024-04-22 13:51 ` Johan Hovold
2024-04-22 13:52 ` Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ce83568-e185-4247-aa72-bc86d727446f@quicinc.com \
--to=quic_zijuhu@quicinc.com \
--cc=jiangzp@google.com \
--cc=johan@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.