From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1E4BE94104 for ; Fri, 6 Oct 2023 19:49:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3716210E561; Fri, 6 Oct 2023 19:49:41 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A0B410E561; Fri, 6 Oct 2023 19:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696621779; x=1728157779; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yiDAlPrhtpCnpd2t7sdBP955q+zYb36AoPl06/5VppQ=; b=Wl/z+yXCfh9m3WgsUiQ3YWHAohkwrIfqlDcbvWk/s9u6tJhMjNY5cVug q53851uRwkRFKOeu4Qxi/qjigspInblF00oH9JunTZHCRVHqaiOp4njls tXeTJ5WnE3KmYIuBlQZdRxbTk0t09KdsaY2n6iPY7aRoQbM0jPuXzTlH1 K0hVzCYKOsgjQUNHWlnOLOnHF+O+sQmWekzdo79ruD9W0DZ6lYFZfbaOR fPlxoxsAfdujFokZd5GteHH6j0I1ynu2fHJ7klyOjZgPBIfU/382+lqs0 MzlYaTObl6jbUK/hASB2pGLeP8YVlTxXuxpgF3yGgNKoL0ACi4onDtSU/ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10855"; a="382686848" X-IronPort-AV: E=Sophos;i="6.03,204,1694761200"; d="scan'208";a="382686848" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2023 12:49:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10855"; a="702151829" X-IronPort-AV: E=Sophos;i="6.03,204,1694761200"; d="scan'208";a="702151829" Received: from ahajda-mobl.ger.corp.intel.com (HELO [10.213.31.15]) ([10.213.31.15]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2023 12:49:36 -0700 Message-ID: <5cebbf0f-54f2-4e08-bc48-2f9e5347b750@intel.com> Date: Fri, 6 Oct 2023 21:49:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org References: <20231006083103.660153-1-tvrtko.ursulin@linux.intel.com> <20231006083103.660153-2-tvrtko.ursulin@linux.intel.com> From: Andrzej Hajda Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 In-Reply-To: <20231006083103.660153-2-tvrtko.ursulin@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Remove early/pre-production Haswell code X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , Matt Roper , Rodrigo Vivi , Lucas De Marchi , Tvrtko Ursulin Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 06.10.2023 10:31, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It is not our policy to keep pre-production hardware support for this long > so I guess this one was just forgotten. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Andrzej Hajda Regards Andrzej > --- > drivers/gpu/drm/i915/i915_driver.c | 1 - > drivers/gpu/drm/i915/i915_drv.h | 2 -- > 2 files changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c > index ccbb2834cde0..78a42c8a8509 100644 > --- a/drivers/gpu/drm/i915/i915_driver.c > +++ b/drivers/gpu/drm/i915/i915_driver.c > @@ -175,7 +175,6 @@ static void intel_detect_preproduction_hw(struct drm_i915_private *dev_priv) > { > bool pre = false; > > - pre |= IS_HASWELL_EARLY_SDV(dev_priv); > pre |= IS_SKYLAKE(dev_priv) && INTEL_REVID(dev_priv) < 0x6; > pre |= IS_BROXTON(dev_priv) && INTEL_REVID(dev_priv) < 0xA; > pre |= IS_KABYLAKE(dev_priv) && INTEL_REVID(dev_priv) < 0x1; > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index cb60fc9cf873..9d493ff1685a 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -590,8 +590,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915, > IS_SUBPLATFORM(i915, INTEL_ALDERLAKE_P, INTEL_SUBPLATFORM_RPL) > #define IS_RAPTORLAKE_U(i915) \ > IS_SUBPLATFORM(i915, INTEL_ALDERLAKE_P, INTEL_SUBPLATFORM_RPLU) > -#define IS_HASWELL_EARLY_SDV(i915) (IS_HASWELL(i915) && \ > - (INTEL_DEVID(i915) & 0xFF00) == 0x0C00) > #define IS_BROADWELL_ULT(i915) \ > IS_SUBPLATFORM(i915, INTEL_BROADWELL, INTEL_SUBPLATFORM_ULT) > #define IS_BROADWELL_ULX(i915) \