From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A11F308F0A for ; Fri, 15 May 2026 02:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778812209; cv=none; b=ith0gPR4S6eBd8bpSg59ZooDDP5cT+bcdhqmCHax6a3RDASz41bP92H4OixZOvTKpjK+ULqDWdVFNqBDsYm6BQLQFg0AhygsRER5ZVUxxY/huDQ1EKCPzZ9b35GJyID3bl7gyrCo9nzeDvamNzvVJirMaR/ybyHwAupAtglHGf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778812209; c=relaxed/simple; bh=6E3uQ5IU5bqGMKWEysYtGMYJL7+gGJ5E600OUI9cBbk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bGJWksbFaWV+XmJ/4F4Ftfr/DGMGGi8/urSh7TXdiVlMqT6lgIjW0x49MH2qp8pKSJdP7lqmGAPdZTN1BQdzgwNvh1dwgDnMvLhE3OJIujt3yaK1PxHezz5nfbIqR89fBDrqScTH1w1gYWsoTUHZRwiRHo+15X9ixmLJbB+2y7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D1q/oIgW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XiOicDqu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D1q/oIgW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XiOicDqu" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64EIpMnC3670819 for ; Fri, 15 May 2026 02:30:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rrr4c6ZRkiE76n5t5mFlOMtG559/xFzAWj0L7OxzRTc=; b=D1q/oIgW5blnd2+r W4kHlLSYTjCweKYIHSqm6lDqJBeETo0rqj9HXvp3En3ovgASv8YzGXZ+sN4bZUV9 vVz9ceSw3eNuI3F2TlvhTM5KHYLfYPQ4bssaxcg/3M/g53+nuHfUWhAT5Okn4Vlg FzonblfjtTmKeuAd+dSrGwl4VoQjTIXQxSpHvrQJlmOYw/R6LIeKSSzlaGlJNG5h 0oDF9SFCojkBbmSFI51UhNyDM0Ha+tBg6BulxRR/PvAlsrGaQdu3Qd314IqHXHSw WVohzoKhkLGXJBq+kaRs11JeFV6L1oLPR0hDG4iXG1KRXOLRvu1U+gjTUHzq4QTb Xy2IBg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1s172c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 02:30:05 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ba3245a43dso79661305ad.0 for ; Thu, 14 May 2026 19:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778812205; x=1779417005; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rrr4c6ZRkiE76n5t5mFlOMtG559/xFzAWj0L7OxzRTc=; b=XiOicDquwhNDo3KlfaDf9AeubXWWBjr8QpoWTz482vlw17NjsEKMvm/rhWqNCTXOxZ pQJn8HB3N0jbUsbQ5jqYMK7KQwjyp3ve1+LA+T5BNFaf03d7uEqaJvgR8F2gii1AY7w5 Oy9pHwFuymNaEVdY41fsKi0vkvU7Mfkl7d7cAxuNA/tQ6HTI6CmG/G5jE4QXdv4pQ2nX 1oP5ldbQXbLANajA0eLYtAbKjDfKHM6oo2P5DTg1T1tigmz4iSuie3s+cn16a9Y3SfXc zY5kQWwUkoKAJm9yT+IYrYoMpiCQdRhgQpW0WneF8XznMMePbcdlreZHm5+wGOCK0V8x FkAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778812205; x=1779417005; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rrr4c6ZRkiE76n5t5mFlOMtG559/xFzAWj0L7OxzRTc=; b=F7Z1bMzROmOwfPIVjxM7WEvnxYM7zOtYqgnRbuoUKpSgLbMfGvKPj3ns2SMThYwLYr TkhJ42h+wH/U0Ieoaq1owBfRDfVyqnhveKaLlSSptZsrIzKMDtQCz1CIIYNgVGdAQfxz K7SxMyEQf/IPfm4T2AlqNBR331uS713Qij3x3RyJwhcwNR/caxbWqh41E8TnayIhubHn 17GSKxe9NlD2QYGIIxNYYeG7b6epE0q8t3LbMZM2B3Vrb4H0XyF8ohYjcp5ZPVCMLTUZ wOyY9VBDK5Nk9yhA2tWlH5s/CEBl6HUF9vZOf4V7QmtuQoahL9hlH+n2dKITK2A1H73v SvHQ== X-Forwarded-Encrypted: i=1; AFNElJ8bOWiGC04LYc2Ejai/StOOqtZbosAnFPWKdL32xbvQgFgJh/7UxEREkPwksrG+PFetzocGCeR1bvwPZlB+TA==@vger.kernel.org X-Gm-Message-State: AOJu0YyNXz3T3osMKnfA8mo4K0sV0w0ZDEZglhV9U4ZuSrYjfsoV6jBB DdvIEh1VZIgCnq1vFXr2DsIx5KEFrq6rX52KZICCvHOqhuj24YhFCZQeSVji4c+kGhn+1ydhNOO k2z8nv4NIPYwzp564jTD1n9st54Ku5FGktDVKz36IHDIFpSwYhEFSjLNREBHuYx2jyIxqdsCRlT dGrQ== X-Gm-Gg: Acq92OGDnoPn0WPg4l9AzJ0FX0rQmm9EDoeFsrMRn1qAjHQLyUh1Pno8PIItrWbp158 gLpQGV/yHhX3+VyLHoMtPKOmB0Ty2eKHDPCBbNN7BuABmxayJRlLHClgQqhULdy36/TWe0zmkg+ /zmefVFpw6tLC28sHZZcbsSXN9Qr3o7/9Zf++Y1jlMwyA91T4xjYUf72bDX+9Yiivs88ts3C2dd 6u0NxrGYDRkuLhcJkSUBlfW4wVTWPm3ua/D89qKwtHsE4yf+VvPCXJOgX8wPnnF+LLeZn6/K588 syWVrn4gDrb4MCfYXdxVgu04IA4S3H3NQk4RK72xB6IqqsqoGkHtDxm35uLaRL6UwH3ktm1pnyP q28MEzyXBoPIAtBnq3EZ4ZzBLewyD/NboYbYS1pIGk+sjQYu03FtEZw8HO6PLnW4dbLqZ X-Received: by 2002:a17:90b:57ee:b0:368:147b:536a with SMTP id 98e67ed59e1d1-36951b97c8cmr1913548a91.14.1778812204324; Thu, 14 May 2026 19:30:04 -0700 (PDT) X-Received: by 2002:a17:90b:57ee:b0:368:147b:536a with SMTP id 98e67ed59e1d1-36951b97c8cmr1913510a91.14.1778812203805; Thu, 14 May 2026 19:30:03 -0700 (PDT) Received: from [192.168.58.30] ([152.57.206.198]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d11cbdesm41328565ad.71.2026.05.14.19.29.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 May 2026 19:30:03 -0700 (PDT) Message-ID: <5cf71052-9797-4dd9-a168-1c4ac73dddb4@oss.qualcomm.com> Date: Fri, 15 May 2026 07:59:56 +0530 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath11k: clear shared SRNG pointer state on restart To: kfarnung@gmail.com, Jeff Johnson , Muhammad Usama Anjum , Baochen Qiang Cc: Jeff Johnson , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org, santiagorr@riseup.net, stable@vger.kernel.org References: <20260513-kfarnung-ath11k-srng-clear-pointer-state-v1-1-bc700dd8b333@gmail.com> Content-Language: en-US From: Rameshkumar Sundaram In-Reply-To: <20260513-kfarnung-ath11k-srng-clear-pointer-state-v1-1-bc700dd8b333@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDAyMiBTYWx0ZWRfXz4l8IjBDnGlF W48sW6kSwDLZn6MLGmE+gUXeGSc6oX98Wwo4TbmbpxkTXdELg5/qSdcszb3E8WIzlCYQD29YDj1 lWnUear8iKFRglzC0CwqKdGRaAqJ5/R9ArQp7AEJT98FFISw0V2hdz8Ig8+m39qg94o1OVNNa9i cCJ4S118CYqNgzABKONTwEnfH1nnXd3w7Dbp+ThVUqfdAOA9GOEPkMMaRUjIuKk87VUFfCLgFXh XcNxJ9PTSLbaDse2eN8Vxf92G4DtN5JBGMSnWpJYulvsjGq9mG1V0lM1wI8o+gajyrdmQwaO0uG wZAqkpwEWPx72Iv9hYcOd79z/X65AgLKCmUhmHaN5sKOqhCOhFx7tRqrnl5ctj3RqjcCmMOGTDK t7VaCL2kml3iX7YOiiNw0KIKqUsXttB6l08r7qoq1gnpmKQab80Z9GOenKQ92Sl0L26Xh2IYNh1 +miaw0hAs95F/Fw7GPQ== X-Authority-Analysis: v=2.4 cv=Md5cfZ/f c=1 sm=1 tr=0 ts=6a06852d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=YxPPAu78v9FaI4eag4rAcQ==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=xNf9USuDAAAA:8 a=EUspDBNiAAAA:8 a=yURyTq39TCQ5d30jD7MA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=3w6iy9BqfFbDrj__1GvT:22 X-Proofpoint-GUID: omXQjQ9wlgns5E52U-AcZaAm91Mj268T X-Proofpoint-ORIG-GUID: omXQjQ9wlgns5E52U-AcZaAm91Mj268T X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-14_06,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150022 On 5/14/2026 10:22 AM, Kyle Farnung via B4 Relay wrote: > From: Kyle Farnung > > LMAC rings reuse the shared rdp/wrp pointer buffers without going > through the normal SRNG hw-init path that zeros non-LMAC ring > pointers. After restart, ath11k_hal_srng_clear() can therefore hand > stale hp/tp state from the previous firmware instance back to the new > one. > > Clear the shared pointer buffers while keeping the allocations in > place so restart still avoids reallocating SRNG DMA memory, but starts > with fresh ring-pointer state. > > Fixes: 32be3ca4cf78b ("wifi: ath11k: HAL SRNG: don't deinitialize and re-initialize again") > Cc: stable@vger.kernel.org > Link: https://lore.kernel.org/all/CAOPSVF04q6uvVdq8GTRLHBrVMdpt9=o9wVcFMc6f-yhmSBcZqQ@mail.gmail.com/ > Signed-off-by: Kyle Farnung > --- > This patch is the result of investigating suspend/resume failures on a > Lenovo ThinkPad P14s Gen 5 AMD with ath11k. > > I originally proposed extending the existing ath11k PM quirk for this > platform, but after discussion in [1] and bisection the issue appears to > be a regression introduced by [2]. There is also a parallel report in [3] > that appears consistent with the same root cause. This patch keeps the > intended no-reallocation behavior from that change, but clears the > preserved shared SRNG pointer state so restart begins from a clean state. > > Testing so far has been limited to local suspend/resume cycling on the > affected system. The issue was originally reproduced on v7.0.4, and the > patch was also built and tested on top of ath-current with repeated > suspend/resume cycles on a Lenovo ThinkPad P14s Gen 5 AMD. > > [1] https://lore.kernel.org/all/CAOPSVF04q6uvVdq8GTRLHBrVMdpt9=o9wVcFMc6f-yhmSBcZqQ@mail.gmail.com/ > [2] 32be3ca4cf78b ("wifi: ath11k: HAL SRNG: don't deinitialize and re-initialize again") > [3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1132343 > --- > drivers/net/wireless/ath/ath11k/hal.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/hal.c b/drivers/net/wireless/ath/ath11k/hal.c > index e821e5a62c1c0..0c0aeb803018e 100644 > --- a/drivers/net/wireless/ath/ath11k/hal.c > +++ b/drivers/net/wireless/ath/ath11k/hal.c > @@ -1387,14 +1387,21 @@ EXPORT_SYMBOL(ath11k_hal_srng_deinit); > > void ath11k_hal_srng_clear(struct ath11k_base *ab) > { > - /* No need to memset rdp and wrp memory since each individual > - * segment would get cleared in ath11k_hal_srng_src_hw_init() > - * and ath11k_hal_srng_dst_hw_init(). > + /* Preserve the shared pointer buffers, but clear the previous > + * firmware instance's hp/tp state before handing them back to FW. > + * LMAC rings reuse this shared memory without going through the > + * normal SRNG hw-init path that zeros non-LMAC ring pointers. > */ > memset(ab->hal.srng_list, 0, > sizeof(ab->hal.srng_list)); > memset(ab->hal.shadow_reg_addr, 0, > sizeof(ab->hal.shadow_reg_addr)); > + if (ab->hal.rdp.vaddr) > + memset(ab->hal.rdp.vaddr, 0, > + sizeof(*ab->hal.rdp.vaddr) * HAL_SRNG_RING_ID_MAX); > + if (ab->hal.wrp.vaddr) > + memset(ab->hal.wrp.vaddr, 0, > + sizeof(*ab->hal.wrp.vaddr) * HAL_SRNG_NUM_LMAC_RINGS); > ab->hal.avail_blk_resource = 0; > ab->hal.current_blk_index = 0; > ab->hal.num_shadow_reg_configured = 0; > > --- > base-commit: 54a5b38e4396530e5b2f12b54d3844e860ab6784 > change-id: 20260513-kfarnung-ath11k-srng-clear-pointer-state-91d8ab07e5e2 > Reviewed-by: Rameshkumar Sundaram