From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH next v2] of/fdt: Fix defined but not used compiler warning Date: Mon, 17 Jun 2019 08:10:08 -0700 Message-ID: <5d07ad51.1c69fb81.25c8.f3a0@mx.google.com> References: <20190612010011.90185-1-wangkefeng.wang@huawei.com> <20190615030343.96524-1-wangkefeng.wang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190615030343.96524-1-wangkefeng.wang@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Kefeng Wang , Rob Herring , Frank Rowand , Arnd Bergmann List-Id: devicetree@vger.kernel.org Quoting Kefeng Wang (2019-06-14 20:03:43) > When CONFIG_OF_EARLY_FLATTREE is disabled, there is a compiler > warning, >=20 > drivers/of/fdt.c:129:19: warning: =E2=80=98of_fdt_match=E2=80=99 defined = but not used [-Wunused-function] > static int __init of_fdt_match(const void *blob, unsigned long node, >=20 > Since the only caller of of_fdt_match() is of_flat_dt_match(), > let's move the body of of_fdt_match() into of_flat_dt_match() > and eliminate of_fdt_match(). >=20 > Meanwhile, move of_fdt_is_compatible() under CONFIG_OF_EARLY_FLATTREE, > as all callers are over there. >=20 > Cc: Stephen Boyd > Cc: Rob Herring > Cc: Frank Rowand > Signed-off-by: Kefeng Wang > --- Reviewed-by: Stephen Boyd Arnd sent something similar now too. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3165C31E5B for ; Mon, 17 Jun 2019 15:10:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 774F1208CB for ; Mon, 17 Jun 2019 15:10:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Ky0OhGyF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728414AbfFQPKM (ORCPT ); Mon, 17 Jun 2019 11:10:12 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:35673 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbfFQPKL (ORCPT ); Mon, 17 Jun 2019 11:10:11 -0400 Received: by mail-pl1-f193.google.com with SMTP id p1so4215059plo.2 for ; Mon, 17 Jun 2019 08:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:to:from:subject:cc:user-agent:date; bh=RrNEZkQt5HKoUfzRadgZa2XIFWt7gGNYEFg83I4dzHg=; b=Ky0OhGyFU/8wdxd/wWoxfATOJXQA4oQm20lG4MLzYkk08eKB19NfpVHAK06+y3k/P9 Xu9XX3nfykiU6HkQdwBM9bz9QJ/ekFK15dya0gpRCL+FVayr8jsgCikYQc2Wo4KZnXqY AF2EyiM8qv+WBCaoyXS93RlzrCj3eY+O/R4Vg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:to:from:subject:cc :user-agent:date; bh=RrNEZkQt5HKoUfzRadgZa2XIFWt7gGNYEFg83I4dzHg=; b=Hz9BK9tYpsrQNUHCSlL5apvyZh6YKxv1h0ZosrRNZ4DFYKxOzcEwFhHajeFNBJXg+V nXHicV0NKtJgT3C0ZkmINKs0wA1aAXtk/PnlZDV5G9y7kZDSTErl7cBK0fXf6rj21AQr sYwIrnc5IT6Ivqm7sk0nf2VhIB/BNzJpPrxqGznja4OTZB2Zu7BccGHmlJ89xCs9LuIZ bBbGoQXr49dSfKwp/s3mM0ruW7lqm0R/yDJBf3NqzDmQrTvG/sH+xDcp4Cq19epawWTl vRy0BsxsQah/CJhsDYwV3vF/H8upIbZ0wOvnBNv2hsirObIOULbFc69JwZc35Cqv/zss LA1Q== X-Gm-Message-State: APjAAAX+rMLJIPdy0pjd8T8Q2x0c62366lEA/QK651TptotuqjHF5w/0 1/QQ1ZN+OQ3eYbmtZfvqOQgL3A== X-Google-Smtp-Source: APXvYqylFmQKmBTKyHsSy1Ps5/Nh3sNrn1DbSH0wex7/W/BGfi9v5C7IT0RxX6UfE1Njsz5KtJUlkg== X-Received: by 2002:a17:902:760a:: with SMTP id k10mr88282143pll.83.1560784210920; Mon, 17 Jun 2019 08:10:10 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id g5sm10125082pjt.14.2019.06.17.08.10.09 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 17 Jun 2019 08:10:09 -0700 (PDT) Message-ID: <5d07ad51.1c69fb81.25c8.f3a0@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190615030343.96524-1-wangkefeng.wang@huawei.com> References: <20190612010011.90185-1-wangkefeng.wang@huawei.com> <20190615030343.96524-1-wangkefeng.wang@huawei.com> To: Kefeng Wang , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Stephen Boyd Subject: Re: [PATCH next v2] of/fdt: Fix defined but not used compiler warning Cc: Kefeng Wang , Rob Herring , Frank Rowand , Arnd Bergmann User-Agent: alot/0.8.1 Date: Mon, 17 Jun 2019 08:10:08 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Kefeng Wang (2019-06-14 20:03:43) > When CONFIG_OF_EARLY_FLATTREE is disabled, there is a compiler > warning, >=20 > drivers/of/fdt.c:129:19: warning: =E2=80=98of_fdt_match=E2=80=99 defined = but not used [-Wunused-function] > static int __init of_fdt_match(const void *blob, unsigned long node, >=20 > Since the only caller of of_fdt_match() is of_flat_dt_match(), > let's move the body of of_fdt_match() into of_flat_dt_match() > and eliminate of_fdt_match(). >=20 > Meanwhile, move of_fdt_is_compatible() under CONFIG_OF_EARLY_FLATTREE, > as all callers are over there. >=20 > Cc: Stephen Boyd > Cc: Rob Herring > Cc: Frank Rowand > Signed-off-by: Kefeng Wang > --- Reviewed-by: Stephen Boyd Arnd sent something similar now too.