next/master boot bisection: next-20190617 on sun8i-h2-plus-orangepi-zero

["kernelci.org bot" <bot@kernelci.org>]

* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* This automated bisection report was sent to you on the basis  *
* that you may be involved with the breaking commit it has      *
* found.  No manual investigation has been done to verify it,   *
* and the root cause of the problem may be somewhere else.      *
* Hope this helps!                                              *
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

next/master boot bisection: next-20190617 on sun8i-h2-plus-orangepi-zero

Summary:
  Start:      a125097c8410 Add linux-next specific files for 20190617
  Details:    https://kernelci.org/boot/id/5d07987659b51412add51503
  Plain log:  https://storage.kernelci.org//next/master/next-20190617/arm/multi_v7_defconfig/gcc-8/lab-baylibre/boot-sun8i-h2-plus-orangepi-zero.txt
  HTML log:   https://storage.kernelci.org//next/master/next-20190617/arm/multi_v7_defconfig/gcc-8/lab-baylibre/boot-sun8i-h2-plus-orangepi-zero.html
  Result:     ce4ab73ab0c2 net: stmmac: drop the reset delays from struct stmmac_mdio_bus_data

Checks:
  revert:     PASS
  verify:     PASS

Parameters:
  Tree:       next
  URL:        git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
  Branch:     master
  Target:     sun8i-h2-plus-orangepi-zero
  CPU arch:   arm
  Lab:        lab-baylibre
  Compiler:   gcc-8
  Config:     multi_v7_defconfig
  Test suite: boot

Breaking commit found:

-------------------------------------------------------------------------------
commit ce4ab73ab0c27c6a3853695aa8ec0f453c6329cd
Author: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sat Jun 15 12:09:31 2019 +0200

    net: stmmac: drop the reset delays from struct stmmac_mdio_bus_data
    
    Only OF platforms use the reset delays and these delays are only read in
    stmmac_mdio_reset(). Move them from struct stmmac_mdio_bus_data to a
    stack variable inside stmmac_mdio_reset() because that's the only usage
    of these delays.
    
    Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
index 459ef8afe4fb..c9454cf4f189 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
@@ -252,6 +252,7 @@ int stmmac_mdio_reset(struct mii_bus *bus)
 #ifdef CONFIG_OF
 	if (priv->device->of_node) {
 		struct gpio_desc *reset_gpio;
+		u32 delays[3];
 
 		reset_gpio = devm_gpiod_get_optional(priv->device,
 						     "snps,reset",
@@ -261,18 +262,18 @@ int stmmac_mdio_reset(struct mii_bus *bus)
 
 		device_property_read_u32_array(priv->device,
 					       "snps,reset-delays-us",
-					       data->delays, 3);
+					       delays, ARRAY_SIZE(delays));
 
-		if (data->delays[0])
-			msleep(DIV_ROUND_UP(data->delays[0], 1000));
+		if (delays[0])
+			msleep(DIV_ROUND_UP(delays[0], 1000));
 
 		gpiod_set_value_cansleep(reset_gpio, 1);
-		if (data->delays[1])
-			msleep(DIV_ROUND_UP(data->delays[1], 1000));
+		if (delays[1])
+			msleep(DIV_ROUND_UP(delays[1], 1000));
 
 		gpiod_set_value_cansleep(reset_gpio, 0);
-		if (data->delays[2])
-			msleep(DIV_ROUND_UP(data->delays[2], 1000));
+		if (delays[2])
+			msleep(DIV_ROUND_UP(delays[2], 1000));
 	}
 #endif
 
diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h
index a0cc6fa4965b..7c8328edd501 100644
--- a/include/linux/stmmac.h
+++ b/include/linux/stmmac.h
@@ -96,9 +96,6 @@ struct stmmac_mdio_bus_data {
 	unsigned int phy_mask;
 	int *irqs;
 	int probed_phy_irq;
-#ifdef CONFIG_OF
-	u32 delays[3];
-#endif
 };
 
 struct stmmac_dma_cfg {
-------------------------------------------------------------------------------


Git bisection log:

-------------------------------------------------------------------------------
git bisect start
# good: [d4d5d8e83c9616aeef28a2869cea49cc3fb35526] ax25: fix inconsistent lock state in ax25_destroy_timer
git bisect good d4d5d8e83c9616aeef28a2869cea49cc3fb35526
# bad: [a125097c841039deef9dd589b86467f7d20f4b3d] Add linux-next specific files for 20190617
git bisect bad a125097c841039deef9dd589b86467f7d20f4b3d
# bad: [4595fa52d5346117e65bb2aa17f972062c40a18c] Merge remote-tracking branch 'wireless-drivers-next/master'
git bisect bad 4595fa52d5346117e65bb2aa17f972062c40a18c
# good: [87f4a5a7e5b7cc0e92d700339d34cf16eeec9dfb] Merge remote-tracking branch 'pstore/for-next/pstore'
git bisect good 87f4a5a7e5b7cc0e92d700339d34cf16eeec9dfb
# good: [b4a6d9abeb545d79cc76f150f31c3cebc3472287] Merge tag 'mlx5-updates-2019-06-13' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux
git bisect good b4a6d9abeb545d79cc76f150f31c3cebc3472287
# good: [19f18e90aa597906157a8f31c2cfd1eba0892764] Merge remote-tracking branch 'v4l-dvb/master'
git bisect good 19f18e90aa597906157a8f31c2cfd1eba0892764
# bad: [0d744c8931dc83b786c5489d559b9b8ddcc1e6ef] Merge remote-tracking branch 'net-next/master'
git bisect bad 0d744c8931dc83b786c5489d559b9b8ddcc1e6ef
# good: [40d22bdeabaccfce39ad43e7113bf9c6de6b462f] Merge remote-tracking branch 'swiotlb/linux-next'
git bisect good 40d22bdeabaccfce39ad43e7113bf9c6de6b462f
# good: [a52c8e2469c30cf7ac453d624aed9c168b23d1af] RDMA: Clean destroy CQ in drivers do not return errors
git bisect good a52c8e2469c30cf7ac453d624aed9c168b23d1af
# good: [422efd032775757c41e9579facd9656a87bf4f00] net: dsa: mv88e6xxx: do not flood CPU with unknown multicast
git bisect good 422efd032775757c41e9579facd9656a87bf4f00
# good: [42a90766fe1ff438b2af26a94bb8395c405f684b] net: stmmac: use device_property_read_u32_array to read the reset delays
git bisect good 42a90766fe1ff438b2af26a94bb8395c405f684b
# bad: [1718132587e8c73c9a6fd7cfbf0fa9f14559c134] tc-tests: updated skbedit tests
git bisect bad 1718132587e8c73c9a6fd7cfbf0fa9f14559c134
# bad: [fead5b1b5838ba2f231d76e1b8ed31a4e9449382] net: stmmac: drop the phy_reset hook from struct stmmac_mdio_bus_data
git bisect bad fead5b1b5838ba2f231d76e1b8ed31a4e9449382
# bad: [ce4ab73ab0c27c6a3853695aa8ec0f453c6329cd] net: stmmac: drop the reset delays from struct stmmac_mdio_bus_data
git bisect bad ce4ab73ab0c27c6a3853695aa8ec0f453c6329cd
# good: [7e770b252a62e7498cfa9411018100fd86e56d47] net: stmmac: drop the reset GPIO from struct stmmac_mdio_bus_data
git bisect good 7e770b252a62e7498cfa9411018100fd86e56d47
# first bad commit: [ce4ab73ab0c27c6a3853695aa8ec0f453c6329cd] net: stmmac: drop the reset delays from struct stmmac_mdio_bus_data
-------------------------------------------------------------------------------

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel