From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC508C48BD3 for ; Wed, 26 Jun 2019 21:32:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A301C216FD for ; Wed, 26 Jun 2019 21:32:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="HGVs1bcl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726373AbfFZVcm (ORCPT ); Wed, 26 Jun 2019 17:32:42 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:43819 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726223AbfFZVcm (ORCPT ); Wed, 26 Jun 2019 17:32:42 -0400 Received: by mail-pg1-f193.google.com with SMTP id f25so1807360pgv.10 for ; Wed, 26 Jun 2019 14:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:subject:to:cc:from:user-agent:date; bh=xaNe52gTlH7uRzDXkViS1kydi/Gmc6DAN/0reN+QD/8=; b=HGVs1bclAbOEXXG+00ww1YiAcgPJaUDs8c6KhzZs0qSXho81TRV1hIRDYI4p3P+oS5 wxJihsS1sEj2TMViHikFUkrsrQGyTia8SAyrkZaPBkVceiLL4rujCxA/m5LRUoCr2ZpX bS1Ukkj1FBQTy+QAHrTZIcv/ZmCGwUEuolewg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:subject:to:cc:from :user-agent:date; bh=xaNe52gTlH7uRzDXkViS1kydi/Gmc6DAN/0reN+QD/8=; b=civ+oqs4Tz/n+uDH++FS7nfHbQ0WF3zST1hzVgQOWdaGQv/RJu0sgxtvlYSi4lrpLp pTjlQi03XWv4itYt9t0J8cZ9j4bdpzrc/ypJfS2K+M1kjCt7/LQmpBL80qJLzwJGsIjx VJGPgDCuXseWzciE219YBs1rPGAAIj7USvsqFzxb4fUXeaao0S8dnYivpyByk89uclHk /iWrEFCW71ZXGRk4W7/BBukGMRMhmMZogdBiQTGjzq08D0xQ9RNXDrBige9ECG241Ty1 gsbjyBIpABKnU0QQfcp6ob+BUpyOtMGLEbiAWvNZtcYb9+FccvOJL2nCyGyuHpeNIlJh wdMw== X-Gm-Message-State: APjAAAUHkG2lxlZJcYluds1JeDEWYvHsgQTuPbFuPK/LNoH0DUmCsiu+ /tJm9HC/eptGGFwLT2ihSQCJjw== X-Google-Smtp-Source: APXvYqx1s5f135al8fvcz9ybaaaQrPCh6UykGfmm1OcWMXuY9lKQcBeG5D68heUPHZLR1mClZF5ETQ== X-Received: by 2002:a17:90a:24e4:: with SMTP id i91mr1546271pje.9.1561584761690; Wed, 26 Jun 2019 14:32:41 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id x3sm5124124pja.4.2019.06.26.14.32.41 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 26 Jun 2019 14:32:41 -0700 (PDT) Message-ID: <5d13e479.1c69fb81.dd08b.b1e4@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1561550047-19600-1-git-send-email-amasule@codeaurora.org> References: <1561550047-19600-1-git-send-email-amasule@codeaurora.org> Subject: Re: [PATCH] arm64: dts: sdm845: Add video nodes To: Aniket Masule , andy.gross@linaro.org, david.brown@linaro.org, mark.rutland@arm.com, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mgottam@codeaurora.org, vgarodia@codeaurora.org, Aniket Masule From: Stephen Boyd User-Agent: alot/0.8.1 Date: Wed, 26 Jun 2019 14:32:40 -0700 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Aniket Masule (2019-06-26 04:54:07) > This adds video nodes to sdm845 based on the examples > in the bindings. >=20 > Signed-off-by: Malathi Gottam There should be a From: line with this person's name in the email if they're the author. Otherwise this sign-off chain doesn't make sense and it should most likely have a Co-developed-by tag instead. > Signed-off-by: Aniket Masule > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/q= com/sdm845.dtsi > index fcb9330..ff94cfa 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -2437,6 +2437,36 @@ > ; > iommus =3D <&apps_smmu 0x0040 0x1>; > }; > + > + video-codec@aa00000 { This needs to be sorted by address. It doesn't come after 18800000 (the address of the node above). > + compatible =3D "qcom,sdm845-venus"; > + reg =3D <0x0aa00000 0xff000>; > + interrupts =3D ; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] arm64: dts: sdm845: Add video nodes Date: Wed, 26 Jun 2019 14:32:40 -0700 Message-ID: <5d13e479.1c69fb81.dd08b.b1e4@mx.google.com> References: <1561550047-19600-1-git-send-email-amasule@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1561550047-19600-1-git-send-email-amasule@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: andy.gross@linaro.org, david.brown@linaro.org, mark.rutland@arm.com, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mgottam@codeaurora.org, vgarodia@codeaurora.org, Aniket Masule List-Id: devicetree@vger.kernel.org Quoting Aniket Masule (2019-06-26 04:54:07) > This adds video nodes to sdm845 based on the examples > in the bindings. >=20 > Signed-off-by: Malathi Gottam There should be a From: line with this person's name in the email if they're the author. Otherwise this sign-off chain doesn't make sense and it should most likely have a Co-developed-by tag instead. > Signed-off-by: Aniket Masule > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/q= com/sdm845.dtsi > index fcb9330..ff94cfa 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -2437,6 +2437,36 @@ > ; > iommus =3D <&apps_smmu 0x0040 0x1>; > }; > + > + video-codec@aa00000 { This needs to be sorted by address. It doesn't come after 18800000 (the address of the node above). > + compatible =3D "qcom,sdm845-venus"; > + reg =3D <0x0aa00000 0xff000>; > + interrupts =3D ;