From: David Lechner <dlechner@baylibre.com>
To: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ad4080: add AD4880 support
Date: Thu, 29 Jan 2026 10:20:27 -0600 [thread overview]
Message-ID: <5d2e85cd-caa2-43a6-a451-3b822bd0ef01@baylibre.com> (raw)
In-Reply-To: <20260129152731.154368-2-antoniu.miclaus@analog.com>
On 1/29/26 9:27 AM, Antoniu Miclaus wrote:
> Add AD4880 dual-channel ADC to the AD4080 bindings. The AD4880 is a
> dual-channel variant with two independent ADC channels, each with its
> own SPI configuration interface.
>
> For AD4880, the binding requires:
> - adi,aux-spi-cs property for secondary channel chip select
> - Two io-backends entries for each channel's data interface
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> .../bindings/iio/adc/adi,ad4080.yaml | 49 ++++++++++++++++++-
> 1 file changed, 48 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> index ccd6a0ac1539..3909e3095507 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> @@ -18,6 +18,9 @@ description: |
> service a wide variety of precision, wide bandwidth data acquisition
> applications.
>
> + The AD4880 is a dual-channel variant with two independent ADC channels,
> + each with its own SPI configuration interface.
> +
> https://www.analog.com/media/en/technical-documentation/data-sheets/ad4080.pdf
Can we get a datasheet link?
>
> $ref: /schemas/spi/spi-peripheral-props.yaml#
> @@ -31,10 +34,18 @@ properties:
> - adi,ad4084
> - adi,ad4086
> - adi,ad4087
> + - adi,ad4880
>
> reg:
> maxItems: 1
>
> + adi,aux-spi-cs:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Chip select for the auxiliary SPI interface used by multi-channel
> + devices like AD4880. Each additional channel beyond the first requires
> + its own SPI configuration interface on a separate chip select.
> +
> spi-max-frequency:
> description: Configuration of the SPI bus.
> maximum: 50000000
> @@ -57,7 +68,8 @@ properties:
> vrefin-supply: true
>
> io-backends:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> adi,lvds-cnv-enable:
> description: Enable the LVDS signal type on the CNV pin. Default is CMOS.
> @@ -78,6 +90,23 @@ required:
> - vdd33-supply
> - vrefin-supply
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: adi,ad4880
> + then:
> + properties:
> + io-backends:
> + minItems: 2
> + required:
> + - adi,aux-spi-cs
> + else:
> + properties:
> + io-backends:
> + maxItems: 1
> +
> additionalProperties: false
>
> examples:
> @@ -98,4 +127,22 @@ examples:
> io-backends = <&iio_backend>;
> };
> };
> + - |
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@0 {
> + compatible = "adi,ad4880";
> + reg = <0>;
> + adi,aux-spi-cs = <1>;
We can already have multiple reg for a multiple CS device.
reg = <0>, <1>;
So we shouldn't need a new adi,aux-spi-cs property for that.
> + spi-max-frequency = <10000000>;
> + vdd33-supply = <&vdd33>;
> + vddldo-supply = <&vddldo>;
> + vrefin-supply = <&vrefin>;
> + clocks = <&cnv>;
> + clock-names = "cnv";
> + io-backends = <&iio_backend_cha>, <&iio_backend_chb>;
> + };
> + };
> ...
next prev parent reply other threads:[~2026-01-29 16:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 15:27 [PATCH 0/2] iio: adc: ad4080: add support for AD4880 dual-channel ADC Antoniu Miclaus
2026-01-29 15:27 ` [PATCH 1/2] dt-bindings: iio: adc: ad4080: add AD4880 support Antoniu Miclaus
2026-01-29 16:20 ` David Lechner [this message]
2026-02-03 15:42 ` Miclaus, Antoniu
2026-02-03 17:11 ` David Lechner
2026-01-29 15:27 ` [PATCH 2/2] iio: adc: ad4080: add support for AD4880 dual-channel ADC Antoniu Miclaus
2026-01-29 15:56 ` Andy Shevchenko
2026-01-29 16:39 ` David Lechner
2026-01-31 18:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d2e85cd-caa2-43a6-a451-3b822bd0ef01@baylibre.com \
--to=dlechner@baylibre.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.