From: Sinan Kaya <okaya@kernel.org>
To: sathyanarayanan.kuppuswamy@linux.intel.com, bhelgaas@google.com,
joro@8bytes.org, dwmw2@infradead.org
Cc: linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, Ashok Raj <ashok.raj@intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH v1 1/2] PCI: ATS: Add function to check ATS page aligned request status.
Date: Thu, 7 Feb 2019 15:38:35 -0500 [thread overview]
Message-ID: <5d55e369-355f-b710-0594-03465aa985da@kernel.org> (raw)
In-Reply-To: <91bfae8b1d4b424219e3ce3c1fc03559c73f1ae7.1549478584.git.sathyanarayanan.kuppuswamy@linux.intel.com>
On 2/7/2019 1:41 PM, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
> + * As per PCI spec, If page aligned request bit is set, it indicates
> + * the untranslated address is always aligned to a 4096 byte boundary.
> + */
> +int pci_ats_page_aligned(struct pci_dev *pdev)
> +{
> + u16 cap;
> +
> + if (!pdev->ats_cap)
> + return 0;
> +
> + pci_read_config_word(pdev, pdev->ats_cap + PCI_ATS_CAP, &cap);
If I remember this right, aligned request is only supported on ATS v1.1
but not supported on v1.0.
Can you please check the spec?
next prev parent reply other threads:[~2019-02-07 20:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 18:41 [PATCH v1 0/2] Add page alignment check in Intel IOMMU sathyanarayanan.kuppuswamy
2019-02-07 18:41 ` [PATCH v1 1/2] PCI: ATS: Add function to check ATS page aligned request status sathyanarayanan.kuppuswamy
2019-02-07 20:07 ` Bjorn Helgaas
2019-02-07 20:39 ` sathyanarayanan kuppuswamy
2019-02-07 20:38 ` Sinan Kaya [this message]
2019-02-07 22:16 ` sathyanarayanan kuppuswamy
2019-02-08 1:58 ` Sinan Kaya
2019-02-09 1:02 ` sathyanarayanan kuppuswamy
2019-02-09 4:49 ` Sinan Kaya
2019-02-11 19:15 ` Raj, Ashok
2019-02-11 19:24 ` sathyanarayanan kuppuswamy
2019-02-11 20:35 ` Sinan Kaya
2019-02-07 18:41 ` [PATCH v1 2/2] iommu/vt-d: Enable ATS only if the device uses page aligned address sathyanarayanan.kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d55e369-355f-b710-0594-03465aa985da@kernel.org \
--to=okaya@kernel.org \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=joro@8bytes.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.