Re: [PATCH] xen: always consider '/' as a division in assembly

[Jan Beulich <jbeulich@suse.com>]

On 10.02.2026 17:09, Roger Pau Monné wrote:
> On Tue, Feb 10, 2026 at 03:57:17PM +0000, Bertrand Marquis wrote:
>> Hi Roger
>>
>>> On 10 Feb 2026, at 16:55, Roger Pau Monné <roger.pau@citrix.com> wrote:
>>>
>>> On Tue, Feb 10, 2026 at 03:44:33PM +0000, Bertrand Marquis wrote:
>>>> Hi Roger,
>>>>
>>>>> On 10 Feb 2026, at 16:11, Roger Pau Monne <roger.pau@citrix.com> wrote:
>>>>>
>>>>> GNU assembler will consider '/' as the start of comment marker on some
>>>>> platforms.  This is incorrect with Xen's usage, which does use '/' in
>>>>> assembly files as a mathematical operator.
>>>>>
>>>>> The behavior of the assembler can be altered by passing the --divide
>>>>> option; unconditionally pass this option when available to force the
>>>>> expected behavior.
>>>>
>>>> This is solving the issue and I can build for arm with what and further
>>>> for x86 on mac os but it fails on check-endbr.sh:
>>>>
>>>> /bin/sh ../tools/check-endbr.sh xen-syms
>>>> stat: illegal option -- c
>>>
>>> Yeah, I know.  I've fixed the stat issue, but there's a further one
>>> about an illegal bit sequence in grep.  I'm looking into that.
>>
>> LC_ALL=C grep is fixing that one on my side
> 
> I haven't tested that one yet, but yes, might be a way to solve.
> Would you like to send the fix for grep?
> 
>> with that and stat -c replaced with wc -c < xx I can fully compile x86 on Mac os.
> 
> Yeah, the problem with using wc is that you have to read the file.  I
> prefer $(($(du <file> |cut -w -f1) << 9)) because that avoids reading
> the actual data to count.

But shifting by hardcoded 9 doesn't look very portable. The size not being
exact may be okay for the purposes here, but wouldn't it then be better to
use (standardized) ls output?

Jan