Re: [PATCH i-g-t] lib/igt_eld: Log module load state when no eld# nodes are found

["Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>]

On 10/28/2026 2:23 PM, Samala, Pranay wrote:
> Hi Chaitanya,
> 
>> -----Original Message-----
>> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
>> Chaitanya Kumar Borah
>> Sent: Thursday, October 15, 2026 4:56 PM
>> To: igt-dev@lists.freedesktop.org
>> Cc: Borah, Chaitanya Kumar <chaitanya.kumar.borah@intel.com>; B, Jeevan
>> <jeevan.b@intel.com>; Sharma, Swati2 <swati2.sharma@intel.com>
>> Subject: [PATCH i-g-t] lib/igt_eld: Log module load state when no eld# nodes
>> are found
>>
>> eld_is_supported() silently fails when ELD procfs node polling times out.
>> Log module load state to identify whether audio drivers are loaded when IGT
>> attempts to read the ELD nodes.
>>
>> Cc: Jeevan B <jeevan.b@intel.com>
>> Cc: Swati Sharma <swati2.sharma@intel.com>
>> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
>> ---
>>   lib/igt_eld.c | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/igt_eld.c b/lib/igt_eld.c index 896ab0e6b..bfb83a213 100644
>> --- a/lib/igt_eld.c
>> +++ b/lib/igt_eld.c
>> @@ -36,6 +36,7 @@
>>   #include "igt_aux.h"
>>   #include "igt_core.h"
>>   #include "igt_eld.h"
>> +#include "igt_kmod.h"
>>
>>   #define ELD_PREFIX "eld#"
>>   #define ELD_DELIM " \t"
>> @@ -301,8 +302,15 @@ static bool eld_has_nodes(void)
>>    * for a bounded amount of time before giving up to avoid spurious skips. */
>> bool eld_is_supported(void)  {
>> -	return igt_wait(eld_has_nodes(), ELD_SUPPORTED_TIMEOUT_MS,
>> -			ELD_SUPPORTED_INTERVAL_MS);
>> +	bool supported = igt_wait(eld_has_nodes(),
>> ELD_SUPPORTED_TIMEOUT_MS,
>> +				   ELD_SUPPORTED_INTERVAL_MS);
>> +
>> +	if (!supported)
>> +		igt_debug("No eld# nodes found; snd_hda_intel loaded: %s,
> 
> Use igt_warn/igt_info to log in CI logs. igt_debug won't log without --debug.
> 

This is not needed in my opinion because a test failure already triggers 
a debug print in our CI.

>> snd_hda_core loaded: %s\n",
>> +			  igt_kmod_is_loaded("snd_hda_intel") ? "yes" : "no",
> 
> As per my understanding, on SOF-based Intel platforms (with DMIC/Soundwire),
> snd_hda_intel still gets loaded but aborts its probe, and SOF driver bound to the
> audio device instead.
> If so, this would print "loaded: yes" even though it's not driving the hardware.
> 
> Would it be better to check whether the driver is bound rather than loaded?
> 

AFAIK, our CI system never loads the SOF drivers, let me know if you 
have evidence to the contrary.

==
Chaitanya

> Regards,
> Pranay
> 
>> +			  igt_kmod_is_loaded("snd_hda_core") ? "yes" :
>> "no");
>> +
>> +	return supported;
>>   }
>>
>>   #define ELD_MAX_SIZE 256
>> --
>> 2.50.1
>