From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC2EAC001DF for ; Thu, 3 Aug 2023 07:06:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbjHCHGU (ORCPT ); Thu, 3 Aug 2023 03:06:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbjHCHFu (ORCPT ); Thu, 3 Aug 2023 03:05:50 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 430934212 for ; Thu, 3 Aug 2023 00:04:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4C1561C04 for ; Thu, 3 Aug 2023 07:04:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC2A5C433C8; Thu, 3 Aug 2023 07:04:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691046283; bh=2kto4InC6Iq51GEQ4G8zOyR+554dyqwej3nLgoOdS1Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZokVQq/AhvebfAfowrVjpRNECfm2YzrOAwDaqKPZyYReoujSetdtN5UZPDoWNy63C teg+oKX+hlIm+9SYoAqE8T1DlxVCG40Pb1htGwBCvrIgUt8jL9Szm/TYbCcmT+ScIs YdHHkSo1CpGmffBSVE232i9DS8Y5XCxwXwcrHlZFAYqtSCKLB2lgWpedkiV5CYW2Xl i0uzvUDaZuhs/pdCTdF7dJlk24i2MDyohYtgx1sBFnPMAD4nv85ClpMlYhseQ/ksLo MWhZ34/bPpp+772v9gBfWwmpTOQnKvYngvX+91zjlqVOaXMiAU7CIHiN+MjXbjAGAY 4NBGiVb1t1I/g== Message-ID: <5d7f0fcc-be07-822c-4803-1124e4bfaf16@kernel.org> Date: Thu, 3 Aug 2023 09:04:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH net-next v2 1/2] docs: net: page_pool: document PP_FLAG_DMA_SYNC_DEV parameters Content-Language: en-US To: Jakub Kicinski , davem@davemloft.net Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, aleksander.lobakin@intel.com, ilias.apalodimas@linaro.org, corbet@lwn.net, linux-doc@vger.kernel.org, Michael Chan , Lorenzo Bianconi , Randy Dunlap References: <20230802161821.3621985-1-kuba@kernel.org> <20230802161821.3621985-2-kuba@kernel.org> From: Jesper Dangaard Brouer In-Reply-To: <20230802161821.3621985-2-kuba@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 02/08/2023 18.18, Jakub Kicinski wrote: > Using PP_FLAG_DMA_SYNC_DEV is a bit confusing. It was perhaps > more obvious when it was introduced but the page pool use > has grown beyond XDP and beyond packet-per-page so now > making the heads and tails out of this feature is not > trivial. > > Obviously making the API more user friendly would be > a better fix, but until someone steps up to do that > let's at least document what the parameters are. > > Relevant discussion in the first Link. > > Link: https://lore.kernel.org/all/20230731114427.0da1f73b@kernel.org/ > Signed-off-by: Jakub Kicinski > --- Thanks for updating the documentation much appreciated. Acked-by: Jesper Dangaard Brouer