All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lazar, Lijo" <lijo.lazar@amd.com>
To: Marko Zekovic <Marko.Zekovic@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] amdgpu/pm: Enable sysfs nodes for pp_dpm_vclk and dclk
Date: Thu, 31 Mar 2022 15:37:21 +0530	[thread overview]
Message-ID: <5d93cb4b-0660-3efb-fae3-b1069e4a4db2@amd.com> (raw)
In-Reply-To: <20220328145425.4848-1-Marko.Zekovic@amd.com>



On 3/28/2022 8:24 PM, Marko Zekovic wrote:
> SMI clock measure API is failing on NAVI12, because
> sysfs node for pp_dpm_vclk is not existing. Enable
> sysfs node for pp_dpm_vclk.
> 
> v2: Also enable sysfs node for pp_dpm_dclk.
> 
> Signed-off-by: Marko Zekovic <Marko.Zekovic@amd.com>

If it's meant to be only for reading clock levels, make sure to change 
the attribute mode as well.

With that addressed,

	Reviewed-by: Lijo Lazar <lijo.lazar@amd.com>

Thanks,
Lijo

> Change-Id: I240fa055600bfc0d46dfec374339ba61764f9ab2
> ---
>   drivers/gpu/drm/amd/pm/amdgpu_pm.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index 9ce597ded31db..a6747ebf7e569 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -2001,11 +2001,13 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
>   			*states = ATTR_STATE_UNSUPPORTED;
>   	} else if (DEVICE_ATTR_IS(pp_dpm_vclk)) {
>   		if (!(gc_ver == IP_VERSION(10, 3, 1) ||
> -		      gc_ver == IP_VERSION(10, 3, 0)))
> +		      gc_ver == IP_VERSION(10, 3, 0) ||
> +		      gc_ver == IP_VERSION(10, 1, 2)))
>   			*states = ATTR_STATE_UNSUPPORTED;
>   	} else if (DEVICE_ATTR_IS(pp_dpm_dclk)) {
>   		if (!(gc_ver == IP_VERSION(10, 3, 1) ||
> -		      gc_ver == IP_VERSION(10, 3, 0)))
> +		      gc_ver == IP_VERSION(10, 3, 0) ||
> +		      gc_ver == IP_VERSION(10, 1, 2)))
>   			*states = ATTR_STATE_UNSUPPORTED;
>   	} else if (DEVICE_ATTR_IS(pp_power_profile_mode)) {
>   		if (amdgpu_dpm_get_power_profile_mode(adev, NULL) == -EOPNOTSUPP)
> 

      reply	other threads:[~2022-03-31 10:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-28 14:54 [PATCH] amdgpu/pm: Enable sysfs nodes for pp_dpm_vclk and dclk Marko Zekovic
2022-03-31 10:07 ` Lazar, Lijo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d93cb4b-0660-3efb-fae3-b1069e4a4db2@amd.com \
    --to=lijo.lazar@amd.com \
    --cc=Marko.Zekovic@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.