From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCazP-0006rv-Pi for ath10k@lists.infradead.org; Tue, 24 Sep 2019 02:55:45 +0000 MIME-Version: 1.0 Date: Tue, 24 Sep 2019 10:55:42 +0800 From: Yibo Zhao Subject: Re: [PATCH V3 2/4] mac80211: defer txqs removal from rbtree In-Reply-To: <87ef075lit.fsf@toke.dk> References: <1569223201-1490-1-git-send-email-yiboz@codeaurora.org> <1569223201-1490-3-git-send-email-yiboz@codeaurora.org> <87ef075lit.fsf@toke.dk> Message-ID: <5dadc4a130c2ba3d6548969f47c5f85c@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org T24gMjAxOS0wOS0yMyAxODo1NiwgVG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIHdyb3RlOgo+IFlp Ym8gWmhhbyA8eWlib3pAY29kZWF1cm9yYS5vcmc+IHdyaXRlczoKPiAKPj4gSW4gYSBsb29wIHR4 cXMgZGVxdWV1ZSBzY2VuYXJpbywgaWYgdGhlIGZpcnN0IHR4cSBpbiB0aGUgcmJ0cmVlIGdldHMK Pj4gcmVtb3ZlZCBmcm9tIHJidHJlZSBpbW1lZGlhdGVseSBpbiB0aGUgaWVlZTgwMjExX3JldHVy bl90eHEoKSwgdGhlCj4+IGxvb3Agd2lsbCBicmVhayBzb29uIGluIHRoZSBpZWVlODAyMTFfbmV4 dF90eHEoKSBkdWUgdG8gc2NoZWR1bGVfcG9zCj4+IG5vdCBsZWFkaW5nIHRvIHRoZSBzZWNvbmQg dHhxIGluIHRoZSByYnRyZWUuIFRodXMsIGRlZmVyaW5nIHRoZQo+PiByZW1vdmFsIHJpZ2h0IGJl Zm9yZSB0aGUgZW5kIG9mIHRoaXMgc2NoZWR1bGUgcm91bmQuCj4gCj4gRGlkbid0IHdlIGFncmVl IHRoYXQgd2UgY291bGQgZml4IHRoaXMgYnkgbWFraW5nIF9fdW5zY2hlZHVsZV90eHEoKQo+IGF3 YXJlIG9mIHNjaGVkdWxlX3BvcyBpbnN0ZWFkIG9mIHRoaXMgZGVmZXJyZWQgcmVtb3ZhbCBtZWNo YW5pc20/CgpZZXMsIFYzIGlzIGFjdHVhbGx5IHVzZWQgdG8gdXBkYXRlIHRoZSBjb21taXQgbG9n IG9mIFtQQVRDSCBWMyAzLzRdIHNvIAp0aGF0IHdlIGNhbiBkaXNjdXNzIGluIHBhcmFsbGVsIHdp dGggb3RoZXJzLCBhbmQgW1BBVENIIFYzIDQvNF0gZm9yIApkaXNjdXNzaW9uLiBQbGVhc2UgaWdu b3JlIFtQQVRDSCBWMyAyLzRdLiB3ZSBjYW4ga2VlcCBvdXIgZGlzY3Vzc2lvbiBpbiAKVjIgdW50 aWwgd2UgY29uY2x1ZGUgdGhlIGZpbmFsIG9uZSBhbmQgdGhlbiBhIG5ldyB2ZXJzaW9uIHdpbGwg YmUgc2VudCAKb3V0IGFsb25nIHdpdGggW21hYzgwMjExOiBTd2l0Y2ggdG8gYSB2aXJ0dWFsIHRp bWUtYmFzZWQgYWlydGltZSAKc2NoZWR1bGVyXSB3aGljaCBpbmNsdWRlcyB0aGUgcmVkdWNpbmcg bG9jayBmaXguCgpTb3JyeSBmb3IgdGhlIGNvbmZ1c2lvbiwgOykuCgo+IAo+IC1Ub2tlCgotLSAK WWlibwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRo MTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 646AEC432C1 for ; Tue, 24 Sep 2019 02:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3748B207FD for ; Tue, 24 Sep 2019 02:55:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="kivjp+Sg"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="kJvgB5MB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408834AbfIXCzo (ORCPT ); Mon, 23 Sep 2019 22:55:44 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:39748 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728992AbfIXCzo (ORCPT ); Mon, 23 Sep 2019 22:55:44 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 340AF6032C; Tue, 24 Sep 2019 02:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569293743; bh=MfPnhSxtM0OnJVZW0H9aUW4BawgL6o8WwzQf1XZzdK4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kivjp+SgDUkRBfZ0mAsgM7Vcw4RGX8GSE0doWbtsFtBwQlEaM/yhFm4JQmbZec8/N ikPxy7fTqoZHrDBNtMnvjKa02Dz8x43V9KIF1Zw7S/8egEaawj8pQ7SWEgXW3fhDTX ozYJNFt47jj6xQqxjCmBzVavG0mcebmoMqRAeGTM= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id C34F960240; Tue, 24 Sep 2019 02:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569293742; bh=MfPnhSxtM0OnJVZW0H9aUW4BawgL6o8WwzQf1XZzdK4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kJvgB5MBU+jLViNDsBn+bJtaFj1ibhJUthOcMVHp8rE+5C2l3HiPY9lL7ohX3YItp iza2YeasrWyxwblqYcfYpE71CmlhXsmPNpGIRkeTFakWrQhKKs6dimJvqXmS0bal4O bxa9ebrP151wjpvU1vZ+TQrzAz+220jO8H7e3VeE= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 24 Sep 2019 10:55:42 +0800 From: Yibo Zhao To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH V3 2/4] mac80211: defer txqs removal from rbtree In-Reply-To: <87ef075lit.fsf@toke.dk> References: <1569223201-1490-1-git-send-email-yiboz@codeaurora.org> <1569223201-1490-3-git-send-email-yiboz@codeaurora.org> <87ef075lit.fsf@toke.dk> Message-ID: <5dadc4a130c2ba3d6548969f47c5f85c@codeaurora.org> X-Sender: yiboz@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2019-09-23 18:56, Toke Høiland-Jørgensen wrote: > Yibo Zhao writes: > >> In a loop txqs dequeue scenario, if the first txq in the rbtree gets >> removed from rbtree immediately in the ieee80211_return_txq(), the >> loop will break soon in the ieee80211_next_txq() due to schedule_pos >> not leading to the second txq in the rbtree. Thus, defering the >> removal right before the end of this schedule round. > > Didn't we agree that we could fix this by making __unschedule_txq() > aware of schedule_pos instead of this deferred removal mechanism? Yes, V3 is actually used to update the commit log of [PATCH V3 3/4] so that we can discuss in parallel with others, and [PATCH V3 4/4] for discussion. Please ignore [PATCH V3 2/4]. we can keep our discussion in V2 until we conclude the final one and then a new version will be sent out along with [mac80211: Switch to a virtual time-based airtime scheduler] which includes the reducing lock fix. Sorry for the confusion, ;). > > -Toke -- Yibo