From: Stephen Boyd <swboyd@chromium.org>
To: kgunda@codeaurora.org
Cc: Rajendra Nayak <rnayak@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mka@chromium.org
Subject: Re: [PATCH v3 08/11] arm64: dts: qcom: pm6150: Add PM6150/PM6150L PMIC peripherals
Date: Wed, 30 Oct 2019 07:37:58 -0700 [thread overview]
Message-ID: <5db9a047.1c69fb81.85ac7.7aa1@mx.google.com> (raw)
In-Reply-To: <87ec773e0d92571c4bbed44eeb65cff5@codeaurora.org>
Quoting kgunda@codeaurora.org (2019-10-30 00:06:05)
> On 2019-10-29 22:08, Stephen Boyd wrote:
> > Quoting Rajendra Nayak (2019-10-23 02:02:16)
> >> diff --git a/arch/arm64/boot/dts/qcom/pm6150.dtsi
> >> b/arch/arm64/boot/dts/qcom/pm6150.dtsi
> >> new file mode 100644
> >> index 000000000000..20eb928e5ce3
> >> --- /dev/null
> >> +++ b/arch/arm64/boot/dts/qcom/pm6150.dtsi
> >> @@ -0,0 +1,85 @@
> >> +// SPDX-License-Identifier: BSD-3-Clause
> >> +// Copyright (c) 2019, The Linux Foundation. All rights reserved.
> >> +
> >> +#include <dt-bindings/iio/qcom,spmi-vadc.h>
> >> +#include <dt-bindings/input/linux-event-codes.h>
> >> +#include <dt-bindings/interrupt-controller/irq.h>
> >> +#include <dt-bindings/spmi/spmi.h>
> >> +#include <dt-bindings/thermal/thermal.h>
> >> +
> >> +&spmi_bus {
> >> + pm6150_lsid0: pmic@0 {
> >> + compatible = "qcom,pm6150", "qcom,spmi-pmic";
> >> + reg = <0x0 SPMI_USID>;
> >> + #address-cells = <1>;
> >> + #size-cells = <0>;
> >> +
> >> + pm6150_pon: pon@800 {
> >> + compatible = "qcom,pm8998-pon";
> >> + reg = <0x800>;
> >> + mode-bootloader = <0x2>;
> >> + mode-recovery = <0x1>;
> >
> > Can this have status = "disabled"? Or is the idea that if the pmic
> > power
> > button isn't used it should be disabled in the board dts file?
> >
> Yes. The idea is to go with latter option. Disable it in the board dts
> file if the
> pmic power button is not used.
Ok. Thanks.
> >> +
> >> + interrupt-names = "pm6150_gpio1",
> >> "pm6150_gpio2",
> >> + "pm6150_gpio3",
> >> "pm6150_gpio4",
> >> + "pm6150_gpio5",
> >> "pm6150_gpio6",
> >> + "pm6150_gpio7",
> >> "pm6150_gpio8",
> >> + "pm6150_gpio9",
> >> "pm6150_gpio10";
> >
> > And this? And have gpio-ranges and use the irqdomain work. Basically,
> > should look like pm8998.
> Ok.. We can go ahead with the pm8998 way as well. We will address it in
> next series.
Yes please use the pm8998 way..
next prev parent reply other threads:[~2019-10-30 14:38 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 9:02 [PATCH v3 00/11] Add device tree support for sc7180 Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 01/11] dt-bindings: qcom: Add SC7180 bindings Rajendra Nayak
2019-10-25 19:50 ` Rob Herring
2019-11-04 6:03 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 02/11] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc Rajendra Nayak
2019-10-29 16:49 ` Stephen Boyd
2019-11-04 6:15 ` Rajendra Nayak
2019-10-30 5:19 ` kbuild test robot
2019-10-23 9:02 ` [PATCH v3 03/11] dt-bindings: arm-smmu: update binding for qcom sc7180 SoC Rajendra Nayak
2019-10-25 19:51 ` Rob Herring
2019-11-04 6:04 ` Rajendra Nayak
2019-10-29 16:42 ` Stephen Boyd
2019-11-04 6:11 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 04/11] arm64: dts: sc7180: Add device node for apps_smmu Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 05/11] arm64: dts: qcom: sc7180: Add cmd_db reserved area Rajendra Nayak
2019-10-23 12:16 ` Sibi Sankar
2019-10-24 2:30 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 06/11] arm64: dts: qcom: sc7180: Add rpmh-rsc node Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 07/11] arm64: dts: qcom: sc7180: Add SPMI PMIC arbiter device Rajendra Nayak
2019-10-29 16:41 ` Stephen Boyd
2019-10-30 6:06 ` kgunda
2019-10-30 14:37 ` Stephen Boyd
2019-11-04 6:10 ` Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 08/11] arm64: dts: qcom: pm6150: Add PM6150/PM6150L PMIC peripherals Rajendra Nayak
2019-10-29 16:38 ` Stephen Boyd
2019-10-30 7:06 ` kgunda
2019-10-30 14:37 ` Stephen Boyd [this message]
2019-10-23 9:02 ` [PATCH v3 09/11] arm64: dts: qcom: sc7180-idp: Add RPMh regulators Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 10/11] arm64: dts: qcom: SC7180: Add node for rpmhcc clock driver Rajendra Nayak
2019-10-23 9:02 ` [PATCH v3 11/11] arm64: dts: qcom: sc7180: Add pdc interrupt controller Rajendra Nayak
2019-10-25 19:47 ` Matthias Kaehlcke
2019-11-04 6:03 ` Rajendra Nayak
2019-10-29 16:50 ` Stephen Boyd
2019-10-30 19:50 ` Matthias Kaehlcke
2019-11-04 6:17 ` Rajendra Nayak
2019-11-04 6:33 ` Bjorn Andersson
2019-11-04 6:56 ` Rajendra Nayak
2019-11-04 7:10 ` Bjorn Andersson
2019-11-05 0:34 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5db9a047.1c69fb81.85ac7.7aa1@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.