Re: [PATCH 2/2] dt-bindings: phy-qcom-qmp: Add SC7180 QMP phy support

[Stephen Boyd <swboyd@chromium.org>]

Quoting Sandeep Maheswaram (2019-10-29 23:55:44)
> Add QMP phy entries for SC7180 in device tree bindings.
> 
> Signed-off-by: Sandeep Maheswaram <sanm@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 

Can you convert this binding to YAML? Would make it easier to see what
is applicable to certain compatibles.

> diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> index eac9ad3..369f5b7 100644
> --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt
> @@ -15,17 +15,20 @@ Required properties:
>                "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845,
>                "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845,
>                "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845,
> -              "qcom,sm8150-qmp-ufs-phy" for UFS QMP phy on sm8150.
> +              "qcom,sm8150-qmp-ufs-phy" for UFS QMP phy on sm8150,

Should remove the comma at the end of these lines so they don't have to
change.

> +              "qcom,sc7180-qmp-usb3-phy" for USB3 QMP V3 phy on sc7180.
>  
>  - reg:
>    - index 0: address and length of register set for PHY's common
>               serdes block.
>    - index 1: address and length of the DP_COM control block (for
> -             "qcom,sdm845-qmp-usb3-phy" only).
> +             "qcom,sdm845-qmp-usb3-phy" and "qcom,sc7180-qmp-usb3-phy" only).
>  
>  - reg-names:
>    - For "qcom,sdm845-qmp-usb3-phy":
>      - Should be: "reg-base", "dp_com"
> +  - For "qcom,sc7180-qmp-usb3-phy":
> +    - Should be: "reg-base", "dp_com"
>    - For all others:
>      - The reg-names property shouldn't be defined.

Why is this so complicated? Would be better to just know that index 1 is
dp_com and index 0 is "normal" register base.

>  
> @@ -60,6 +63,8 @@ Required properties:
>                         "ref", "ref_aux".
>                 For "qcom,sm8150-qmp-ufs-phy" must contain:
>                         "ref", "ref_aux".
> +               For "qcom,sc7180-qmp-usb3-phy" must contain:
> +                       "aux", "cfg_ahb", "ref", "com_aux".
>  
>   - resets: a list of phandles and reset controller specifier pairs,
>            one for each entry in reset-names.
> @@ -88,6 +93,8 @@ Required properties:
>                         "ufsphy".
>                 For "qcom,sm8150-qmp-ufs-phy": must contain:
>                         "ufsphy".
> +               For "qcom,sc7180-qmp-usb3-phy" must contain:
> +                       "phy", "common".

Please sort these lists based on compatible string.

>  
>   - vdda-phy-supply: Phandle to a regulator supply to PHY core block.
>   - vdda-pll-supply: Phandle to 1.8V regulator supply to PHY refclk pll block.