All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>,
	johan.hedberg@gmail.com, marcel@holtmann.org
Cc: mka@chromium.org, linux-kernel@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
	linux-arm-msm@vger.kernel.org, bgodavar@codeaurora.org,
	tientzu@chromium.org, seanpaul@chromium.org
Subject: Re: [PATCH v1] Bluetooth: hci_qca: Enable clocks required for BT SOC
Date: Thu, 14 Nov 2019 09:19:19 -0800	[thread overview]
Message-ID: <5dcd8c98.1c69fb81.4690b.49fe@mx.google.com> (raw)
In-Reply-To: <20191114081430.25427-1-bgodavar@codeaurora.org>

Quoting Balakrishna Godavarthi (2019-11-14 00:14:30)
> @@ -1423,6 +1427,20 @@ static int qca_power_off(struct hci_dev *hdev)
>         return 0;
>  }
>  
> +static int qca_power_on(struct qca_serdev *qcadev)
> +{
> +       int err;
> +
> +       if (qcadev->susclk) {

clk_prepare_enable() shouldn't return anything besides 0 when passed a
NULL pointer. Please drop this if condition in addition to the one on
the clk_disable_unprepare().

> +               err = clk_prepare_enable(qcadev->susclk);
> +               if (err)
> +                       return err;
> +       }

  parent reply	other threads:[~2019-11-14 17:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14  8:14 [PATCH v1] Bluetooth: hci_qca: Enable clocks required for BT SOC Balakrishna Godavarthi
2019-11-14  8:55 ` Marcel Holtmann
2019-11-18  6:01   ` bgodavar
2019-11-14 17:19 ` Stephen Boyd [this message]
2019-11-18  6:21   ` bgodavar
2019-12-12 17:43 ` Matthias Kaehlcke
2020-01-14 11:34   ` bgodavar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5dcd8c98.1c69fb81.4690b.49fe@mx.google.com \
    --to=swboyd@chromium.org \
    --cc=bgodavar@codeaurora.org \
    --cc=hemantg@codeaurora.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mka@chromium.org \
    --cc=seanpaul@chromium.org \
    --cc=tientzu@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.