From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salyzyn via Linux-f2fs-devel Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr Date: Wed, 28 Aug 2019 07:40:15 -0700 Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> References: <20190827150544.151031-1-salyzyn@android.com> <20190828142423.GA1955@infradead.org> Reply-To: Mark Salyzyn Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190828142423.GA1955@infradead.org> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net To: Christoph Hellwig Cc: Latchesar Ionkov , Hugh Dickins , Mike Marshall , James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Anna Schumaker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jan Kara , Casey Schaufler , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Mimi Zohar , linux-cifs@vger.kernel.org, Paul Moore , "Darrick J. Wong" , Eric Sandeen , kernel-team@android.com, selinux@vger.kernel.o List-Id: ceph-devel.vger.kernel.org T24gOC8yOC8xOSA3OjI0IEFNLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90ZToKPiBPbiBUdWUsIEF1 ZyAyNywgMjAxOSBhdCAwODowNToxNUFNIC0wNzAwLCBNYXJrIFNhbHl6eW4gd3JvdGU6Cj4+IFJl cGxhY2UgYXJndW1lbnRzIGZvciBnZXQgYW5kIHNldCB4YXR0ciBtZXRob2RzLCBhbmQgX192ZnNf Z2V0eGF0dHIKPj4gYW5kIF9fdmZzX3NldGF4dHIgZnVuY3Rpb25zIHdpdGggYSByZWZlcmVuY2Ug dG8gdGhlIGZvbGxvd2luZyBub3cKPj4gY29tbW9uIGFyZ3VtZW50IHN0cnVjdHVyZToKPiBZaWtl cy4gIFRoYXQgbG9va3MgbGlrZSBhIG1lc3MuICBXaHkgY2FuJ3Qgd2UgcGFzcyBhIGtlcm5lbC1v bmx5Cj4gZmxhZyBpbiB0aGUgZXhpc3RpbmcgZmxhZ3MgZmllbGQgZm9yIOKCiz5zZXQgYW5kIGFk ZCBhIGZsYWdzIGZpZWxkCj4gdG8gLT5nZXQ/ICBQYXNzaW5nIG1ldGhvZHMgYnkgc3RydWN0dXJl IGFsd2F5cyB0ZW5kcyB0byBiZSBhIG1lc3MuCgpUaGlzIHdhcyBhIHJlc3BvbnNlIHRvIEdyZWdL SEAgY3JpdGljaXNtLCBhbiBlYXJsaWVyIHBhdGNoIHNldCBqdXN0IAphZGRlZCBhIGZsYWcgYXMg eW91IHN0YXRlZCB0byBnZXQgbWV0aG9kLCB1bnRpbCBjb21wbGFpbnRzIG9mIGFuIApleGNlc3Np dmVseSBsb25nIGFyZ3VtZW50IGxpc3QgYW5kIGZyYWdpbGl0eSB0byBhZGQgb3IgY2hhbmdlIG1v cmUgCmFyZ3VtZW50cy4KClNvIG1hbnkgd2F5cyBoYXZlIGJlZW4gdHJpZWQgdG8gc2tpbiB0aGlz IGNhdCAuLi4gdGhlIHJpc2sgd2FzIHRha2VuIHRvIApwbGVhc2Ugc29tZSwgYW5kIHdlIG5vdyBo YXZlIGh1bmRyZWRzIG9mIHN0YWtlaG9sZGVycywgd2hlbiB0aGUgZmlyc3QgCnBhdGNoIHNldCB3 YXMgbGVzcyB0aGFuIGEgZG96ZW4uIEEgcmVjaXBlIGZvciBmYWlsdXJlPwoKLS0gTWFyawoKCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZz LWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5l dApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZz LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salyzyn Date: Wed, 28 Aug 2019 07:40:15 -0700 Subject: [Cluster-devel] [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr In-Reply-To: <20190828142423.GA1955@infradead.org> References: <20190827150544.151031-1-salyzyn@android.com> <20190828142423.GA1955@infradead.org> Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 8/28/19 7:24 AM, Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote: >> Replace arguments for get and set xattr methods, and __vfs_getxattr >> and __vfs_setaxtr functions with a reference to the following now >> common argument structure: > Yikes. That looks like a mess. Why can't we pass a kernel-only > flag in the existing flags field for ?>set and add a flags field > to ->get? Passing methods by structure always tends to be a mess. This was a response to GregKH@ criticism, an earlier patch set just added a flag as you stated to get method, until complaints of an excessively long argument list and fragility to add or change more arguments. So many ways have been tried to skin this cat ... the risk was taken to please some, and we now have hundreds of stakeholders, when the first patch set was less than a dozen. A recipe for failure? -- Mark From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Salyzyn via Linux-f2fs-devel Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr Date: Wed, 28 Aug 2019 07:40:15 -0700 Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> References: <20190827150544.151031-1-salyzyn@android.com> <20190828142423.GA1955@infradead.org> Reply-To: Mark Salyzyn Mime-Version: 1.0 Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190828142423.GA1955@infradead.org> Content-Language: en-GB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Content-Type: text/plain; charset="windows-1252"; format="flowed" To: Christoph Hellwig Cc: Latchesar Ionkov , Hugh Dickins , Mike Marshall , James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Anna Schumaker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jan Kara , Casey Schaufler , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Mimi Zohar , linux-cifs@vger.kernel.org, Paul Moore , "Darrick J. Wong" , Eric Sandeen , kernel-team@android.com, selinux@vger.kernel.o T24gOC8yOC8xOSA3OjI0IEFNLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90ZToKPiBPbiBUdWUsIEF1 ZyAyNywgMjAxOSBhdCAwODowNToxNUFNIC0wNzAwLCBNYXJrIFNhbHl6eW4gd3JvdGU6Cj4+IFJl cGxhY2UgYXJndW1lbnRzIGZvciBnZXQgYW5kIHNldCB4YXR0ciBtZXRob2RzLCBhbmQgX192ZnNf Z2V0eGF0dHIKPj4gYW5kIF9fdmZzX3NldGF4dHIgZnVuY3Rpb25zIHdpdGggYSByZWZlcmVuY2Ug dG8gdGhlIGZvbGxvd2luZyBub3cKPj4gY29tbW9uIGFyZ3VtZW50IHN0cnVjdHVyZToKPiBZaWtl cy4gIFRoYXQgbG9va3MgbGlrZSBhIG1lc3MuICBXaHkgY2FuJ3Qgd2UgcGFzcyBhIGtlcm5lbC1v bmx5Cj4gZmxhZyBpbiB0aGUgZXhpc3RpbmcgZmxhZ3MgZmllbGQgZm9yIOKCiz5zZXQgYW5kIGFk ZCBhIGZsYWdzIGZpZWxkCj4gdG8gLT5nZXQ/ICBQYXNzaW5nIG1ldGhvZHMgYnkgc3RydWN0dXJl IGFsd2F5cyB0ZW5kcyB0byBiZSBhIG1lc3MuCgpUaGlzIHdhcyBhIHJlc3BvbnNlIHRvIEdyZWdL SEAgY3JpdGljaXNtLCBhbiBlYXJsaWVyIHBhdGNoIHNldCBqdXN0IAphZGRlZCBhIGZsYWcgYXMg eW91IHN0YXRlZCB0byBnZXQgbWV0aG9kLCB1bnRpbCBjb21wbGFpbnRzIG9mIGFuIApleGNlc3Np dmVseSBsb25nIGFyZ3VtZW50IGxpc3QgYW5kIGZyYWdpbGl0eSB0byBhZGQgb3IgY2hhbmdlIG1v cmUgCmFyZ3VtZW50cy4KClNvIG1hbnkgd2F5cyBoYXZlIGJlZW4gdHJpZWQgdG8gc2tpbiB0aGlz IGNhdCAuLi4gdGhlIHJpc2sgd2FzIHRha2VuIHRvIApwbGVhc2Ugc29tZSwgYW5kIHdlIG5vdyBo YXZlIGh1bmRyZWRzIG9mIHN0YWtlaG9sZGVycywgd2hlbiB0aGUgZmlyc3QgCnBhdGNoIHNldCB3 YXMgbGVzcyB0aGFuIGEgZG96ZW4uIEEgcmVjaXBlIGZvciBmYWlsdXJlPwoKLS0gTWFyawoKCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZz LWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5l dApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZz LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0652FC3A5A1 for ; Wed, 28 Aug 2019 14:50:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B9612077B for ; Wed, 28 Aug 2019 14:50:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.ozlabs.org header.i=@lists.ozlabs.org header.b="LkK53ie3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=android.com header.i=@android.com header.b="OlcPfkFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B9612077B Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.ozlabs.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46JTDT74tczDrBr for ; Thu, 29 Aug 2019 00:50:01 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.ozlabs.org; s=201707; t=1567003802; bh=Q3F2pMcDVoGjA4gufrXtnB+Ts7KREZEw96QVHlPW7zI=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LkK53ie3xKak8mT8mgKK42rHcVPGdYxdjCvNp4uj5N6m464kcgryXDEEdgHiqP3aI xjgVUBF5CbdwHZzCumdwnx8uvraMdK//EPInarJ/ZRYWM23P/QrtNyiAFV7/ZP7xSq I8tqMtdfCVGyYYCMvKHwUZ9mx3/VfPgmaqe2jka7OAKawQg0icGV2lCTgLcu9DIvuS RmVthhzf376paSLI5fwJs+oDSu1fxG5QxySpAfNGARa9/V854K+e0NAky7f5i2q1Tk rfq4IHv5E9WuSHKJXVkV9vq60VIijX/JhqDvyq99gJP5EoTWMBQUURyUejcnTsR2qr M5MsVNtd0iaAQ== Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=android.com (client-ip=2607:f8b0:4864:20::542; helo=mail-pg1-x542.google.com; envelope-from=salyzyn@android.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=android.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=android.com header.i=@android.com header.b="OlcPfkFh"; dkim-atps=neutral Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46JT1L3gbZzDqK9 for ; Thu, 29 Aug 2019 00:40:21 +1000 (AEST) Received: by mail-pg1-x542.google.com with SMTP id m3so1566522pgv.13 for ; Wed, 28 Aug 2019 07:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=OlcPfkFh4eVXaPXXhh3cHvgBURsJe3iAt4+TEVeWmIUa8zc09e0oQ5MaZNlepG2vze B3r7RgJuWq9O6TIbswaNUIKe8aYWW+KNRgEXeCMfCvmELHUyftJPl7HAVt/DUWoqH+mt 7FiMUsP13ILyRxskXvgoEKTt4mcyDqpG+bZTW39pIt/5h+k8/JBgcB7qNM0XACYD7ale oWFmT2jC5R2Rv9fP9CO4NSXlbVjGTO4SWvbIfLdPsT4850CBsX7b6iyMaVYsWWgBm0EJ ydfkWGX0BboAbCSeR2RRikvC2V1c34KnlnNThn4oWcDh6RwGfO3sPku0/xiss22u0zC8 qA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=LOFlbIYcxPV0htjFmAU5YA08Q3mBIty9wZMufCF9SQGf1Oe1HPiOYeoddeT9HELEdv BgMga4f8u/QOl8f26ThIgc2ZVJdERpbbSdxBpu+oaaZSo8bmPSpqOwlcHhfiUsnb1SB/ ZbyKF/dY9oqkFYqAOXggMlCyDGkatw0eHfLR3zrKKH4Xq6QK/uoYlyMwVwxj1htVk7lV bE0GIp0HOX7VCUPz7/XziQmO4ORc7wffZJq4po4ZqqJfunau+wMeg0XtXbvu+jhwyfH7 YKIh11u44ALsFhgR8RH/tnVDYvkrrzPj/2gaoEbm3/9lMQ4kqNUuEuD31TMWp5m3/a5a pGcQ== X-Gm-Message-State: APjAAAUziZXTzkNI49gzSq59k2Jp+ZHpRuQR4YxvBR0yMYSdLeY7D3B1 KT5IbyxiAmQY99L5JDOqUw6ykg== X-Google-Smtp-Source: APXvYqxMi0WkPdC/TIWQ/rEP0W+6WEwgY/rp8ZhYjwRr9PMekyUrfkMqryPcx5ziGSRNx/jQnRs5oA== X-Received: by 2002:a17:90b:8ca:: with SMTP id ds10mr4474530pjb.139.1567003218534; Wed, 28 Aug 2019 07:40:18 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id t9sm7295641pgj.89.2019.08.28.07.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2019 07:40:17 -0700 (PDT) Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr To: Christoph Hellwig References: <20190827150544.151031-1-salyzyn@android.com> <20190828142423.GA1955@infradead.org> Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> Date: Wed, 28 Aug 2019 07:40:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190828142423.GA1955@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mark Salyzyn via Linux-erofs Reply-To: Mark Salyzyn Cc: Latchesar Ionkov , Hugh Dickins , Mike Marshall , James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Anna Schumaker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jan Kara , Casey Schaufler , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Mimi Zohar , linux-cifs@vger.kernel.org, Paul Moore , "Darrick J. Wong" , Eric Sandeen , kernel-team@android.com, selinux@vger.kernel.org, Brian Foster , reiserfs-devel@vger.kernel.org, Tejun Heo , Jaegeuk Kim , Theodore Ts'o , Miklos Szeredi , linux-f2fs-devel@lists.sourceforge.net, Benjamin Coddington , linux-integrity@vger.kernel.org, Martin Brandenburg , Chris Mason , linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org, Jonathan Corbet , Vyacheslav Dubeyko , Allison Henderson , Ilya Dryomov , linux-ext4@vger.kernel.org, Stephen Smalley , Serge Hallyn , Eric Paris , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, Bob Peterson , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, "David S. Miller" , ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net, Jan Kara , Eric Biggers , Dominique Martinet , Adrian Hunter , David Howells , Joseph Qi , Andreas Dilger , devel@driverdev.osuosl.org, "J. Bruce Fields" , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Mark Fasheh , cluster-devel@redhat.com, Steve French , v9fs-developer@lists.sourceforge.net, Bharath Vedartham , Jann Horn , ecryptfs@vger.kernel.org, Josef Bacik , Dave Chinner , David Sterba , Artem Bityutskiy , netdev@vger.kernel.org, linux-unionfs@vger.kernel.org, stable@vger.kernel.org, Tyler Hicks , linux-security-module@vger.kernel.org, Phillip Lougher , David Woodhouse , linux-btrfs@vger.kernel.org, Alexander Viro Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On 8/28/19 7:24 AM, Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote: >> Replace arguments for get and set xattr methods, and __vfs_getxattr >> and __vfs_setaxtr functions with a reference to the following now >> common argument structure: > Yikes. That looks like a mess. Why can't we pass a kernel-only > flag in the existing flags field for ₋>set and add a flags field > to ->get? Passing methods by structure always tends to be a mess. This was a response to GregKH@ criticism, an earlier patch set just added a flag as you stated to get method, until complaints of an excessively long argument list and fragility to add or change more arguments. So many ways have been tried to skin this cat ... the risk was taken to please some, and we now have hundreds of stakeholders, when the first patch set was less than a dozen. A recipe for failure? -- Mark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB762C3A5A1 for ; Wed, 28 Aug 2019 14:40:27 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B946C2077B; Wed, 28 Aug 2019 14:40:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lists.sourceforge.net header.i=@lists.sourceforge.net header.b="QTR0mW4A"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="hGhAJTej"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="is/IR2/7"; dkim=neutral (0-bit key) header.d=android.com header.i=@android.com header.b="OlcPfkFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B946C2077B Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=lists.sourceforge.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Type:Content-Transfer-Encoding:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:Message-ID: References:To:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZmQ6GrR20aXWss19GHzm7RSI6x3m2Z9/o7f7qvd00IQ=; b=QTR0mW4ATdKFKxLSbk800Ukb2M cxVqFhWj+c3Wt5jUSeKHmGaS2LIDotaaM/i/GBQJeKFdd6LesgKyVgIM97qtg/2HjSDX4eWD0MdIK 0VYut//OBp3GC4B0n+t0cYrwBZxzWEfSjEapnsYmstogtsbCNnL9tOZXYGEazbI8LLQw=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1i2z7b-0000FJ-C9; Wed, 28 Aug 2019 14:40:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1i2z7a-0000Ew-FO for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Aug 2019 14:40:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=hGhAJTejL21NdBoNy259zvX+ZD ylJFPJ1oHl8IPENyBHBLCMUx6nEJCmU8anWJ7geI7+sEO9rzMiSSjli61KPyJAs28h4NEhjRN8ELW fiL5v//Rn0E43Tyvwgx16hu51bP1kul0uryPaTSEpKmfuM/3wp80w3MFGPNK2SWXmitE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=is/IR2/72GPuCEHjzC73fps3S7 UcCNwYqM6gJxXfuWttgTKrh9D34frnKdLi7sNppTovliuPh71uKqRR/SGuHFsqIvpcArqeijC21Fu 4yU/4DVvkcy120y4Mn1sQDtMfCW46MwxUNSFA8cQ6fzZvaF6HblqCiyrTYG4Aj/csrr4=; Received: from mail-pg1-f193.google.com ([209.85.215.193]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) id 1i2z7Z-001X4s-Al for linux-f2fs-devel@lists.sourceforge.net; Wed, 28 Aug 2019 14:40:26 +0000 Received: by mail-pg1-f193.google.com with SMTP id o13so1571376pgp.12 for ; Wed, 28 Aug 2019 07:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=OlcPfkFh4eVXaPXXhh3cHvgBURsJe3iAt4+TEVeWmIUa8zc09e0oQ5MaZNlepG2vze B3r7RgJuWq9O6TIbswaNUIKe8aYWW+KNRgEXeCMfCvmELHUyftJPl7HAVt/DUWoqH+mt 7FiMUsP13ILyRxskXvgoEKTt4mcyDqpG+bZTW39pIt/5h+k8/JBgcB7qNM0XACYD7ale oWFmT2jC5R2Rv9fP9CO4NSXlbVjGTO4SWvbIfLdPsT4850CBsX7b6iyMaVYsWWgBm0EJ ydfkWGX0BboAbCSeR2RRikvC2V1c34KnlnNThn4oWcDh6RwGfO3sPku0/xiss22u0zC8 qA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=swBc0atPG4oR/VAAOV9JH7PCZASn0+t2+80jgFZUDdbWZ1OCfHBQxt6/a3Io6vJmpw UubrO4yruUsvUzlxUl5FYcIhjOtVGEmvBZu3iNyEVwVyBqnyaKTS57MIsYmW5+vw8voF mzS3guzgOopHx8VhBkE/DOZkaIWX9ZtazB95yEyh3lNfcgyzGp+Njbb/7jEVJK4FcOD7 vIJH3o1DjAXCNoegSZmc7/wec5aQlpMm05p7RoQ7Fz7Gd7llmXKeRKMPtYU76zz7Ex9Y l+7oiy1haMTr44cd+qT5Z+Jyxv7wd8Tp7uWVID3TY7YroBhdjkA3vUezFce3Gkz/1MBO 5/+w== X-Gm-Message-State: APjAAAVLZHqswBFLVm99SirSUCJLK8qIWzJLvw6ERJbvO4HfwymA1Zvs BQlbM0RA3ecI/V5evni1j/1QSw== X-Google-Smtp-Source: APXvYqxMi0WkPdC/TIWQ/rEP0W+6WEwgY/rp8ZhYjwRr9PMekyUrfkMqryPcx5ziGSRNx/jQnRs5oA== X-Received: by 2002:a17:90b:8ca:: with SMTP id ds10mr4474530pjb.139.1567003218534; Wed, 28 Aug 2019 07:40:18 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id t9sm7295641pgj.89.2019.08.28.07.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2019 07:40:17 -0700 (PDT) To: Christoph Hellwig References: <20190827150544.151031-1-salyzyn@android.com> <20190828142423.GA1955@infradead.org> Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> Date: Wed, 28 Aug 2019 07:40:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190828142423.GA1955@infradead.org> Content-Language: en-GB X-Headers-End: 1i2z7Z-001X4s-Al Subject: Re: [f2fs-dev] [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mark Salyzyn via Linux-f2fs-devel Reply-To: Mark Salyzyn Cc: Latchesar Ionkov , Hugh Dickins , Mike Marshall , James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Anna Schumaker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jan Kara , Casey Schaufler , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Mimi Zohar , linux-cifs@vger.kernel.org, Paul Moore , "Darrick J. Wong" , Eric Sandeen , kernel-team@android.com, selinux@vger.kernel.org, Brian Foster , reiserfs-devel@vger.kernel.org, Tejun Heo , Jaegeuk Kim , Theodore Ts'o , Miklos Szeredi , linux-f2fs-devel@lists.sourceforge.net, Benjamin Coddington , linux-integrity@vger.kernel.org, Martin Brandenburg , Chris Mason , linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org, Jonathan Corbet , Vyacheslav Dubeyko , Allison Henderson , Ilya Dryomov , linux-ext4@vger.kernel.org, Stephen Smalley , Serge Hallyn , Eric Paris , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, Bob Peterson , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, "David S. Miller" , ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net, Jan Kara , Eric Biggers , Dominique Martinet , Adrian Hunter , David Howells , Joseph Qi , Andreas Dilger , devel@driverdev.osuosl.org, "J. Bruce Fields" , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Mark Fasheh , cluster-devel@redhat.com, Steve French , v9fs-developer@lists.sourceforge.net, Bharath Vedartham , Jann Horn , ecryptfs@vger.kernel.org, Josef Bacik , Dave Chinner , David Sterba , Artem Bityutskiy , netdev@vger.kernel.org, linux-unionfs@vger.kernel.org, stable@vger.kernel.org, Tyler Hicks , linux-security-module@vger.kernel.org, Phillip Lougher , David Woodhouse , linux-btrfs@vger.kernel.org, Alexander Viro Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gOC8yOC8xOSA3OjI0IEFNLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90ZToKPiBPbiBUdWUsIEF1 ZyAyNywgMjAxOSBhdCAwODowNToxNUFNIC0wNzAwLCBNYXJrIFNhbHl6eW4gd3JvdGU6Cj4+IFJl cGxhY2UgYXJndW1lbnRzIGZvciBnZXQgYW5kIHNldCB4YXR0ciBtZXRob2RzLCBhbmQgX192ZnNf Z2V0eGF0dHIKPj4gYW5kIF9fdmZzX3NldGF4dHIgZnVuY3Rpb25zIHdpdGggYSByZWZlcmVuY2Ug dG8gdGhlIGZvbGxvd2luZyBub3cKPj4gY29tbW9uIGFyZ3VtZW50IHN0cnVjdHVyZToKPiBZaWtl cy4gIFRoYXQgbG9va3MgbGlrZSBhIG1lc3MuICBXaHkgY2FuJ3Qgd2UgcGFzcyBhIGtlcm5lbC1v bmx5Cj4gZmxhZyBpbiB0aGUgZXhpc3RpbmcgZmxhZ3MgZmllbGQgZm9yIOKCiz5zZXQgYW5kIGFk ZCBhIGZsYWdzIGZpZWxkCj4gdG8gLT5nZXQ/ICBQYXNzaW5nIG1ldGhvZHMgYnkgc3RydWN0dXJl IGFsd2F5cyB0ZW5kcyB0byBiZSBhIG1lc3MuCgpUaGlzIHdhcyBhIHJlc3BvbnNlIHRvIEdyZWdL SEAgY3JpdGljaXNtLCBhbiBlYXJsaWVyIHBhdGNoIHNldCBqdXN0IAphZGRlZCBhIGZsYWcgYXMg eW91IHN0YXRlZCB0byBnZXQgbWV0aG9kLCB1bnRpbCBjb21wbGFpbnRzIG9mIGFuIApleGNlc3Np dmVseSBsb25nIGFyZ3VtZW50IGxpc3QgYW5kIGZyYWdpbGl0eSB0byBhZGQgb3IgY2hhbmdlIG1v cmUgCmFyZ3VtZW50cy4KClNvIG1hbnkgd2F5cyBoYXZlIGJlZW4gdHJpZWQgdG8gc2tpbiB0aGlz IGNhdCAuLi4gdGhlIHJpc2sgd2FzIHRha2VuIHRvIApwbGVhc2Ugc29tZSwgYW5kIHdlIG5vdyBo YXZlIGh1bmRyZWRzIG9mIHN0YWtlaG9sZGVycywgd2hlbiB0aGUgZmlyc3QgCnBhdGNoIHNldCB3 YXMgbGVzcyB0aGFuIGEgZG96ZW4uIEEgcmVjaXBlIGZvciBmYWlsdXJlPwoKLS0gTWFyawoKCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZz LWRldmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5l dApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZz LWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDDB7C3A5A1 for ; Wed, 28 Aug 2019 14:40:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE6DE2064A for ; Wed, 28 Aug 2019 14:40:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rAJQYWfD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=android.com header.i=@android.com header.b="OlcPfkFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE6DE2064A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=android.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JTK6MuwlqrETuUm6N/+JAo+o9h4porPNwxPAmAXrtC8=; b=rAJQYWfDpabM82/hgG7MX4go+ XIqT3D10QnO739Ryg4ENmtPCEsKMExTcA07oNt2OikYjIXuMpuQMF7kSRdr2w8FPdZ8VufJrZk/yO mBRIBhoEbCTzD4lmdQiNhYsj0umy8TDM2Zpmpzs2ZGMzMRMHphPtHoVQ1rGYEFZasEjOsoxJSBx4e gsofUyoTFAz5zaYz58BHqas4TxZxriQIDZI70joFKx0uHallPG9S3VcHpMQVmvBBqLSresIVsTatN Ww/JW/4Iv0psfG84q3w599oDmoQuytWntw/OdWIcFh2M7KUipp+IWbav2WB0p2Gopk0nvDrvJdUPb guT2hesQA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2z7X-0003rz-86; Wed, 28 Aug 2019 14:40:23 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i2z7U-0003rL-6C for linux-mtd@lists.infradead.org; Wed, 28 Aug 2019 14:40:21 +0000 Received: by mail-pg1-x542.google.com with SMTP id o13so1571375pgp.12 for ; Wed, 28 Aug 2019 07:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=OlcPfkFh4eVXaPXXhh3cHvgBURsJe3iAt4+TEVeWmIUa8zc09e0oQ5MaZNlepG2vze B3r7RgJuWq9O6TIbswaNUIKe8aYWW+KNRgEXeCMfCvmELHUyftJPl7HAVt/DUWoqH+mt 7FiMUsP13ILyRxskXvgoEKTt4mcyDqpG+bZTW39pIt/5h+k8/JBgcB7qNM0XACYD7ale oWFmT2jC5R2Rv9fP9CO4NSXlbVjGTO4SWvbIfLdPsT4850CBsX7b6iyMaVYsWWgBm0EJ ydfkWGX0BboAbCSeR2RRikvC2V1c34KnlnNThn4oWcDh6RwGfO3sPku0/xiss22u0zC8 qA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=QZtXSZlT3kHH4Q8HALrag8fipdNBA+iUsxkR2uhspsNYRyVBdXj79IaZWxNjAwaA5k nlpu7AFOlmP8PK5YD75pn0U28zrGIsf3tDnj/7sLyvg2xSOIY3p+Mplvg0zd81F9qrU6 maQk9VxgkEJCKgZm/lZG/JpNc58P/doQG4EjDFU8phcx083wEZYYxDsYdsAlU64WKDs1 fz/WY/ocoZqpdrbE+WHXsYf/R212vj/h5AEUJlMyfpmRBiiE0fQm8z1wRFNn3Wa5cLoz Nm5SBuljOaMniAF3+EGHgeLkiy2ddPmTcwJxWrqUdDfsTaLMuGom68TRTj1KUHiUviGN pQXg== X-Gm-Message-State: APjAAAVi41ITDupO/YiAxOtqUrP3ICOp+rLtSLt4+iuaBQ4KVTqSGz+Z 3kJO4fNUsc95sl1c4xtHjtzdhw== X-Google-Smtp-Source: APXvYqxMi0WkPdC/TIWQ/rEP0W+6WEwgY/rp8ZhYjwRr9PMekyUrfkMqryPcx5ziGSRNx/jQnRs5oA== X-Received: by 2002:a17:90b:8ca:: with SMTP id ds10mr4474530pjb.139.1567003218534; Wed, 28 Aug 2019 07:40:18 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id t9sm7295641pgj.89.2019.08.28.07.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2019 07:40:17 -0700 (PDT) Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr To: Christoph Hellwig References: <20190827150544.151031-1-salyzyn@android.com> <20190828142423.GA1955@infradead.org> From: Mark Salyzyn Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> Date: Wed, 28 Aug 2019 07:40:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190828142423.GA1955@infradead.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190828_074020_260922_1F0810E7 X-CRM114-Status: GOOD ( 16.75 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , Hugh Dickins , Mike Marshall , James Morris , devel@lists.orangefs.org, Eric Van Hensbergen , Joel Becker , Anna Schumaker , Trond Myklebust , Mathieu Malaterre , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jan Kara , Casey Schaufler , Andrew Morton , Dave Kleikamp , linux-doc@vger.kernel.org, Jeff Layton , Chao Yu , Mimi Zohar , linux-cifs@vger.kernel.org, Paul Moore , "Darrick J. Wong" , Eric Sandeen , kernel-team@android.com, selinux@vger.kernel.org, Brian Foster , reiserfs-devel@vger.kernel.org, Tejun Heo , Jaegeuk Kim , Theodore Ts'o , Miklos Szeredi , linux-f2fs-devel@lists.sourceforge.net, Benjamin Coddington , linux-integrity@vger.kernel.org, Martin Brandenburg , Chris Mason , linux-mtd@lists.infradead.org, linux-afs@lists.infradead.org, Jonathan Corbet , Vyacheslav Dubeyko , Allison Henderson , Ilya Dryomov , linux-ext4@vger.kernel.org, Stephen Smalley , Serge Hallyn , Gao Xiang , Eric Paris , ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, Bob Peterson , linux-fsdevel@vger.kernel.org, linux-erofs@lists.ozlabs.org, "David S. Miller" , ocfs2-devel@oss.oracle.com, jfs-discussion@lists.sourceforge.net, Jan Kara , Eric Biggers , Dominique Martinet , Adrian Hunter , David Howells , Joseph Qi , Andreas Dilger , devel@driverdev.osuosl.org, "J. Bruce Fields" , Andreas Gruenbacher , Sage Weil , Richard Weinberger , Mark Fasheh , cluster-devel@redhat.com, Steve French , v9fs-developer@lists.sourceforge.net, Bharath Vedartham , Jann Horn , ecryptfs@vger.kernel.org, Josef Bacik , Dave Chinner , David Sterba , Artem Bityutskiy , netdev@vger.kernel.org, linux-unionfs@vger.kernel.org, stable@vger.kernel.org, Tyler Hicks , linux-security-module@vger.kernel.org, Phillip Lougher , David Woodhouse , linux-btrfs@vger.kernel.org, Alexander Viro Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gOC8yOC8xOSA3OjI0IEFNLCBDaHJpc3RvcGggSGVsbHdpZyB3cm90ZToKPiBPbiBUdWUsIEF1 ZyAyNywgMjAxOSBhdCAwODowNToxNUFNIC0wNzAwLCBNYXJrIFNhbHl6eW4gd3JvdGU6Cj4+IFJl cGxhY2UgYXJndW1lbnRzIGZvciBnZXQgYW5kIHNldCB4YXR0ciBtZXRob2RzLCBhbmQgX192ZnNf Z2V0eGF0dHIKPj4gYW5kIF9fdmZzX3NldGF4dHIgZnVuY3Rpb25zIHdpdGggYSByZWZlcmVuY2Ug dG8gdGhlIGZvbGxvd2luZyBub3cKPj4gY29tbW9uIGFyZ3VtZW50IHN0cnVjdHVyZToKPiBZaWtl cy4gIFRoYXQgbG9va3MgbGlrZSBhIG1lc3MuICBXaHkgY2FuJ3Qgd2UgcGFzcyBhIGtlcm5lbC1v bmx5Cj4gZmxhZyBpbiB0aGUgZXhpc3RpbmcgZmxhZ3MgZmllbGQgZm9yIOKCiz5zZXQgYW5kIGFk ZCBhIGZsYWdzIGZpZWxkCj4gdG8gLT5nZXQ/ICBQYXNzaW5nIG1ldGhvZHMgYnkgc3RydWN0dXJl IGFsd2F5cyB0ZW5kcyB0byBiZSBhIG1lc3MuCgpUaGlzIHdhcyBhIHJlc3BvbnNlIHRvIEdyZWdL SEAgY3JpdGljaXNtLCBhbiBlYXJsaWVyIHBhdGNoIHNldCBqdXN0IAphZGRlZCBhIGZsYWcgYXMg eW91IHN0YXRlZCB0byBnZXQgbWV0aG9kLCB1bnRpbCBjb21wbGFpbnRzIG9mIGFuIApleGNlc3Np dmVseSBsb25nIGFyZ3VtZW50IGxpc3QgYW5kIGZyYWdpbGl0eSB0byBhZGQgb3IgY2hhbmdlIG1v cmUgCmFyZ3VtZW50cy4KClNvIG1hbnkgd2F5cyBoYXZlIGJlZW4gdHJpZWQgdG8gc2tpbiB0aGlz IGNhdCAuLi4gdGhlIHJpc2sgd2FzIHRha2VuIHRvIApwbGVhc2Ugc29tZSwgYW5kIHdlIG5vdyBo YXZlIGh1bmRyZWRzIG9mIHN0YWtlaG9sZGVycywgd2hlbiB0aGUgZmlyc3QgCnBhdGNoIHNldCB3 YXMgbGVzcyB0aGFuIGEgZG96ZW4uIEEgcmVjaXBlIGZvciBmYWlsdXJlPwoKLS0gTWFyawoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eCBNVEQgZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1576FC3A5A1 for ; Wed, 28 Aug 2019 14:40:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BCDB922CED for ; Wed, 28 Aug 2019 14:40:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=android.com header.i=@android.com header.b="OlcPfkFh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCDB922CED Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=android.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 68DDD6B0005; Wed, 28 Aug 2019 10:40:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63E9B6B0006; Wed, 28 Aug 2019 10:40:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C1766B000E; Wed, 28 Aug 2019 10:40:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 288696B0005 for ; Wed, 28 Aug 2019 10:40:21 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id B64A9181AC9B4 for ; Wed, 28 Aug 2019 14:40:20 +0000 (UTC) X-FDA: 75872097000.20.cats22_20059d7c9513c X-HE-Tag: cats22_20059d7c9513c X-Filterd-Recvd-Size: 7303 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Aug 2019 14:40:19 +0000 (UTC) Received: by mail-pf1-f195.google.com with SMTP id q139so1842735pfc.13 for ; Wed, 28 Aug 2019 07:40:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=OlcPfkFh4eVXaPXXhh3cHvgBURsJe3iAt4+TEVeWmIUa8zc09e0oQ5MaZNlepG2vze B3r7RgJuWq9O6TIbswaNUIKe8aYWW+KNRgEXeCMfCvmELHUyftJPl7HAVt/DUWoqH+mt 7FiMUsP13ILyRxskXvgoEKTt4mcyDqpG+bZTW39pIt/5h+k8/JBgcB7qNM0XACYD7ale oWFmT2jC5R2Rv9fP9CO4NSXlbVjGTO4SWvbIfLdPsT4850CBsX7b6iyMaVYsWWgBm0EJ ydfkWGX0BboAbCSeR2RRikvC2V1c34KnlnNThn4oWcDh6RwGfO3sPku0/xiss22u0zC8 qA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=otBOnvzgcCfij7khznQb839FNBhUwDL3v2TXcjGpOzs=; b=bCQnIdprrkMc1uhpC9zUgtYElHJ6tj+HSV1Zt7VZYYrhAIPPC0pzBjxBFudgGs7M/+ LvS47GuUqGRVe0fLs00MO0r8JFx15mSCvuUxWSnSpNpBKz5qxKScdgN5SbzkFnykW0x3 NDgILp3jZRKxW0Wj2cnnvnKO0iRT8f8UKMML/7tL4jsS5zWZNe3Qf32mkGtgWG/B2pIc wU3eT51zdsYktnlX2dAbLJx/Y6o/wWpBD3kjZpFcHoBGkf2fqJSPHmAU5gyp4Sbf1ha8 uhQ/r1164jFN7rmBVv5utQxOK8hicbSA6SFlQzdmJ0Zr6EC6YjvLbwMhOA3xejt2GC2q J5GQ== X-Gm-Message-State: APjAAAVpb6FdPs7H6WU3QbBJDHwqHwXAD+Q8cjZhfSlm+YJOQq0LzOTa 8PEsZ39L7HjH8bcwEOQCXmRsgA== X-Google-Smtp-Source: APXvYqxMi0WkPdC/TIWQ/rEP0W+6WEwgY/rp8ZhYjwRr9PMekyUrfkMqryPcx5ziGSRNx/jQnRs5oA== X-Received: by 2002:a17:90b:8ca:: with SMTP id ds10mr4474530pjb.139.1567003218534; Wed, 28 Aug 2019 07:40:18 -0700 (PDT) Received: from nebulus.mtv.corp.google.com ([2620:15c:211:200:5404:91ba:59dc:9400]) by smtp.googlemail.com with ESMTPSA id t9sm7295641pgj.89.2019.08.28.07.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Aug 2019 07:40:17 -0700 (PDT) Subject: Re: [PATCH v8] Add flags option to get xattr method paired to __vfs_getxattr To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Jan Kara , Stephen Smalley , linux-security-module@vger.kernel.org, stable@vger.kernel.org, Jonathan Corbet , Gao Xiang , Chao Yu , Greg Kroah-Hartman , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , David Howells , Chris Mason , Josef Bacik , David Sterba , Jeff Layton , Sage Weil , Ilya Dryomov , Steve French , Tyler Hicks , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , David Woodhouse , Richard Weinberger , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Alexander Viro , Phillip Lougher , Artem Bityutskiy , Adrian Hunter , "Darrick J. Wong" , linux-xfs@vger.kernel.org, Hugh Dickins , "David S. Miller" , Serge Hallyn , James Morris , Mimi Zohar , Paul Moore , Eric Paris , Casey Schaufler , "J. Bruce Fields" , Eric Biggers , Benjamin Coddington , Andrew Morton , Mathieu Malaterre , Vyacheslav Dubeyko , Bharath Vedartham , Jann Horn , Dave Chinner , Allison Henderson , Brian Foster , Eric Sandeen , linux-doc@vger.kernel.org, linux-erofs@lists.ozlabs.org, devel@driverdev.osuosl.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, ecryptfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org References: <20190827150544.151031-1-salyzyn@android.com> <20190828142423.GA1955@infradead.org> From: Mark Salyzyn Message-ID: <5dd09a38-fffb-36f2-505b-be2ddf6bb750@android.com> Date: Wed, 28 Aug 2019 07:40:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190828142423.GA1955@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/28/19 7:24 AM, Christoph Hellwig wrote: > On Tue, Aug 27, 2019 at 08:05:15AM -0700, Mark Salyzyn wrote: >> Replace arguments for get and set xattr methods, and __vfs_getxattr >> and __vfs_setaxtr functions with a reference to the following now >> common argument structure: > Yikes. That looks like a mess. Why can't we pass a kernel-only > flag in the existing flags field for =E2=82=8B>set and add a flags fiel= d > to ->get? Passing methods by structure always tends to be a mess. This was a response to GregKH@ criticism, an earlier patch set just=20 added a flag as you stated to get method, until complaints of an=20 excessively long argument list and fragility to add or change more=20 arguments. So many ways have been tried to skin this cat ... the risk was taken to=20 please some, and we now have hundreds of stakeholders, when the first=20 patch set was less than a dozen. A recipe for failure? -- Mark