From: Muneendra Kumar M <muneendra.kumar@broadcom.com>
To: Hannes Reinecke <hare@suse.de>, linux-scsi@vger.kernel.org
Cc: jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com
Subject: RE: [PATCH v2 7/8] scsi_transport_fc: Added a new sysfs attribute port_state
Date: Thu, 1 Oct 2020 18:43:35 +0530 [thread overview]
Message-ID: <5deb6f1652c95d4e2a1b71c2e8e5681a@mail.gmail.com> (raw)
In-Reply-To: <89648ad7-d4d2-c684-16d5-6bd39398f046@suse.de>
[-- Attachment #1: Type: text/plain, Size: 767 bytes --]
Hi Hannes,
Thanks for the input.
>> @@ -2198,7 +2298,7 @@ fc_attach_transport(struct fc_function_template
>> *ft)
>> SETUP_STARGET_ATTRIBUTE_RD(node_name);
>> SETUP_STARGET_ATTRIBUTE_RD(port_name);
> SETUP_STARGET_ATTRIBUTE_RD(port_id);
>> -
>> + SETUP_PRIVATE_STARGET_ATTRIBUTE_RW(port_state);
>> BUG_ON(count > FC_STARGET_NUM_ATTRS);
>>
>> i->starget_attrs[count] = NULL;
>Why did you move it to be a 'starget' attribute?
>I would have thought it should be an 'rport' attribute, seeing that it's
>intrinsic to the fc transport class.
[Muneendra] Correct me if my understanding is wrong.
You want this to be part of /sys/class/fc_remote_ports/
rport-X\:Y-Z/port_state instead of
/sys/class/fc_transport/targetX\:Y\:Z/port_state
Regards,
Muneendra.
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4177 bytes --]
next prev parent reply other threads:[~2020-10-01 13:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 4:50 [PATCH v2 0/8] scsi: Support to handle Intermittent errors Muneendra
2020-09-28 4:50 ` [PATCH v2 1/8] scsi: Added a new definition in scsi_cmnd.h Muneendra
2020-09-30 9:17 ` Hannes Reinecke
2020-09-28 4:50 ` [PATCH v2 2/8] scsi: Added a new error code in scsi.h Muneendra
2020-09-30 9:17 ` Hannes Reinecke
2020-09-28 4:50 ` [PATCH v2 3/8] scsi: Clear state bit SCMD_NORETRIES_ABORT of scsi_cmd before start request Muneendra
2020-09-30 9:19 ` Hannes Reinecke
2020-09-28 4:50 ` [PATCH v2 4/8] scsi: No retries on abort success Muneendra
2020-09-30 9:27 ` Hannes Reinecke
2020-09-28 4:50 ` [PATCH v2 5/8] scsi: Added routine to set/clear SCMD_NORETRIES_ABORT bit for outstanding io on scsi_dev Muneendra
2020-09-30 9:26 ` Hannes Reinecke
2020-09-28 4:50 ` [PATCH v2 6/8] scsi_transport_fc: Added a new rport state FC_PORTSTATE_MARGINAL Muneendra
2020-09-30 9:30 ` Hannes Reinecke
2020-09-28 4:50 ` [PATCH v2 7/8] scsi_transport_fc: Added a new sysfs attribute port_state Muneendra
2020-09-30 9:33 ` Hannes Reinecke
2020-10-01 13:13 ` Muneendra Kumar M [this message]
2020-10-05 9:18 ` Muneendra Kumar M
2020-10-05 9:29 ` Hannes Reinecke
2020-10-07 7:14 ` Muneendra Kumar M
2020-10-02 16:26 ` Benjamin Block
2020-10-05 6:49 ` Hannes Reinecke
2020-10-05 8:41 ` Benjamin Block
2020-09-28 4:50 ` [PATCH v2 8/8] lpfc: Added support to handle marginal state Muneendra
2020-09-30 9:36 ` Hannes Reinecke
2020-09-30 11:33 ` Muneendra Kumar M
2020-09-30 11:50 ` Hannes Reinecke
2020-10-01 8:59 ` Muneendra Kumar M
2020-10-02 17:01 ` [PATCH v2 0/8] scsi: Support to handle Intermittent errors Mike Christie
2020-10-02 17:27 ` James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5deb6f1652c95d4e2a1b71c2e8e5681a@mail.gmail.com \
--to=muneendra.kumar@broadcom.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=jsmart2021@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mkumar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.