From: Stephen Boyd <swboyd@chromium.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Douglas Anderson <dianders@chromium.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kiran Gunda <kgunda@codeaurora.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
mka@chromium.org, Sandeep Maheswaram <sanm@codeaurora.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Maulik Shah <mkshah@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 6/7] arm64: dts: qcom: sc7180: Avoid "phy" for USB QMP PHY wrapper
Date: Thu, 12 Dec 2019 13:59:52 -0800 [thread overview]
Message-ID: <5df2b859.1c69fb81.3a87e.5ace@mx.google.com> (raw)
In-Reply-To: <20191212113540.6.Iec10b23bb000186b36b8bacfb6789d8233de04a7@changeid>
Quoting Douglas Anderson (2019-12-12 11:35:42)
> The bindings for the QMP PHY are truly strange. I believe (?) that
> they may have originated because with PCIe each lane is treated as a
> different PHY and the same PHY driver is used for a whole bunch of
> things (incluidng PCIe).
>
> In any case, now that we have "make dtbs_check", we find that having
> the outer node named "phy" triggers the
> "schemas/phy/phy-provider.yaml" schema, yelling about:
>
> phy@88e9000: '#phy-cells' is a required property
>
> Let's call the outer node the "phy-wrapper" and the inner node the
> "phy" to make dtbs_check happy.
>
> Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Would be good to add phy-wrapper to possible node names in the DT spec
too.
next prev parent reply other threads:[~2019-12-12 21:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 19:35 [PATCH 0/7] arm64: dts: sc7180: Make dtbs_check mostly happy Douglas Anderson
2019-12-12 19:35 ` [PATCH 1/7] arm64: dts: qcom: sc7180: Add SoC name to compatible Douglas Anderson
2019-12-12 21:55 ` Stephen Boyd
2019-12-12 19:35 ` [PATCH 2/7] arm64: dts: qcom: sc7180: Rename gic-its node to msi-controller Douglas Anderson
2019-12-12 21:56 ` Stephen Boyd
2019-12-17 6:27 ` Doug Anderson
2019-12-12 19:35 ` [PATCH 3/7] arm64: dts: qcom: sc7180: Add "#clock-cells" property to usb_1_ssphy Douglas Anderson
2019-12-12 21:56 ` Stephen Boyd
2019-12-12 19:35 ` [PATCH 4/7] arm64: dts: qcom: pm6150: Remove macro from unit name of adc-chan Douglas Anderson
2019-12-12 21:56 ` Stephen Boyd
2019-12-12 19:35 ` [PATCH 5/7] arm64: dts: qcom: sc7180: Avoid "memory" for cmd-db reserved-memory node Douglas Anderson
2019-12-12 22:00 ` Stephen Boyd
2019-12-12 23:18 ` Bjorn Andersson
2019-12-12 19:35 ` [PATCH 6/7] arm64: dts: qcom: sc7180: Avoid "phy" for USB QMP PHY wrapper Douglas Anderson
2019-12-12 21:59 ` Stephen Boyd [this message]
2019-12-12 19:35 ` [PATCH 7/7] arm64: dts: qcom: sc7180: Use 'ranges' in arm,armv7-timer-mem node Douglas Anderson
2019-12-12 21:55 ` Stephen Boyd
2019-12-17 6:14 ` Doug Anderson
2019-12-12 23:21 ` [PATCH 0/7] arm64: dts: sc7180: Make dtbs_check mostly happy Bjorn Andersson
2019-12-13 4:06 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5df2b859.1c69fb81.3a87e.5ace@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sanm@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.