All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Akash Asthana <akashast@codeaurora.org>,
	agross@kernel.org, bjorn.andersson@linaro.org,
	mark.rutland@arm.com, robh+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, mgautam@codeaurora.org,
	Akash Asthana <akashast@codeaurora.org>
Subject: Re: [PATCH] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML
Date: Mon, 16 Dec 2019 08:42:33 -0800	[thread overview]
Message-ID: <5df7b3fa.1c69fb81.fa080.21a7@mx.google.com> (raw)
In-Reply-To: <1576488351-22396-1-git-send-email-akashast@codeaurora.org>

Quoting Akash Asthana (2019-12-16 01:25:51)
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> new file mode 100644
> index 0000000..2c3b911
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> @@ -0,0 +1,196 @@
[...]
> +
> +  "serial@[0-9]+$":
> +    type: object
> +    description: GENI Serial Engine based UART Controller.
> +
> +    properties:
> +      compatible:
> +        enum:
> +          - qcom,geni-uart
> +          - qcom,geni-debug-uart
> +
> +      reg:
> +        description: GENI Serial Engine register address and length.
> +
> +      interrupts:
> +        description: Contains UART core and wakeup interrupts for wakeup
> +                     capable UART devices. We configure wakeup interrupt
> +                     on UART RX line using TLMM interrupt controller.
> +        maxItems: 2

Shouldn't there be a minItems: 1 here? And then you should specify the order?
Presumably something like

	interrupts:
	  minItems: 1
	  maxItems: 2
	  items:
	    - description: UART core irq
	    - description: Wakeup irq (RX GPIO)


  reply	other threads:[~2019-12-16 16:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16  9:25 [PATCH] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML Akash Asthana
2019-12-16 16:42 ` Stephen Boyd [this message]
2019-12-17  9:49   ` Akash Asthana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5df7b3fa.1c69fb81.fa080.21a7@mx.google.com \
    --to=swboyd@chromium.org \
    --cc=agross@kernel.org \
    --cc=akashast@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mgautam@codeaurora.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.