From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1736C77B73 for ; Tue, 2 May 2023 18:30:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To:Subject :MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h5KPY5V6nk7zcKsejg06UhQdXAoI4rxf/Iee2Sdzh0s=; b=gxWyuCy8XMuKTe xKVIWPqqzQiIO5Piu4XHyL8WBdQstOBvn2l2PJqL2DLml2jNTxfUGcoQw/97tkzmZpDMxFHjpiJWC 7fXTcFHQPyKfwmxIHwZGBzR7TmkAgN1blHA0pC4z2z4iXRY2r52hOkWanPzf9KHmvSUbQqmIiN0sH OkQI/Ged8IoIM8xFP5vRqRSZ5bjc4ys9AK0YMml21rrLwMT2+8MmZFCaWlWVs/yJ0Z0kXAnXuSDkO E+P/SkX5/3XTTXQ2WEbuCtnvUPczBacNApTM0opegtvjCm5bR1r8ND6xSqPo3rLThu6zEkBkJnlxy IOP/f2WXIV7iHOX08ZhQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ptulx-002MxW-0h; Tue, 02 May 2023 18:30:45 +0000 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ptult-002Mvr-2A; Tue, 02 May 2023 18:30:42 +0000 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-3ef2f81a96cso42219351cf.0; Tue, 02 May 2023 11:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683052239; x=1685644239; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h5KPY5V6nk7zcKsejg06UhQdXAoI4rxf/Iee2Sdzh0s=; b=huvapiP1o/a5ROF+RrV3LRzVcl8VvchFqlWxmMyY0NsJlusefbB0XvV8hgh3gac6fo fqGq1g63D/En+ZAO6WAdGfLrFNH9C8RkAXnoKz2h9frRYIYjUPjRKoSrewvawZIe/GG/ ywI+pevRMWLaUqjPPy8faM0HkoJhrfxh3gDXhnwhl8jh99aaADOFeVogqj308IH7+KGj 1tB3pTQayl8TKnvnR1TsUmh88QYiKArDHl+PDtBEJl5XwAdv5GIkXirh1H64z4cEEal5 zCd8qPqpJ3raiW4C26zqSdD9DXeozCbVKNWuSNT+FmQiS7tddDCkih+UGCBgft+8QE/b Acvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683052239; x=1685644239; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h5KPY5V6nk7zcKsejg06UhQdXAoI4rxf/Iee2Sdzh0s=; b=JBPluCWtNlIyFzJTwOaBkztwgqh/LyEh/Nl9CNmVg2+DyKIIvUWx98RlWee3KAF6jM esmrIfhA3CbX9EVF+3yTqxgDPsbsUzLyJTv1dHGbQnVXnSkLuVRP185znTiyHZAsAfEb uh8SH1EOXNPdr0lZCYPX3uaeFrY9zCpwV7kmF09R/7hl4omTmGWyideI/UJQzbhUR4Og 8/agymeePrrTsBhniyap5ae0K7Rm587uhZx3OQsEYgEw37LEvpIF98kzDTgbayU36CW+ bajxRULYsXw6FfDrdRMIv/TL7olpMdbqyV4yKMFSfl2EHkZxWkr1Hjug+1Vol9mRECNg 6IhQ== X-Gm-Message-State: AC+VfDz2h57FMaISCk2wqLlrWKZdhsr4SDFTgqwf/4sn8zAKaFYWz6lF NCI+CyXbDoq/GF6Y6ruH5JA= X-Google-Smtp-Source: ACHHUZ4cr3QjY4+z+dN7SsjEHvHkOPquQGdAxCy3mXR0QlFgJ/dhUGxFG6VteZXVkN2h21ws6YF9/A== X-Received: by 2002:ac8:5a8b:0:b0:3ef:327d:ac78 with SMTP id c11-20020ac85a8b000000b003ef327dac78mr25703066qtc.36.1683052239136; Tue, 02 May 2023 11:30:39 -0700 (PDT) Received: from [10.69.71.131] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id c136-20020ae9ed8e000000b007468b183a65sm9918474qkg.30.2023.05.02.11.30.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 11:30:38 -0700 (PDT) Message-ID: <5e00b4c7-8d3f-e1b2-4359-5ee8fdf92ea9@gmail.com> Date: Tue, 2 May 2023 11:30:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH net 2/2] net: dsa: mt7530: fix network connectivity with multiple CPU ports Content-Language: en-US To: arinc9.unal@gmail.com, Sean Wang , Landen Chao , DENG Qingfang , Daniel Golle , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= References: <20230501121538.57968-1-arinc.unal@arinc9.com> <20230501121538.57968-2-arinc.unal@arinc9.com> From: Florian Fainelli In-Reply-To: <20230501121538.57968-2-arinc.unal@arinc9.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230502_113041_707443_C64D5008 X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: erkin.bozoglu@xeront.com, Richard van Schagen , linux-kernel@vger.kernel.org, Richard van Schagen , =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , linux-mediatek@lists.infradead.org, Bartel Eerdekens , netdev@vger.kernel.org, mithat.guner@xeront.com, linux-arm-kernel@lists.infradead.org Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 5/1/2023 5:15 AM, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > On mt753x_cpu_port_enable() there's code that enables flooding for the CPU > port only. Since mt753x_cpu_port_enable() runs twice when both CPU ports > are enabled, port 6 becomes the only port to forward the frames to. But > port 5 is the active port, so no frames received from the user ports will > be forwarded to port 5 which breaks network connectivity. > > Every bit of the BC_FFP, UNM_FFP, and UNU_FFP bits represents a port. Fix > this issue by setting the bit that corresponds to the CPU port without > overwriting the other bits. > > Clear the bits beforehand only for the MT7531 switch. According to the > documents MT7621 Giga Switch Programming Guide v0.3 and MT7531 Reference > Manual for Development Board v1.0, after reset, the BC_FFP, UNM_FFP, and > UNU_FFP bits are set to 1 for MT7531, 0 for MT7530. > > Tested-by: Arınç ÜNAL This tag is implied by your Signed-off-by tag. No Fixes tag for this one? -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21221C77B73 for ; Tue, 2 May 2023 18:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PdeBWggASKgYdHIS8brjaAT7GdR8l6MOSP8ANqXmb6g=; b=bBh0PmeGkNXjcA eXIr7W61Ov1jY8tsW+27w2FwgLzNmRcD0wPvpiFGP4rgqjGYXUcFvmy9syRfpH6qJYRTAxB+jzlPO A/xUYKf8/Sc6q/7c6Y/x16qTM0Yo/U9vSVgnG8qUBfrmM2mmXtqVSaBdBMVdKXIrYBkNOLr88MRTl aTtYzVG8VnhDw2l5P63GzXSfYop9z0amvudimhijHXNcObIbexyxvzMdgvHHa/3J2XDPmabNP3Cq1 GXafe719mnit2j1JZgJ8N+oYRV+y5gRTvm1WvHgJ0Xey7CqtOYlYH5bS0ifjeDOTiMXu/7wCJXJer 7aFJhZhUb/ii1DzmjEXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ptulw-002MxA-15; Tue, 02 May 2023 18:30:44 +0000 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ptult-002Mvr-2A; Tue, 02 May 2023 18:30:42 +0000 Received: by mail-qt1-x831.google.com with SMTP id d75a77b69052e-3ef2f81a96cso42219351cf.0; Tue, 02 May 2023 11:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683052239; x=1685644239; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h5KPY5V6nk7zcKsejg06UhQdXAoI4rxf/Iee2Sdzh0s=; b=huvapiP1o/a5ROF+RrV3LRzVcl8VvchFqlWxmMyY0NsJlusefbB0XvV8hgh3gac6fo fqGq1g63D/En+ZAO6WAdGfLrFNH9C8RkAXnoKz2h9frRYIYjUPjRKoSrewvawZIe/GG/ ywI+pevRMWLaUqjPPy8faM0HkoJhrfxh3gDXhnwhl8jh99aaADOFeVogqj308IH7+KGj 1tB3pTQayl8TKnvnR1TsUmh88QYiKArDHl+PDtBEJl5XwAdv5GIkXirh1H64z4cEEal5 zCd8qPqpJ3raiW4C26zqSdD9DXeozCbVKNWuSNT+FmQiS7tddDCkih+UGCBgft+8QE/b Acvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683052239; x=1685644239; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h5KPY5V6nk7zcKsejg06UhQdXAoI4rxf/Iee2Sdzh0s=; b=JBPluCWtNlIyFzJTwOaBkztwgqh/LyEh/Nl9CNmVg2+DyKIIvUWx98RlWee3KAF6jM esmrIfhA3CbX9EVF+3yTqxgDPsbsUzLyJTv1dHGbQnVXnSkLuVRP185znTiyHZAsAfEb uh8SH1EOXNPdr0lZCYPX3uaeFrY9zCpwV7kmF09R/7hl4omTmGWyideI/UJQzbhUR4Og 8/agymeePrrTsBhniyap5ae0K7Rm587uhZx3OQsEYgEw37LEvpIF98kzDTgbayU36CW+ bajxRULYsXw6FfDrdRMIv/TL7olpMdbqyV4yKMFSfl2EHkZxWkr1Hjug+1Vol9mRECNg 6IhQ== X-Gm-Message-State: AC+VfDz2h57FMaISCk2wqLlrWKZdhsr4SDFTgqwf/4sn8zAKaFYWz6lF NCI+CyXbDoq/GF6Y6ruH5JA= X-Google-Smtp-Source: ACHHUZ4cr3QjY4+z+dN7SsjEHvHkOPquQGdAxCy3mXR0QlFgJ/dhUGxFG6VteZXVkN2h21ws6YF9/A== X-Received: by 2002:ac8:5a8b:0:b0:3ef:327d:ac78 with SMTP id c11-20020ac85a8b000000b003ef327dac78mr25703066qtc.36.1683052239136; Tue, 02 May 2023 11:30:39 -0700 (PDT) Received: from [10.69.71.131] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id c136-20020ae9ed8e000000b007468b183a65sm9918474qkg.30.2023.05.02.11.30.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 11:30:38 -0700 (PDT) Message-ID: <5e00b4c7-8d3f-e1b2-4359-5ee8fdf92ea9@gmail.com> Date: Tue, 2 May 2023 11:30:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH net 2/2] net: dsa: mt7530: fix network connectivity with multiple CPU ports Content-Language: en-US To: arinc9.unal@gmail.com, Sean Wang , Landen Chao , DENG Qingfang , Daniel Golle , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= Cc: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Richard van Schagen , Richard van Schagen , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230501121538.57968-1-arinc.unal@arinc9.com> <20230501121538.57968-2-arinc.unal@arinc9.com> From: Florian Fainelli In-Reply-To: <20230501121538.57968-2-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230502_113041_707443_C64D5008 X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA1LzEvMjAyMyA1OjE1IEFNLCBhcmluYzkudW5hbEBnbWFpbC5jb20gd3JvdGU6Cj4gRnJv bTogQXLEsW7DpyDDnE5BTCA8YXJpbmMudW5hbEBhcmluYzkuY29tPgo+IAo+IE9uIG10NzUzeF9j cHVfcG9ydF9lbmFibGUoKSB0aGVyZSdzIGNvZGUgdGhhdCBlbmFibGVzIGZsb29kaW5nIGZvciB0 aGUgQ1BVCj4gcG9ydCBvbmx5LiBTaW5jZSBtdDc1M3hfY3B1X3BvcnRfZW5hYmxlKCkgcnVucyB0 d2ljZSB3aGVuIGJvdGggQ1BVIHBvcnRzCj4gYXJlIGVuYWJsZWQsIHBvcnQgNiBiZWNvbWVzIHRo ZSBvbmx5IHBvcnQgdG8gZm9yd2FyZCB0aGUgZnJhbWVzIHRvLiBCdXQKPiBwb3J0IDUgaXMgdGhl IGFjdGl2ZSBwb3J0LCBzbyBubyBmcmFtZXMgcmVjZWl2ZWQgZnJvbSB0aGUgdXNlciBwb3J0cyB3 aWxsCj4gYmUgZm9yd2FyZGVkIHRvIHBvcnQgNSB3aGljaCBicmVha3MgbmV0d29yayBjb25uZWN0 aXZpdHkuCj4gCj4gRXZlcnkgYml0IG9mIHRoZSBCQ19GRlAsIFVOTV9GRlAsIGFuZCBVTlVfRkZQ IGJpdHMgcmVwcmVzZW50cyBhIHBvcnQuIEZpeAo+IHRoaXMgaXNzdWUgYnkgc2V0dGluZyB0aGUg Yml0IHRoYXQgY29ycmVzcG9uZHMgdG8gdGhlIENQVSBwb3J0IHdpdGhvdXQKPiBvdmVyd3JpdGlu ZyB0aGUgb3RoZXIgYml0cy4KPiAKPiBDbGVhciB0aGUgYml0cyBiZWZvcmVoYW5kIG9ubHkgZm9y IHRoZSBNVDc1MzEgc3dpdGNoLiBBY2NvcmRpbmcgdG8gdGhlCj4gZG9jdW1lbnRzIE1UNzYyMSBH aWdhIFN3aXRjaCBQcm9ncmFtbWluZyBHdWlkZSB2MC4zIGFuZCBNVDc1MzEgUmVmZXJlbmNlCj4g TWFudWFsIGZvciBEZXZlbG9wbWVudCBCb2FyZCB2MS4wLCBhZnRlciByZXNldCwgdGhlIEJDX0ZG UCwgVU5NX0ZGUCwgYW5kCj4gVU5VX0ZGUCBiaXRzIGFyZSBzZXQgdG8gMSBmb3IgTVQ3NTMxLCAw IGZvciBNVDc1MzAuCj4gCj4gVGVzdGVkLWJ5OiBBcsSxbsOnIMOcTkFMIDxhcmluYy51bmFsQGFy aW5jOS5jb20+CgpUaGlzIHRhZyBpcyBpbXBsaWVkIGJ5IHlvdXIgU2lnbmVkLW9mZi1ieSB0YWcu IE5vIEZpeGVzIHRhZyBmb3IgdGhpcyBvbmU/Ci0tIApGbG9yaWFuCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EE75C7EE22 for ; Tue, 2 May 2023 18:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234400AbjEBSao (ORCPT ); Tue, 2 May 2023 14:30:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234323AbjEBSal (ORCPT ); Tue, 2 May 2023 14:30:41 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1417D172E; Tue, 2 May 2023 11:30:40 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-3ef32014101so42033351cf.3; Tue, 02 May 2023 11:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683052239; x=1685644239; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h5KPY5V6nk7zcKsejg06UhQdXAoI4rxf/Iee2Sdzh0s=; b=huvapiP1o/a5ROF+RrV3LRzVcl8VvchFqlWxmMyY0NsJlusefbB0XvV8hgh3gac6fo fqGq1g63D/En+ZAO6WAdGfLrFNH9C8RkAXnoKz2h9frRYIYjUPjRKoSrewvawZIe/GG/ ywI+pevRMWLaUqjPPy8faM0HkoJhrfxh3gDXhnwhl8jh99aaADOFeVogqj308IH7+KGj 1tB3pTQayl8TKnvnR1TsUmh88QYiKArDHl+PDtBEJl5XwAdv5GIkXirh1H64z4cEEal5 zCd8qPqpJ3raiW4C26zqSdD9DXeozCbVKNWuSNT+FmQiS7tddDCkih+UGCBgft+8QE/b Acvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683052239; x=1685644239; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h5KPY5V6nk7zcKsejg06UhQdXAoI4rxf/Iee2Sdzh0s=; b=h2te7cM2mUmc2WofklWcEQNEbMJRDTw6GqYVKIAyBh3xNHchLmQZ+LyVOtU29sf1fv Al0DAIzfBZc5l+mHxISTZ4XvcNlSVyMaot7LMRpNrVBadbIDosmpdXq88ZddYdofiKDC v75o/Rox8VD0fd0zIp9u27RWaJzsws8XdaSHS859tdniBqENyYy/2hcsxnrzfK9pAQXo 0fy3yYV+jnYtWRD4HBdYRilLNCwAwYe4rX1bidZICW7mnnam6SjnUF8faSiuVS5x4Moi nK2Fg3x+Q31LGDK7uLtGzd2HBJ2dX6FXCwkEVGVhP0ml4bcIkwHUhhbtBe5dn7TV42xM uWRQ== X-Gm-Message-State: AC+VfDy8cOxvgFaydqffPOWdELCpm1pYrjPBvN5HI8jtjkyGKwzHhLRM yYr5eThYaRzV7w5EIZSHXAc= X-Google-Smtp-Source: ACHHUZ4cr3QjY4+z+dN7SsjEHvHkOPquQGdAxCy3mXR0QlFgJ/dhUGxFG6VteZXVkN2h21ws6YF9/A== X-Received: by 2002:ac8:5a8b:0:b0:3ef:327d:ac78 with SMTP id c11-20020ac85a8b000000b003ef327dac78mr25703066qtc.36.1683052239136; Tue, 02 May 2023 11:30:39 -0700 (PDT) Received: from [10.69.71.131] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id c136-20020ae9ed8e000000b007468b183a65sm9918474qkg.30.2023.05.02.11.30.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 11:30:38 -0700 (PDT) Message-ID: <5e00b4c7-8d3f-e1b2-4359-5ee8fdf92ea9@gmail.com> Date: Tue, 2 May 2023 11:30:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH net 2/2] net: dsa: mt7530: fix network connectivity with multiple CPU ports Content-Language: en-US To: arinc9.unal@gmail.com, Sean Wang , Landen Chao , DENG Qingfang , Daniel Golle , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= Cc: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= , Richard van Schagen , Richard van Schagen , Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230501121538.57968-1-arinc.unal@arinc9.com> <20230501121538.57968-2-arinc.unal@arinc9.com> From: Florian Fainelli In-Reply-To: <20230501121538.57968-2-arinc.unal@arinc9.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/1/2023 5:15 AM, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > On mt753x_cpu_port_enable() there's code that enables flooding for the CPU > port only. Since mt753x_cpu_port_enable() runs twice when both CPU ports > are enabled, port 6 becomes the only port to forward the frames to. But > port 5 is the active port, so no frames received from the user ports will > be forwarded to port 5 which breaks network connectivity. > > Every bit of the BC_FFP, UNM_FFP, and UNU_FFP bits represents a port. Fix > this issue by setting the bit that corresponds to the CPU port without > overwriting the other bits. > > Clear the bits beforehand only for the MT7531 switch. According to the > documents MT7621 Giga Switch Programming Guide v0.3 and MT7531 Reference > Manual for Development Board v1.0, after reset, the BC_FFP, UNM_FFP, and > UNU_FFP bits are set to 1 for MT7531, 0 for MT7530. > > Tested-by: Arınç ÜNAL This tag is implied by your Signed-off-by tag. No Fixes tag for this one? -- Florian