From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77A613D71; Thu, 10 Aug 2023 09:52:27 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58D7C211B; Thu, 10 Aug 2023 02:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691661146; x=1723197146; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0QXCdnIeDvNVhe3zDIXfKLHqjJhkR646hmb6U9XbWSc=; b=Pjlp4NDNGMDyCcIa4mvhaYddipIjoLKEoU5aZ743tqoSdWpB/EFe93YC PW4KbQoE49DrQauDTH5Zm3y530T+5hZs219c+a0Ped1oK/LL8NUi4hRcw Fnv4C39ySNuZo1tD5ygw23FBfajZpb2uxT4Yu48+JWMComWWWKV67RvpJ AQbEb8N9WYR3jjAYDVqoF1HwpyNRuRXHkIxBB/1AdPzEuOtVGO0GfU8/r cU4Rat2tPxkc93+R6QRwyrVufvSbI+MI+rgowaolTB+5T1TBvy5ZA3Mgl LxhgiU0eljl8u1Tx9DcVp6oPhuu2IZKcxRbbyp8R0obCcgQzcB9zDTUnj Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="368810604" X-IronPort-AV: E=Sophos;i="6.01,161,1684825200"; d="scan'208";a="368810604" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 02:52:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="732142399" X-IronPort-AV: E=Sophos;i="6.01,161,1684825200"; d="scan'208";a="732142399" Received: from choongyo-mobl.gar.corp.intel.com (HELO [10.213.42.193]) ([10.213.42.193]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 02:52:13 -0700 Message-ID: <5e113258-7cb4-e503-5009-e46cd3aa5bee@linux.intel.com> Date: Thu, 10 Aug 2023 17:52:10 +0800 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH net-next v2 0/5] TSN auto negotiation between 1G and 2.5G Content-Language: en-US To: Andrew Lunn Cc: Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross , Jose Abreu , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?Q?Marek_Beh=c3=ban?= , Jean Delvare , Guenter Roeck , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Philipp Zabel , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Wong Vee Khee , Jon Hunter , Jesse Brandeburg , Revanth Kumar Uppala , Shenwei Wang , Andrey Konovalov , Jochen Henneberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, bpf@vger.kernel.org, Voon Wei Feng , Tan Tee Min , Michael Sit Wei Hong , Lai Peter Jun Ann References: <20230804084527.2082302-1-yong.liang.choong@linux.intel.com> <5bd05ba2-fd88-4e5c-baed-9971ff917484@lunn.ch> From: Choong Yong Liang In-Reply-To: <5bd05ba2-fd88-4e5c-baed-9971ff917484@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 4/8/2023 8:04 pm, Andrew Lunn wrote: > On Fri, Aug 04, 2023 at 04:45:22PM +0800, Choong Yong Liang wrote: >> Intel platforms’ integrated Gigabit Ethernet controllers support >> 2.5Gbps mode statically using BIOS programming. In the current >> implementation, the BIOS menu provides an option to select between >> 10/100/1000Mbps and 2.5Gbps modes. Based on the selection, the BIOS >> programs the Phase Lock Loop (PLL) registers. The BIOS also read the >> TSN lane registers from Flexible I/O Adapter (FIA) block and provided >> 10/100/1000Mbps/2.5Gbps information to the stmmac driver. But >> auto-negotiation between 10/100/1000Mbps and 2.5Gbps is not allowed. >> The new proposal is to support auto-negotiation between 10/100/1000Mbps >> and 2.5Gbps . Auto-negotiation between 10, 100, 1000Mbps will use >> in-band auto negotiation. Auto-negotiation between 10/100/1000Mbps and >> 2.5Gbps will work as the following proposed flow, the stmmac driver reads >> the PHY link status registers then identifies the negotiated speed. >> Based on the speed stmmac driver will identify TSN lane registers from >> FIA then send IPC command to the Power Management controller (PMC) >> through PMC driver/API. PMC will act as a proxy to programs the >> PLL registers. > > Have you considered using out of band for all link modes? You might > end up with a cleaner architecture, and not need any phylink/phylib > hacks. > > Andrew Hi Andrew, Thank you for your feedback. I will study the feasibility of the out-of-band (OOB) approach. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06E43C001DB for ; Thu, 10 Aug 2023 09:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jg+ZvZFy40MwOPqzQnbSQG/KL7VdfH9xOE40ppOTBnw=; b=tf3E8PfxKW47wP ZB5ROs1MnwQT9Sh/gGD3RVlQLl+DjQtugFAJaBGJea+mdGFJkibOUFOFAOY/reoWprHL0/oxJIiVT aiu5eR9ONBgdCpxAgDhW/ndcg5BIVxN/QYeoHU9928uE6oymsPvMfYWf90yfOpZQH1ewyrB0WeV1j dwXiJWeg0gossOrBIUtp5C5IGsJs+hB9lSxVZRQgXAQB1IoqASjfKqQ2YA6mLJHTkfAgy0LNqBG44 oighAwUtItVV01IcvVMl9bkBLxnrP7+BBnFgzweaI+VTp5DN9kZv2Fme6E054DlvD8dXIa6R8pbY9 Dyrq1JSeTj/LJPqFEHWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qU2LG-0071TF-2G; Thu, 10 Aug 2023 09:52:30 +0000 Received: from mgamail.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qU2LD-0071SN-2q for linux-arm-kernel@lists.infradead.org; Thu, 10 Aug 2023 09:52:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691661147; x=1723197147; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0QXCdnIeDvNVhe3zDIXfKLHqjJhkR646hmb6U9XbWSc=; b=El2w7YcplTexU6pWFqyKjlOipJGpjgnchQbfF+jCX5XewfnDdgTRgt3r 4CXSE77+smYS60bJJ2ihN+ASc04rD0fMMZJcE1q9DKfe9lgIIImL34/Du Ad7/LTrTsGffpTS3/9nA6APoZoaedfuKMfpDloUPpnZZVi+EYDD7w+DiJ MALQZ05TF+onpllFP21Yy5iBI3IfyuJBEx7r1FOrrhhMd85Fi0KfEuPRV QklnZ2H/of9CMPPtxNx/DgVkXkaRKPnzBAETAOrnTz0upwGhN3mPB1kp5 wn40KM4l43YNf5/qajczwvnjnG84fiRAFwymEyK9O6bIot42Cf+y0boJA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="368810607" X-IronPort-AV: E=Sophos;i="6.01,161,1684825200"; d="scan'208";a="368810607" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 02:52:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10797"; a="732142399" X-IronPort-AV: E=Sophos;i="6.01,161,1684825200"; d="scan'208";a="732142399" Received: from choongyo-mobl.gar.corp.intel.com (HELO [10.213.42.193]) ([10.213.42.193]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2023 02:52:13 -0700 Message-ID: <5e113258-7cb4-e503-5009-e46cd3aa5bee@linux.intel.com> Date: Thu, 10 Aug 2023 17:52:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH net-next v2 0/5] TSN auto negotiation between 1G and 2.5G Content-Language: en-US To: Andrew Lunn Cc: Rajneesh Bhardwaj , David E Box , Hans de Goede , Mark Gross , Jose Abreu , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?Q?Marek_Beh=c3=ban?= , Jean Delvare , Guenter Roeck , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Philipp Zabel , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Wong Vee Khee , Jon Hunter , Jesse Brandeburg , Revanth Kumar Uppala , Shenwei Wang , Andrey Konovalov , Jochen Henneberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org, bpf@vger.kernel.org, Voon Wei Feng , Tan Tee Min , Michael Sit Wei Hong , Lai Peter Jun Ann References: <20230804084527.2082302-1-yong.liang.choong@linux.intel.com> <5bd05ba2-fd88-4e5c-baed-9971ff917484@lunn.ch> From: Choong Yong Liang In-Reply-To: <5bd05ba2-fd88-4e5c-baed-9971ff917484@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230810_025227_985586_40776839 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiA0LzgvMjAyMyA4OjA0IHBtLCBBbmRyZXcgTHVubiB3cm90ZToKPiBPbiBGcmksIEF1ZyAw NCwgMjAyMyBhdCAwNDo0NToyMlBNICswODAwLCBDaG9vbmcgWW9uZyBMaWFuZyB3cm90ZToKPj4g SW50ZWwgcGxhdGZvcm1z4oCZIGludGVncmF0ZWQgR2lnYWJpdCBFdGhlcm5ldCBjb250cm9sbGVy cyBzdXBwb3J0Cj4+IDIuNUdicHMgbW9kZSBzdGF0aWNhbGx5IHVzaW5nIEJJT1MgcHJvZ3JhbW1p bmcuIEluIHRoZSBjdXJyZW50Cj4+IGltcGxlbWVudGF0aW9uLCB0aGUgQklPUyBtZW51IHByb3Zp ZGVzIGFuIG9wdGlvbiB0byBzZWxlY3QgYmV0d2Vlbgo+PiAxMC8xMDAvMTAwME1icHMgYW5kIDIu NUdicHMgbW9kZXMuIEJhc2VkIG9uIHRoZSBzZWxlY3Rpb24sIHRoZSBCSU9TCj4+IHByb2dyYW1z IHRoZSBQaGFzZSBMb2NrIExvb3AgKFBMTCkgcmVnaXN0ZXJzLiBUaGUgQklPUyBhbHNvIHJlYWQg dGhlCj4+IFRTTiBsYW5lIHJlZ2lzdGVycyBmcm9tIEZsZXhpYmxlIEkvTyBBZGFwdGVyIChGSUEp IGJsb2NrIGFuZCBwcm92aWRlZAo+PiAxMC8xMDAvMTAwME1icHMvMi41R2JwcyBpbmZvcm1hdGlv biB0byB0aGUgc3RtbWFjIGRyaXZlci4gQnV0Cj4+IGF1dG8tbmVnb3RpYXRpb24gYmV0d2VlbiAx MC8xMDAvMTAwME1icHMgYW5kIDIuNUdicHMgaXMgbm90IGFsbG93ZWQuCj4+IFRoZSBuZXcgcHJv cG9zYWwgaXMgdG8gc3VwcG9ydCBhdXRvLW5lZ290aWF0aW9uIGJldHdlZW4gMTAvMTAwLzEwMDBN YnBzCj4+IGFuZCAyLjVHYnBzIC4gQXV0by1uZWdvdGlhdGlvbiBiZXR3ZWVuIDEwLCAxMDAsIDEw MDBNYnBzIHdpbGwgdXNlCj4+IGluLWJhbmQgYXV0byBuZWdvdGlhdGlvbi4gQXV0by1uZWdvdGlh dGlvbiBiZXR3ZWVuIDEwLzEwMC8xMDAwTWJwcyBhbmQKPj4gMi41R2JwcyB3aWxsIHdvcmsgYXMg dGhlIGZvbGxvd2luZyBwcm9wb3NlZCBmbG93LCB0aGUgc3RtbWFjIGRyaXZlciByZWFkcwo+PiB0 aGUgUEhZIGxpbmsgc3RhdHVzIHJlZ2lzdGVycyB0aGVuIGlkZW50aWZpZXMgdGhlIG5lZ290aWF0 ZWQgc3BlZWQuCj4+IEJhc2VkIG9uIHRoZSBzcGVlZCBzdG1tYWMgZHJpdmVyIHdpbGwgaWRlbnRp ZnkgVFNOIGxhbmUgcmVnaXN0ZXJzIGZyb20KPj4gRklBIHRoZW4gc2VuZCBJUEMgY29tbWFuZCB0 byB0aGUgUG93ZXIgTWFuYWdlbWVudCBjb250cm9sbGVyIChQTUMpCj4+IHRocm91Z2ggUE1DIGRy aXZlci9BUEkuIFBNQyB3aWxsIGFjdCBhcyBhIHByb3h5IHRvIHByb2dyYW1zIHRoZQo+PiBQTEwg cmVnaXN0ZXJzLgo+IAo+IEhhdmUgeW91IGNvbnNpZGVyZWQgdXNpbmcgb3V0IG9mIGJhbmQgZm9y IGFsbCBsaW5rIG1vZGVzPyBZb3UgbWlnaHQKPiBlbmQgdXAgd2l0aCBhIGNsZWFuZXIgYXJjaGl0 ZWN0dXJlLCBhbmQgbm90IG5lZWQgYW55IHBoeWxpbmsvcGh5bGliCj4gaGFja3MuCj4gCj4gCUFu ZHJldwpIaSBBbmRyZXcsCgpUaGFuayB5b3UgZm9yIHlvdXIgZmVlZGJhY2suCkkgd2lsbCBzdHVk eSB0aGUgZmVhc2liaWxpdHkgb2YgdGhlIG91dC1vZi1iYW5kIChPT0IpIGFwcHJvYWNoLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=