From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5ACC433DB for ; Thu, 11 Mar 2021 03:26:12 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1A32D64F9F for ; Thu, 11 Mar 2021 03:26:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A32D64F9F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C0C6383E1A; Thu, 11 Mar 2021 03:26:11 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WapM0xV6y3Hd; Thu, 11 Mar 2021 03:26:10 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTP id 33EC083DE6; Thu, 11 Mar 2021 03:26:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 04C21C000B; Thu, 11 Mar 2021 03:26:10 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 404B8C0001 for ; Thu, 11 Mar 2021 03:26:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 278BF4B23B for ; Thu, 11 Mar 2021 03:26:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KdEs7NgWZmGi for ; Thu, 11 Mar 2021 03:26:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 33E164B058 for ; Thu, 11 Mar 2021 03:26:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615433166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MFqvqdxhcEJJpTkmLszHn4IZfhxa3EbZT89ftgo2+BY=; b=fZg5gMBldvBc1/Tw3apKbJR5ejFP0D4nAlOksmCCtiFYLk3IObJm9diJ6wbtLRe37opUQK V2KGuCTi5j1ajlnGBdINX73tjSH8L0skPMdQKD8laVr2QRDS2FBED7wdAxThxBMfz9CqvA Er3UmgAOy+9Dw3o8FYlNqd2WomkfOxo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-YZ3Xp-TGOkGLGBFEgckrVg-1; Wed, 10 Mar 2021 22:26:05 -0500 X-MC-Unique: YZ3Xp-TGOkGLGBFEgckrVg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 014A41009E2D; Thu, 11 Mar 2021 03:26:04 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-13-9.pek2.redhat.com [10.72.13.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2129F5D6D7; Thu, 11 Mar 2021 03:25:57 +0000 (UTC) Subject: Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids To: Zhu Lingshan , mst@redhat.com, lulu@redhat.com, leonro@nvidia.com References: <20210310090052.4762-1-lingshan.zhu@intel.com> <20210310090052.4762-4-lingshan.zhu@intel.com> From: Jason Wang Message-ID: <5e2b22cc-7faa-2987-a30a-ce32f10099b6@redhat.com> Date: Thu, 11 Mar 2021 11:25:56 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210310090052.4762-4-lingshan.zhu@intel.com> Content-Language: en-GB X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Ck9uIDIwMjEvMy8xMCA1OjAwIOS4i+WNiCwgWmh1IExpbmdzaGFuIHdyb3RlOgo+IElGQ1ZGIGRy aXZlciBwcm9iZXMgbXVsdGlwbGUgdHlwZXMgb2YgZGV2aWNlcyBub3csCj4gdG8gZGlzdGluZ3Vp c2ggdGhlIG9yaWdpbmFsIGRldmljZSBkcml2ZW4gYnkgSUZDVkYKPiBmcm9tIG90aGVycywgaXQg aXMgcmVuYW1lZCBhcyAiTjMwMDAiLgo+Cj4gU2lnbmVkLW9mZi1ieTogWmh1IExpbmdzaGFuIDxs aW5nc2hhbi56aHVAaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3Zm X2Jhc2UuaCB8IDggKysrKy0tLS0KPiAgIGRyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9tYWluLmMg fCA4ICsrKystLS0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgOCBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfYmFzZS5o IGIvZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX2Jhc2UuaAo+IGluZGV4IDc1ZDlhODA1MjAzOS4u Nzk0ZDE1MDVkODU3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9iYXNl LmgKPiArKysgYi9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfYmFzZS5oCj4gQEAgLTE4LDEwICsx OCwxMCBAQAo+ICAgI2luY2x1ZGUgPHVhcGkvbGludXgvdmlydGlvX2NvbmZpZy5oPgo+ICAgI2lu Y2x1ZGUgPHVhcGkvbGludXgvdmlydGlvX3BjaS5oPgo+ICAgCj4gLSNkZWZpbmUgSUZDVkZfVkVO RE9SX0lECQkweDFBRjQKPiAtI2RlZmluZSBJRkNWRl9ERVZJQ0VfSUQJCTB4MTA0MQo+IC0jZGVm aW5lIElGQ1ZGX1NVQlNZU19WRU5ET1JfSUQJMHg4MDg2Cj4gLSNkZWZpbmUgSUZDVkZfU1VCU1lT X0RFVklDRV9JRAkweDAwMUEKPiArI2RlZmluZSBOMzAwMF9WRU5ET1JfSUQJCTB4MUFGNAo+ICsj ZGVmaW5lIE4zMDAwX0RFVklDRV9JRAkJMHgxMDQxCj4gKyNkZWZpbmUgTjMwMDBfU1VCU1lTX1ZF TkRPUl9JRAkweDgwODYKPiArI2RlZmluZSBOMzAwMF9TVUJTWVNfREVWSUNFX0lECTB4MDAxQQo+ ICAgCj4gICAjZGVmaW5lIEM1MDAwWF9QTF9WRU5ET1JfSUQJCTB4MUFGNAo+ICAgI2RlZmluZSBD NTAwMFhfUExfREVWSUNFX0lECQkweDEwMDAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92ZHBhL2lm Y3ZmL2lmY3ZmX21haW4uYyBiL2RyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9tYWluLmMKPiBpbmRl eCAyNmEyZGFiN2NhNjYuLmZkNWJlZmM1Y2JjYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3ZkcGEv aWZjdmYvaWZjdmZfbWFpbi5jCj4gKysrIGIvZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX21haW4u Ywo+IEBAIC00ODAsMTAgKzQ4MCwxMCBAQCBzdGF0aWMgdm9pZCBpZmN2Zl9yZW1vdmUoc3RydWN0 IHBjaV9kZXYgKnBkZXYpCj4gICB9Cj4gICAKPiAgIHN0YXRpYyBzdHJ1Y3QgcGNpX2RldmljZV9p ZCBpZmN2Zl9wY2lfaWRzW10gPSB7Cj4gLQl7IFBDSV9ERVZJQ0VfU1VCKElGQ1ZGX1ZFTkRPUl9J RCwKPiAtCQlJRkNWRl9ERVZJQ0VfSUQsCj4gLQkJSUZDVkZfU1VCU1lTX1ZFTkRPUl9JRCwKPiAt CQlJRkNWRl9TVUJTWVNfREVWSUNFX0lEKSB9LAo+ICsJeyBQQ0lfREVWSUNFX1NVQihOMzAwMF9W RU5ET1JfSUQsCj4gKwkJCSBOMzAwMF9ERVZJQ0VfSUQsCgoKSSBhbSBub3Qgc3VyZSB0aGUgcGxh biBmb3IgSW50ZWwgYnV0IEkgd29uZGVyIGlmIHdlIGNhbiBzaW1wbHkgdXNlIApQQ0lfQU5ZX0lE IGZvciBkZXZpY2UgaWQgaGVyZS4gT3RoZXJld2lzZSB5b3UgbmVlZCB0byBtYWludGFpbiBhIHZl cnkgCmxvbmcgbGlzdCBvZiBpZHMgaGVyZS4KClRoYW5rcwoKCj4gKwkJCSBOMzAwMF9TVUJTWVNf VkVORE9SX0lELAo+ICsJCQkgTjMwMDBfU1VCU1lTX0RFVklDRV9JRCkgfSwKPiAgIAl7IFBDSV9E RVZJQ0VfU1VCKEM1MDAwWF9QTF9WRU5ET1JfSUQsCj4gICAJCQkgQzUwMDBYX1BMX0RFVklDRV9J RCwKPiAgIAkJCSBDNTAwMFhfUExfU1VCU1lTX1ZFTkRPUl9JRCwKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlz dApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3Rz LmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39978C4332B for ; Thu, 11 Mar 2021 03:27:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CAAB64FA1 for ; Thu, 11 Mar 2021 03:27:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229723AbhCKD00 (ORCPT ); Wed, 10 Mar 2021 22:26:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:36234 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229887AbhCKD0I (ORCPT ); Wed, 10 Mar 2021 22:26:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615433166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MFqvqdxhcEJJpTkmLszHn4IZfhxa3EbZT89ftgo2+BY=; b=fZg5gMBldvBc1/Tw3apKbJR5ejFP0D4nAlOksmCCtiFYLk3IObJm9diJ6wbtLRe37opUQK V2KGuCTi5j1ajlnGBdINX73tjSH8L0skPMdQKD8laVr2QRDS2FBED7wdAxThxBMfz9CqvA Er3UmgAOy+9Dw3o8FYlNqd2WomkfOxo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-YZ3Xp-TGOkGLGBFEgckrVg-1; Wed, 10 Mar 2021 22:26:05 -0500 X-MC-Unique: YZ3Xp-TGOkGLGBFEgckrVg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 014A41009E2D; Thu, 11 Mar 2021 03:26:04 +0000 (UTC) Received: from wangxiaodeMacBook-Air.local (ovpn-13-9.pek2.redhat.com [10.72.13.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2129F5D6D7; Thu, 11 Mar 2021 03:25:57 +0000 (UTC) Subject: Re: [PATCH V3 3/6] vDPA/ifcvf: rename original IFCVF dev ids to N3000 ids To: Zhu Lingshan , mst@redhat.com, lulu@redhat.com, leonro@nvidia.com Cc: virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210310090052.4762-1-lingshan.zhu@intel.com> <20210310090052.4762-4-lingshan.zhu@intel.com> From: Jason Wang Message-ID: <5e2b22cc-7faa-2987-a30a-ce32f10099b6@redhat.com> Date: Thu, 11 Mar 2021 11:25:56 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210310090052.4762-4-lingshan.zhu@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2021/3/10 5:00 下午, Zhu Lingshan wrote: > IFCVF driver probes multiple types of devices now, > to distinguish the original device driven by IFCVF > from others, it is renamed as "N3000". > > Signed-off-by: Zhu Lingshan > --- > drivers/vdpa/ifcvf/ifcvf_base.h | 8 ++++---- > drivers/vdpa/ifcvf/ifcvf_main.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h > index 75d9a8052039..794d1505d857 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_base.h > +++ b/drivers/vdpa/ifcvf/ifcvf_base.h > @@ -18,10 +18,10 @@ > #include > #include > > -#define IFCVF_VENDOR_ID 0x1AF4 > -#define IFCVF_DEVICE_ID 0x1041 > -#define IFCVF_SUBSYS_VENDOR_ID 0x8086 > -#define IFCVF_SUBSYS_DEVICE_ID 0x001A > +#define N3000_VENDOR_ID 0x1AF4 > +#define N3000_DEVICE_ID 0x1041 > +#define N3000_SUBSYS_VENDOR_ID 0x8086 > +#define N3000_SUBSYS_DEVICE_ID 0x001A > > #define C5000X_PL_VENDOR_ID 0x1AF4 > #define C5000X_PL_DEVICE_ID 0x1000 > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c > index 26a2dab7ca66..fd5befc5cbcc 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > @@ -480,10 +480,10 @@ static void ifcvf_remove(struct pci_dev *pdev) > } > > static struct pci_device_id ifcvf_pci_ids[] = { > - { PCI_DEVICE_SUB(IFCVF_VENDOR_ID, > - IFCVF_DEVICE_ID, > - IFCVF_SUBSYS_VENDOR_ID, > - IFCVF_SUBSYS_DEVICE_ID) }, > + { PCI_DEVICE_SUB(N3000_VENDOR_ID, > + N3000_DEVICE_ID, I am not sure the plan for Intel but I wonder if we can simply use PCI_ANY_ID for device id here. Otherewise you need to maintain a very long list of ids here. Thanks > + N3000_SUBSYS_VENDOR_ID, > + N3000_SUBSYS_DEVICE_ID) }, > { PCI_DEVICE_SUB(C5000X_PL_VENDOR_ID, > C5000X_PL_DEVICE_ID, > C5000X_PL_SUBSYS_VENDOR_ID,