From: Stephen Boyd <swboyd@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Rob Herring <robh@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
<devicetree@vger.kernel.org>,
Andrey Pronin <apronin@chromium.org>
Subject: Re: [PATCH] dt-bindings: tpm: Convert cr50 binding to YAML
Date: Fri, 31 Jan 2020 17:35:14 -0800 [thread overview]
Message-ID: <5e34d5d3.1c69fb81.b5d48.eb80@mx.google.com> (raw)
In-Reply-To: <5e174fec.1c69fb81.f3e14.8354@mx.google.com>
Quoting Stephen Boyd (2020-01-09 08:08:11)
> Quoting Doug Anderson (2019-12-17 09:45:02)
> > On Mon, Dec 16, 2019 at 4:54 PM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > > + spi-max-frequency:
> > > + maxItems: 1
> >
> > This is not an array type. Why do you need maxItems? Should treat
> > like an int? Do we have any ranges of sane values we can put here?
> > I'm sure that there is a maximum that Cr50 can talk at.
>
> From what I see looking through downstream sources my best guess for a
> max frequency is 1 MHz.
>
I'm leaning towards dropping this property. Is there any benefit? The
driver should know the max anyway.
prev parent reply other threads:[~2020-02-01 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 0:54 [PATCH] dt-bindings: tpm: Convert cr50 binding to YAML Stephen Boyd
2019-12-17 17:45 ` Doug Anderson
2019-12-20 23:10 ` Rob Herring
[not found] ` <5e12cc29.1c69fb81.fe838.d5f3@mx.google.com>
2020-01-08 0:40 ` Doug Anderson
2020-01-16 17:58 ` Andrey Pronin
[not found] ` <5e174fec.1c69fb81.f3e14.8354@mx.google.com>
2020-02-01 1:35 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e34d5d3.1c69fb81.b5d48.eb80@mx.google.com \
--to=swboyd@chromium.org \
--cc=apronin@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.