From: Yonghong Song <yhs@fb.com>
To: Andrii Nakryiko <andrii@kernel.org>, <bpf@vger.kernel.org>,
<netdev@vger.kernel.org>, <ast@fb.com>, <daniel@iogearbox.net>
Cc: <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: fix compiler warning in BPF_KPROBE definition in loop6.c
Date: Mon, 8 Mar 2021 21:29:43 -0800 [thread overview]
Message-ID: <5e690d92-f385-6d79-4bb0-6dc8d9103309@fb.com> (raw)
In-Reply-To: <20210309044322.3487636-1-andrii@kernel.org>
On 3/8/21 8:43 PM, Andrii Nakryiko wrote:
> Add missing return type to BPF_KPROBE definition. Without it, compiler
> generates the following warning:
>
> progs/loop6.c:68:12: warning: type specifier missing, defaults to 'int' [-Wimplicit-int]
> BPF_KPROBE(trace_virtqueue_add_sgs, void *unused, struct scatterlist **sgs,
> ^
> 1 warning generated.
>
> Fixes: 86a35af628e5 ("selftests/bpf: Add a verifier scale test with unknown bounded loop")
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Oh, my bad. Thanks for fixing it!
Acked-by: Yonghong Song <yhs@fb.com>
prev parent reply other threads:[~2021-03-09 5:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 4:43 [PATCH bpf-next] selftests/bpf: fix compiler warning in BPF_KPROBE definition in loop6.c Andrii Nakryiko
2021-03-09 5:29 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e690d92-f385-6d79-4bb0-6dc8d9103309@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.