From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] x86/alternatives: Factor out access to ideal_nops[]
Date: Mon, 2 Jun 2025 11:50:02 +0200 [thread overview]
Message-ID: <5e69c4cf-dc13-4ff0-ad2a-94807d751ef7@suse.com> (raw)
In-Reply-To: <20250522150015.555492-2-andrew.cooper3@citrix.com>
On 22.05.2025 17:00, Andrew Cooper wrote:
> --- a/xen/arch/x86/alternative.c
> +++ b/xen/arch/x86/alternative.c
> @@ -86,6 +86,11 @@ static bool init_or_livepatch_read_mostly toolchain_nops_are_ideal;
> # define toolchain_nops_are_ideal false
> #endif
>
> +static const unsigned char *get_ideal_nops(unsigned int noplen)
Right here this wants to be init_or_livepatch. I didn't go check whether
subsequent patches add a truly non-init caller. If so - fine as is;
otherwise with the attribute added:
Acked-by: Jan Beulich <jbeulich@suse.com>
Jan
next prev parent reply other threads:[~2025-06-02 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 15:00 [PATCH 0/3] x86/alt: Simplify nops handling Andrew Cooper
2025-05-22 15:00 ` [PATCH 1/3] x86/alternatives: Factor out access to ideal_nops[] Andrew Cooper
2025-06-02 9:50 ` Jan Beulich [this message]
2025-05-22 15:00 ` [PATCH 2/3] x86/alternatives: Rework get_ideal_nops() Andrew Cooper
2025-06-02 9:57 ` Jan Beulich
2025-05-22 15:00 ` [PATCH 3/3] x86/alternatives: Introduce init_or_livepatch_ro_after_init Andrew Cooper
2025-06-02 9:59 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e69c4cf-dc13-4ff0-ad2a-94807d751ef7@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.