From: Ridong Chen <ridong.chen@linux.dev>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>,
Muchun Song <muchun.song@linux.dev>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Nhat Pham <nphamcs@gmail.com>, Baoquan He <baoquan.he@linux.dev>,
Barry Song <baohua@kernel.org>,
Youngjun Park <youngjun.park@lge.com>,
David Hildenbrand <david@kernel.org>,
Qi Zheng <qi.zheng@linux.dev>, Lorenzo Stoakes <ljs@kernel.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
Davidlohr Bueso <dave@stgolabs.net>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Song Hu <husong@kylinos.cn>,
Ridong Chen <chenridong@xiaomi.com>
Subject: Re: [PATCH -v4 0/2] mm: vmscan: fix node reclaim ignoring swappiness parameter
Date: Fri, 24 Jul 2026 09:11:18 +0800 [thread overview]
Message-ID: <5e8d124b-c96f-466d-8947-68cde3014a17@linux.dev> (raw)
In-Reply-To: <20260723173418.010e38f655f83850d92c2c8e@linux-foundation.org>
On 7/24/2026 8:34 AM, Andrew Morton wrote:
> On Thu, 23 Jul 2026 11:24:32 +0800 Ridong <ridong.chen@linux.dev> wrote:
>
>> From: Ridong Chen <chenridong@xiaomi.com>
>>
>> The per-node proactive reclaim interface
>> (/sys/devices/system/node/nodeX/reclaim) accepts a swappiness parameter,
>> but it is silently ignored when CONFIG_MEMCG is disabled. The root cause
>> is that sc_swappiness() has separate implementations for CONFIG_MEMCG and
>> !CONFIG_MEMCG, and the latter never checks proactive_swappiness.
>>
>> Patch 1 moves mem_cgroup_swappiness() and vm_swappiness out of the public
>> include/linux/swap.h into the mm-private mm/swap.h, and makes the helper
>> handle both CONFIG_MEMCG and !CONFIG_MEMCG in a single inline function.
>> This is a prerequisite for unifying sc_swappiness().
>>
>> Patch 2 consolidates sc_swappiness() into a single definition that works
>> regardless of CONFIG_MEMCG, fixing the node reclaim swappiness bug.
>
> Thanks, I updated mm.git to this version.
>
Thanks.
--
Best regards
Ridong
prev parent reply other threads:[~2026-07-24 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 3:24 [PATCH -v4 0/2] mm: vmscan: fix node reclaim ignoring swappiness parameter Ridong
2026-07-23 3:24 ` [PATCH -v4 1/2] memcg: move mem_cgroup_swappiness and vm_swappiness to mm/swap.h Ridong
2026-07-24 4:18 ` Shakeel Butt
2026-07-23 3:24 ` [PATCH -v4 2/2] mm: vmscan: fix node reclaim ignoring swappiness parameter Ridong
2026-07-24 0:34 ` [PATCH -v4 0/2] " Andrew Morton
2026-07-24 1:11 ` Ridong Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e8d124b-c96f-466d-8947-68cde3014a17@linux.dev \
--to=ridong.chen@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=baohua@kernel.org \
--cc=baoquan.he@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@xiaomi.com \
--cc=chrisl@kernel.org \
--cc=dave@stgolabs.net \
--cc=david@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=husong@kylinos.cn \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=qi.zheng@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=shikemeng@huaweicloud.com \
--cc=weixugc@google.com \
--cc=youngjun.park@lge.com \
--cc=yuanchu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.