From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] core/br2-external: report better error messages
Date: Sun, 14 Jun 2020 17:33:48 +0200 [thread overview]
Message-ID: <5ea0d6a7-1ad1-657e-198a-e9c0e813b98d@gmail.com> (raw)
In-Reply-To: <f7b374aa76093cdf59fd788d7c8cc39b86415eb6.1590183628.git.yann.morin.1998@free.fr>
Le 22/05/2020 ? 23:40, Yann E. MORIN a ?crit?:
> The error is misleading: it reports that no name was provided,
> when in fact the external.desc file is missing.
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Best regards,
Romain
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>p
> ---
> support/scripts/br2-external | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/support/scripts/br2-external b/support/scripts/br2-external
> index fdea5aa251..ededd2d900 100755
> --- a/support/scripts/br2-external
> +++ b/support/scripts/br2-external
> @@ -75,7 +75,7 @@ do_validate_one() {
> error "'%s': permission denied\n" "${br2_ext}"
> fi
> if [ ! -f "${br2_ext}/external.desc" ]; then
> - error "'%s': does not have a name (in 'external.desc'). See %s\n" \
> + error "'%s': does not have an 'external.desc'. See %s\n" \
> "${br2_ext}" "${MANUAL_URL}"
> fi
> br2_name="$(sed -r -e '/^name: +(.*)$/!d; s//\1/' "${br2_ext}/external.desc")"
>
next prev parent reply other threads:[~2020-06-14 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 21:40 [Buildroot] [PATCH 0/2] core/br2-external: fix reporting errors (branch yem/br2-ext-fixes) Yann E. MORIN
2020-05-22 21:40 ` [Buildroot] [PATCH 1/2] core.br2-external: fix reporting errors Yann E. MORIN
2020-06-14 15:33 ` Romain Naour
2020-06-14 15:55 ` Yann E. MORIN
2020-06-14 16:47 ` Romain Naour
2020-06-15 9:03 ` Yann E. MORIN
2020-07-15 19:29 ` Peter Korsgaard
2020-05-22 21:40 ` [Buildroot] [PATCH 2/2] core/br2-external: report better error messages Yann E. MORIN
2020-06-14 15:33 ` Romain Naour [this message]
2020-07-15 19:29 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ea0d6a7-1ad1-657e-198a-e9c0e813b98d@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.