All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Shivam Chaudhary <cvam0000@gmail.com>, selftests@ellerman.id.au
Cc: linux-kselftest@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] Add Selftest to test fork() syscall
Date: Wed, 23 Oct 2024 16:06:38 -0600	[thread overview]
Message-ID: <5ea4792b-c509-4afa-ac80-44194a54eb32@linuxfoundation.org> (raw)
In-Reply-To: <c95ada18-e0bd-4df7-b990-3a9bda2efee3@gmail.com>

On 10/23/24 15:11, Shivam Chaudhary wrote:
> 
> On 24/10/24 2:15 AM, Shuah Khan wrote:
>> On 10/22/24 14:42, Shivam Chaudhary wrote:
>>> This test verifies the correct behavior of the fork() system call,
>>> which creates a child process by duplicating the parent process.
>>>
>>> The test checks the following:
>>> - The child PID returned by fork() is present in /proc.
>>> - The child PID is different from the parent PID.
>>> - The memory allocated to a variable in the child process is independent
>>>    of the parent process.
>>
>> Short log should incude the subsystem:
>>
>> e.g: selftests: add test for fork() syscall
>>
>> In anycase, I don't see any value to adding this test.
>> fork() is a heavily used system call.
>>
> 
> Thanks for responding Shuah,
> 
> Yes, you are correct that fork() is a heavily used syscall, that is why my concern is that
> 
> it could fail millions of other program that depends on fork() if any error or regression
> 
> occurs in the future. In my opinion, that is why we should test it every way possible.
> 
> 

Sorry. I don't see any value in adding this test.

thanks,
-- Shuah


      reply	other threads:[~2024-10-23 22:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22 20:42 [PATCH] Add Selftest to test fork() syscall Shivam Chaudhary
2024-10-23 20:45 ` Shuah Khan
2024-10-23 21:11   ` Shivam Chaudhary
2024-10-23 22:06     ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ea4792b-c509-4afa-ac80-44194a54eb32@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=cvam0000@gmail.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=selftests@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.