From: bluez.test.bot@gmail.com
To: linux-bluetooth@vger.kernel.org, apusaka@google.com
Subject: RE: [Bluez,v1] shared/gatt-server: Fix read multiple charc values
Date: Wed, 06 May 2020 05:09:14 -0700 (PDT) [thread overview]
Message-ID: <5eb2a8ea.1c69fb81.8cc5.72c2@mx.google.com> (raw)
In-Reply-To: <20200506194332.Bluez.v1.1.I45da219fa28f72db2e11778c15cee5aad446b1c4@changeid>
[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.
Test Result:
Checkbuild Failed
Patch Series:
[Bluez,v1] shared/gatt-server: Fix read multiple charc values
Outputs:
ar: `u' modifier ignored since `D' is the default (see `U')
src/shared/gatt-server.c: In function ‘read_multiple_complete_cb’:
src/shared/gatt-server.c:42:24: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
42 | #define MAX(a, b) ((a) > (b) ? (a) : (b))
| ^
src/shared/gatt-server.c:46:27: note: in definition of macro ‘MIN’
46 | #define MIN(a, b) ((a) < (b) ? (a) : (b))
| ^
src/shared/gatt-server.c:1065:13: note: in expansion of macro ‘MAX’
1065 | MIN(len, MAX(0, data->mtu - data->length - 3)) :
| ^~~
src/shared/gatt-server.c:42:24: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
42 | #define MAX(a, b) ((a) > (b) ? (a) : (b))
| ^
src/shared/gatt-server.c:46:39: note: in definition of macro ‘MIN’
46 | #define MIN(a, b) ((a) < (b) ? (a) : (b))
| ^
src/shared/gatt-server.c:1065:13: note: in expansion of macro ‘MAX’
1065 | MIN(len, MAX(0, data->mtu - data->length - 3)) :
| ^~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:6807: src/shared/gatt-server.lo] Error 1
make: *** [Makefile:4010: all] Error 2
---
Regards,
Linux Bluetooth
next prev parent reply other threads:[~2020-05-06 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 11:44 [Bluez PATCH v1] shared/gatt-server: Fix read multiple charc values Archie Pusaka
2020-05-06 12:09 ` bluez.test.bot [this message]
2020-05-06 17:28 ` Luiz Augusto von Dentz
2020-05-07 2:02 ` Archie Pusaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eb2a8ea.1c69fb81.8cc5.72c2@mx.google.com \
--to=bluez.test.bot@gmail.com \
--cc=apusaka@google.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.