All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: "Tim Harvey" <tharvey@gateworks.com>,
	"Jean Delvare" <jdelvare@suse.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Xu Yilun" <yilun.xu@intel.com>, "Tom Rix" <trix@redhat.com>,
	"Jonas Malaco" <jonas@protocubo.io>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Michael Walle" <mwalle@kernel.org>,
	"Maximilian Luz" <luzmaximilian@gmail.com>,
	"Ivor Wanders" <ivor@iwanders.net>
Cc: Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
	linux-rpi-kernel@lists.infradead.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 3/9] hwmon: surface_fan: Use new helper hwmon_visible_0444
Date: Wed, 9 Oct 2024 22:05:00 +0200	[thread overview]
Message-ID: <5eba910e-709e-4275-a018-17fa287dfb19@gmail.com> (raw)
In-Reply-To: <3aecbfc5-e11b-4425-9c6b-88dac2d32945@gmail.com>

Use new helper hwmon_visible_0444 to simplify the code.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/hwmon/surface_fan.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/hwmon/surface_fan.c b/drivers/hwmon/surface_fan.c
index de3c5a240..2f173c51d 100644
--- a/drivers/hwmon/surface_fan.c
+++ b/drivers/hwmon/surface_fan.c
@@ -18,14 +18,6 @@ SSAM_DEFINE_SYNC_REQUEST_CL_R(__ssam_fan_rpm_get, __le16, {
 	.command_id      = 0x01,
 });
 
-// hwmon
-static umode_t surface_fan_hwmon_is_visible(const void *drvdata,
-					    enum hwmon_sensor_types type, u32 attr,
-					    int channel)
-{
-	return 0444;
-}
-
 static int surface_fan_hwmon_read(struct device *dev,
 				  enum hwmon_sensor_types type, u32 attr,
 				  int channel, long *val)
@@ -49,7 +41,7 @@ static const struct hwmon_channel_info *const surface_fan_info[] = {
 };
 
 static const struct hwmon_ops surface_fan_hwmon_ops = {
-	.is_visible = surface_fan_hwmon_is_visible,
+	.is_visible = hwmon_visible_0444,
 	.read = surface_fan_hwmon_read,
 };
 
-- 
2.47.0



  parent reply	other threads:[~2024-10-09 20:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 20:02 [PATCH 0/9] hwmon: Add and use helper hwmon_visible_0444 Heiner Kallweit
2024-10-09 20:03 ` [PATCH 1/9] hwmon: Add " Heiner Kallweit
2024-10-09 20:04 ` [PATCH 2/9] hwmon: i5500_temp: Use new " Heiner Kallweit
2024-10-09 20:05 ` Heiner Kallweit [this message]
2024-10-09 20:05 ` [PATCH 4/9] hwmon: sl28cpld: " Heiner Kallweit
2024-10-09 20:48   ` Michael Walle
2024-10-09 20:06 ` [PATCH 5/9] hwmon: gsc: " Heiner Kallweit
2024-10-09 20:07 ` [PATCH 6/9] hwmon: powerz: " Heiner Kallweit
2024-10-09 20:07 ` [PATCH 7/9] hwmon: raspberrypi: " Heiner Kallweit
2024-10-09 20:08 ` [PATCH 8/9] hwmon: intel-m10-bmc: " Heiner Kallweit
2024-10-09 20:09 ` [PATCH 9/9] hwmon: nzxt-kraken2: " Heiner Kallweit
2024-10-09 22:19 ` [PATCH 0/9] hwmon: Add and use " Guenter Roeck
2024-10-10  5:44   ` Heiner Kallweit
2024-10-10 11:31     ` Jonathan Cameron
2024-10-10 14:31     ` Guenter Roeck
2024-10-10 15:14       ` Heiner Kallweit
2024-10-10 15:39         ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5eba910e-709e-4275-a018-17fa287dfb19@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=ivor@iwanders.net \
    --cc=jdelvare@suse.com \
    --cc=jonas@protocubo.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux@roeck-us.net \
    --cc=linux@weissschuh.net \
    --cc=luzmaximilian@gmail.com \
    --cc=mwalle@kernel.org \
    --cc=tharvey@gateworks.com \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.