All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, Anuj gupta <anuj1072538@gmail.com>
Cc: Anuj Gupta <anuj20.g@samsung.com>,
	io-uring@vger.kernel.org, joshi.k@samsung.com
Subject: Re: [PATCH liburing] test/io_uring_passthrough: add test for vectored fixed-buffers
Date: Wed, 21 May 2025 15:46:49 +0100	[thread overview]
Message-ID: <5ec492a2-082d-4797-b231-088564d763a0@gmail.com> (raw)
In-Reply-To: <b4f0d0ef-b05f-4f40-bace-e7632293fbb6@kernel.dk>

On 5/21/25 15:14, Jens Axboe wrote:
> On 5/21/25 8:05 AM, Pavel Begunkov wrote:
>>> About the use of io_uring_prep_read/write*() helpers ? you're right,
>>> they don?t really add much here since the passthrough command handles
>>> the fields directly. I?ll work on a cleanup patch to remove those and
>>> simplify the submission code.
>>
>> I don't care about the test itself much, but it means there
>> are lots of unused fields for the nvme commands that are not
>> checked by the kernel and hence can't be reused in the future.
>> That's not great
> 
> It's still a pretty recent addition, no reason we can't add the checks
> and get them back to stable as well. At least that would open the door
> for more easy future expansion.

nvme passthrough? It has been around for a while

commit 456cba386e94f22fa1b1426303fdcac9e66b1417
Author: Kanchan Joshi <joshi.k@samsung.com>
Date:   Wed May 11 11:17:48 2022 +0530

     nvme: wire-up uring-cmd support for io-passthru on char-device.


and if people followed the test for initialising sqes, it'll start
failing for them.

-- 
Pavel Begunkov


  reply	other threads:[~2025-05-21 14:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250521083658epcas5p2c2d23dbcfac4242343365bb85301c5ea@epcas5p2.samsung.com>
2025-05-21  8:19 ` [PATCH liburing] test/io_uring_passthrough: add test for vectored fixed-buffers Anuj Gupta
2025-05-21  9:42   ` Pavel Begunkov
2025-05-21 10:35     ` Anuj gupta
2025-05-21 13:08       ` Jens Axboe
2025-05-21 14:20         ` Anuj gupta
2025-05-21 14:24           ` Jens Axboe
2025-05-21 14:05       ` Pavel Begunkov
2025-05-21 14:14         ` Jens Axboe
2025-05-21 14:46           ` Pavel Begunkov [this message]
2025-05-21 14:51             ` Jens Axboe
2025-05-21 13:08   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ec492a2-082d-4797-b231-088564d763a0@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=anuj1072538@gmail.com \
    --cc=anuj20.g@samsung.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    --cc=joshi.k@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.